On Tue, 21 Jan 2025 13:56:30 GMT, Eirik Bjørsnøs wrote:
>> Please review this cleanup PR which updates a total of 12 links to external
>> documentation or references in `java.base` to use https instead of plain
>> text http.
>>
>> Links in `java.security` and `share/data/tzdata` are excluded f
On Tue, 21 Jan 2025 06:51:10 GMT, Thomas Stuefe wrote:
>>> In ProcessImpl_md.c, we have adopted the Posix APIs and semantics for
>>> process handling. I suggest removing the "unofficial" link, it does not
>>> include useful information at this point and is fragile.
>>>
>>> The current behavior
On Tue, 21 Jan 2025 13:56:30 GMT, Eirik Bjørsnøs wrote:
>> Please review this cleanup PR which updates a total of 12 links to external
>> documentation or references in `java.base` to use https instead of plain
>> text http.
>>
>> Links in `java.security` and `share/data/tzdata` are excluded f
On Tue, 21 Jan 2025 13:56:30 GMT, Eirik Bjørsnøs wrote:
>> Please review this cleanup PR which updates a total of 12 links to external
>> documentation or references in `java.base` to use https instead of plain
>> text http.
>>
>> Links in `java.security` and `share/data/tzdata` are excluded f
On Tue, 21 Jan 2025 16:25:34 GMT, Roger Riggs wrote:
> I agree doing (in this PR) anything more than fix the link is out of scope.
Good. My understanding is that we are converging on a consensus to:
* Change the broken IBM AIX emprempral port link to the suggested IBM FAQ one
in `PortConfig.j
On Tue, 21 Jan 2025 13:56:30 GMT, Eirik Bjørsnøs wrote:
>> Please review this cleanup PR which updates a total of 12 links to external
>> documentation or references in `java.base` to use https instead of plain
>> text http.
>>
>> Links in `java.security` and `share/data/tzdata` are excluded f
> Please review this cleanup PR which updates a total of 12 links to external
> documentation or references in `java.base` to use https instead of plain text
> http.
>
> Links in `java.security` and `share/data/tzdata` are excluded from this PR.
>
> This is a documentaton-only cleanup. No tests
On Tue, 21 Jan 2025 06:51:10 GMT, Thomas Stuefe wrote:
> > @tstuefe And you also agree that the link should be removed? (Which is what
> > this PR is about)
>
> The 20+ years old link to the PASC error report I would probably remove; it
> is likely outdated now. If one wanted to invest the tim
> Please review this cleanup PR which updates a total of 12 links to external
> documentation or references in `java.base` to use https instead of plain text
> http.
>
> Links in `java.security` and `share/data/tzdata` are excluded from this PR.
>
> This is a documentaton-only cleanup. No tests
On Mon, 20 Jan 2025 19:34:53 GMT, Thomas Stuefe wrote:
>> In ProcessImpl_md.c, we have adopted the Posix APIs and semantics for
>> process handling.
>> I suggest removing the "unofficial" link, it does not include useful
>> information at this point and is fragile.
>>
>> The current behavior a
On Mon, 20 Jan 2025 17:01:10 GMT, Daniel Fuchs wrote:
> > > The problem is, that such IBM links do not work very long. In one or a
> > > view years this link again might point to nirvana.
> >
> >
> > Should we remove it instead then?
>
> I would be OK with just dropping the link.
I would kee
On Mon, 20 Jan 2025 19:34:53 GMT, Thomas Stuefe wrote:
>> In ProcessImpl_md.c, we have adopted the Posix APIs and semantics for
>> process handling.
>> I suggest removing the "unofficial" link, it does not include useful
>> information at this point and is fragile.
>>
>> The current behavior a
On Mon, 20 Jan 2025 17:13:19 GMT, Roger Riggs wrote:
> In ProcessImpl_md.c, we have adopted the Posix APIs and semantics for process
> handling. I suggest removing the "unofficial" link, it does not include
> useful information at this point and is fragile.
>
> The current behavior always sett
On Fri, 17 Jan 2025 18:38:25 GMT, Eirik Bjørsnøs wrote:
>> Please review this cleanup PR which updates a total of 12 links to external
>> documentation or references in `java.base` to use https instead of plain
>> text http.
>>
>> Links in `java.security` and `share/data/tzdata` are excluded f
On Mon, 20 Jan 2025 16:55:10 GMT, Magnus Ihse Bursie wrote:
> > The problem is, that such IBM links do not work very long. In one or a view
> > years this link again might point to nirvana.
>
> Should we remove it instead then?
I would be OK with just dropping the link.
-
PR Comm
On Mon, 20 Jan 2025 16:50:29 GMT, Joachim Kern wrote:
> The problem is, that such IBM links do not work very long. In one or a view
> years this link again might point to nirvana.
Should we remove it instead then?
-
PR Comment: https://git.openjdk.org/jdk/pull/21633#issuecomment-2
On Fri, 17 Jan 2025 18:38:25 GMT, Eirik Bjørsnøs wrote:
>> Please review this cleanup PR which updates a total of 12 links to external
>> documentation or references in `java.base` to use https instead of plain
>> text http.
>>
>> Links in `java.security` and `share/data/tzdata` are excluded f
On Fri, 17 Jan 2025 18:38:25 GMT, Eirik Bjørsnøs wrote:
>> Please review this cleanup PR which updates a total of 12 links to external
>> documentation or references in `java.base` to use https instead of plain
>> text http.
>>
>> Links in `java.security` and `share/data/tzdata` are excluded f
On Fri, 17 Jan 2025 18:38:25 GMT, Eirik Bjørsnøs wrote:
>> Please review this cleanup PR which updates a total of 12 links to external
>> documentation or references in `java.base` to use https instead of plain
>> text http.
>>
>> Links in `java.security` and `share/data/tzdata` are excluded f
On Tue, 22 Oct 2024 19:29:43 GMT, Eirik Bjørsnøs wrote:
>> FWIW: I don't believe a change to a link in a comment in an internal class
>> requires a CSR.
>> For PortConfig.java - it would be good to have someone involved in the AIX
>> port comment on the proposed changes.
>> Removing the obsole
> Please review this cleanup PR which updates a total of 12 links to external
> documentation or references in `java.base` to use https instead of plain text
> http.
>
> Links in `java.security` and `share/data/tzdata` are excluded from this PR.
>
> This is a documentaton-only cleanup. No tests
On Tue, 22 Oct 2024 19:29:43 GMT, Eirik Bjørsnøs wrote:
>> FWIW: I don't believe a change to a link in a comment in an internal class
>> requires a CSR.
>> For PortConfig.java - it would be good to have someone involved in the AIX
>> port comment on the proposed changes.
>> Removing the obsole
On Tue, 22 Oct 2024 18:22:58 GMT, Daniel Fuchs wrote:
> For PortConfig.java - it would be good to have someone involved in the AIX
> port comment on the proposed changes. Removing the obsolete link altogether
> is also a possibility.
The context for the link in PortConfig.java is:
// The ep
On Tue, 22 Oct 2024 17:40:10 GMT, Justin Lu wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove accidental "'"
>
> src/java.base/unix/native/libjava/ProcessImpl_md.c line 109:
>
>> 107: * the jspawnhelper, t
> Please review this cleanup PR which updates a total of 12 links to external
> documentation or references in `java.base` to use https instead of plain text
> http.
>
> Links in `java.security` and `share/data/tzdata` are excluded from this PR.
>
> This is a documentaton-only cleanup. No tests
On Tue, 22 Oct 2024 10:19:23 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which updates a total of 12 links to external
> documentation or references in `java.base` to use https instead of plain text
> http.
>
> Links in `java.security` and `share/data/tzdata` are excluded from t
On Tue, 22 Oct 2024 10:19:23 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which updates a total of 12 links to external
> documentation or references in `java.base` to use https instead of plain text
> http.
>
> Links in `java.security` and `share/data/tzdata` are excluded from t
On Tue, 22 Oct 2024 10:19:23 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which updates a total of 12 links to external
> documentation or references in `java.base` to use https instead of plain text
> http.
>
> Links in `java.security` and `share/data/tzdata` are excluded from t
Please review this cleanup PR which updates a total of 12 links to external
documentation or references in `java.base` to use https instead of plain text
http.
Links in `java.security` and `share/data/tzdata` are excluded from this PR.
This is a documentaton-only cleanup. No tests are added or
29 matches
Mail list logo
