On Wed, 13 Nov 2024 06:40:15 GMT, Joe Darcy wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java
>> line 91:
>>
>>> 89: // JEP-401 (https://openjdk.org/jeps/401).
>>> 90: // @jdk.internal.MigratedValueClass
>>> 91: // @jdk.internal.ValueBased
>>
>> Please uncommen
On Wed, 13 Nov 2024 06:40:15 GMT, Joe Darcy wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java
>> line 91:
>>
>>> 89: // JEP-401 (https://openjdk.org/jeps/401).
>>> 90: // @jdk.internal.MigratedValueClass
>>> 91: // @jdk.internal.ValueBased
>>
>> Please uncommen
On Mon, 11 Nov 2024 02:09:41 GMT, Jatin Bhateja wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line
> 91:
>
>
On Wed, 30 Oct 2024 05:25:47 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
src/jdk.i
On Tue, 12 Nov 2024 12:49:01 GMT, Raffaello Giulietti
wrote:
>> Thanks for catching that; fix and tests added in subsequent push.
>
> Single digit inputs, e.g., `Float16.valueOf"2")` throw as well.
Addressed in most recent push; thanks.
-
PR Review Comment: https://git.openjdk.org
On Tue, 12 Nov 2024 05:38:23 GMT, Joe Darcy wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java
>> line 431:
>>
>>> 429: * @seejava.lang.Float#valueOf(String)
>>> 430: */
>>> 431: public static Float16 valueOf(String s) throws
>>> NumberFormatEx
On Mon, 11 Nov 2024 14:03:54 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line
> 4
On Wed, 30 Oct 2024 05:25:47 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
src/jdk.i
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21574/f