Re: RFR: 8340717: Remove unused function declarations from java.c/java.h of the launcher

2024-09-24 Thread Jaikiran Pai
On Tue, 24 Sep 2024 04:33:14 GMT, Jaikiran Pai wrote: > Can I please get a review of this cleanup to the launcher code to remove > declarations of unused functions? > > The `ValidateModules` function appears to be a left-over from > https://bugs.openjdk.org/browse/JDK-8194937. > > The `SetApp

Re: RFR: 8340717: Remove unused function declarations from java.c/java.h of the launcher

2024-09-24 Thread Julian Waters
On Tue, 24 Sep 2024 04:33:14 GMT, Jaikiran Pai wrote: > Can I please get a review of this cleanup to the launcher code to remove > declarations of unused functions? > > The `ValidateModules` function appears to be a left-over from > https://bugs.openjdk.org/browse/JDK-8194937. > > The `SetApp

Re: RFR: 8340717: Remove unused function declarations from java.c/java.h of the launcher

2024-09-24 Thread Aleksey Shipilev
On Tue, 24 Sep 2024 04:33:14 GMT, Jaikiran Pai wrote: > Can I please get a review of this cleanup to the launcher code to remove > declarations of unused functions? > > The `ValidateModules` function appears to be a left-over from > https://bugs.openjdk.org/browse/JDK-8194937. > > The `SetApp

Re: RFR: 8340717: Remove unused function declarations from java.c/java.h of the launcher

2024-09-24 Thread David Holmes
On Tue, 24 Sep 2024 04:33:14 GMT, Jaikiran Pai wrote: > Can I please get a review of this cleanup to the launcher code to remove > declarations of unused functions? > > The `ValidateModules` function appears to be a left-over from > https://bugs.openjdk.org/browse/JDK-8194937. > > The `SetApp

Re: RFR: 8340717: Remove unused function declarations from java.c/java.h of the launcher

2024-09-24 Thread Alan Bateman
On Tue, 24 Sep 2024 04:33:14 GMT, Jaikiran Pai wrote: > Can I please get a review of this cleanup to the launcher code to remove > declarations of unused functions? > > The `ValidateModules` function appears to be a left-over from > https://bugs.openjdk.org/browse/JDK-8194937. > > The `SetApp

RFR: 8340717: Remove unused function declarations from java.c/java.h of the launcher

2024-09-23 Thread Jaikiran Pai
Can I please get a review of this cleanup to the launcher code to remove declarations of unused functions? The `ValidateModules` function appears to be a left-over from https://bugs.openjdk.org/browse/JDK-8340717. The `SetApplicationClassPath` and `PrintMachineDependentOptions` appear to have