On Tue, 24 Sep 2024 04:33:14 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this cleanup to the launcher code to remove > declarations of unused functions? > > The `ValidateModules` function appears to be a left-over from > https://bugs.openjdk.org/browse/JDK-8194937. > > The `SetApplicationClassPath` and `PrintMachineDependentOptions` appear to > have been unused for a long time (ever since the first commit in the current > JDK repo). > > The data model related macros, being removed in this PR, are unused and no > longer relevant. > > No new tests have been added and existing tier1, tier2 and tier3 tests > continue to pass with this change. LGTM! Thanks ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21149#pullrequestreview-2324259648
