Re: RFR: 8339317: Optimize ClassFile writeBuffer [v7]

2024-09-06 Thread Chen Liang
On Thu, 5 Sep 2024 22:47:00 GMT, Shaojin Wen wrote: >> A small optimization, optimize the BufferWriter implementation and use of >> ClassFile, provide faster patchInt and skip > > Shaojin Wen has updated the pull request with a new target base due to a > merge or a rebase. The pull request now

Re: RFR: 8339317: Optimize ClassFile writeBuffer [v7]

2024-09-06 Thread duke
On Thu, 5 Sep 2024 22:47:00 GMT, Shaojin Wen wrote: >> A small optimization, optimize the BufferWriter implementation and use of >> ClassFile, provide faster patchInt and skip > > Shaojin Wen has updated the pull request with a new target base due to a > merge or a rebase. The pull request now

Re: RFR: 8339317: Optimize ClassFile writeBuffer [v7]

2024-09-06 Thread Claes Redestad
On Thu, 5 Sep 2024 22:47:00 GMT, Shaojin Wen wrote: >> A small optimization, optimize the BufferWriter implementation and use of >> ClassFile, provide faster patchInt and skip > > Shaojin Wen has updated the pull request with a new target base due to a > merge or a rebase. The pull request now

Re: RFR: 8339317: Optimize ClassFile writeBuffer [v7]

2024-09-05 Thread Chen Liang
On Thu, 5 Sep 2024 22:47:00 GMT, Shaojin Wen wrote: >> A small optimization, optimize the BufferWriter implementation and use of >> ClassFile, provide faster patchInt and skip > > Shaojin Wen has updated the pull request with a new target base due to a > merge or a rebase. The pull request now

Re: RFR: 8339317: Optimize ClassFile writeBuffer [v7]

2024-09-05 Thread Shaojin Wen
> A small optimization, optimize the BufferWriter implementation and use of > ClassFile, provide faster patchInt and skip Shaojin Wen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits: - Merge remote-tracking branch 'origi

Re: RFR: 8339317: Optimize ClassFile writeBuffer [v6]

2024-09-05 Thread Chen Liang
On Wed, 4 Sep 2024 00:36:39 GMT, Shaojin Wen wrote: >> A small optimization, optimize the BufferWriter implementation and use of >> ClassFile, provide faster patchInt and skip > > Shaojin Wen has updated the pull request incrementally with two additional > commits since the last revision: > >

Re: RFR: 8339317: Optimize ClassFile writeBuffer [v6]

2024-09-03 Thread Shaojin Wen
> A small optimization, optimize the BufferWriter implementation and use of > ClassFile, provide faster patchInt and skip Shaojin Wen has updated the pull request incrementally with two additional commits since the last revision: - Eliminate redundant variables - buf skip - Chan

Re: RFR: 8339317: Optimize ClassFile writeBuffer [v5]

2024-09-03 Thread Shaojin Wen
> A small optimization, optimize the BufferWriter implementation and use of > ClassFile, provide faster patchInt and skip Shaojin Wen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/reb

Re: RFR: 8339317: Optimize ClassFile writeBuffer [v4]

2024-09-03 Thread Shaojin Wen
> A small optimization, optimize the BufferWriter implementation and use of > ClassFile, provide faster patchInt and skip Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: revert skip - Changes: - all: https://git.openjd

Re: RFR: 8339317: Optimize ClassFile writeBuffer [v3]

2024-09-03 Thread Chen Liang
On Tue, 3 Sep 2024 12:23:50 GMT, Shaojin Wen wrote: >> A small optimization, optimize the BufferWriter implementation and use of >> ClassFile, provide faster patchInt and skip > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8339317: Optimize ClassFile writeBuffer [v3]

2024-09-03 Thread Claes Redestad
On Tue, 3 Sep 2024 12:23:50 GMT, Shaojin Wen wrote: >> A small optimization, optimize the BufferWriter implementation and use of >> ClassFile, provide faster patchInt and skip > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8339317: Optimize ClassFile writeBuffer [v3]

2024-09-03 Thread Shaojin Wen
> A small optimization, optimize the BufferWriter implementation and use of > ClassFile, provide faster patchInt and skip Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: Update src/java.base/share/classes/jdk/internal/classfile/impl/

Re: RFR: 8339317: Optimize ClassFile writeBuffer [v2]

2024-09-03 Thread Shaojin Wen
> A small optimization, optimize the BufferWriter implementation and use of > ClassFile, provide faster patchInt and skip Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: Update src/java.base/share/classes/jdk/internal/classfile/impl/U

Re: RFR: 8339317: Optimize ClassFile writeBuffer [v2]

2024-09-03 Thread Claes Redestad
On Tue, 3 Sep 2024 12:17:45 GMT, Shaojin Wen wrote: >> A small optimization, optimize the BufferWriter implementation and use of >> ClassFile, provide faster patchInt and skip > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8339317: Optimize ClassFile writeBuffer

2024-08-30 Thread Claes Redestad
On Thu, 29 Aug 2024 21:49:58 GMT, Shaojin Wen wrote: > A small optimization, optimize the BufferWriter implementation and use of > ClassFile, provide faster patchInt and skip src/java.base/share/classes/jdk/internal/classfile/impl/AbstractAttributeMapper.java line 68: > 66: BufWriterI

Re: RFR: 8339317: Optimize ClassFile writeBuffer

2024-08-30 Thread Shaojin Wen
On Thu, 29 Aug 2024 21:49:58 GMT, Shaojin Wen wrote: > A small optimization, optimize the BufferWriter implementation and use of > ClassFile, provide faster patchInt and skip I debugged the code and watched the compile log, patchInt calls are frequent. For example, the following call stack:

Re: RFR: 8339317: Optimize ClassFile writeBuffer

2024-08-30 Thread Chen Liang
On Thu, 29 Aug 2024 21:49:58 GMT, Shaojin Wen wrote: > A small optimization, optimize the BufferWriter implementation and use of > ClassFile, provide faster patchInt and skip `patchInt` isn't that frequently used in workloads. I doubt this specialized version provides much value; maybe @cl4es

RFR: 8339317: Optimize ClassFile writeBuffer

2024-08-30 Thread Shaojin Wen
A small optimization, optimize the BufferWriter implementation and use of ClassFile, provide faster patchInt and skip - Commit messages: - Suggestions from @cl4es - fix build error - remove BufWriter#patchInt - optimize BufWriterImpl#patchInt Changes: https://git.openjdk.org/jdk