On Wed, 4 Sep 2024 00:36:39 GMT, Shaojin Wen <s...@openjdk.org> wrote:

>> A small optimization, optimize the BufferWriter implementation and use of 
>> ClassFile, provide faster patchInt and skip
>
> Shaojin Wen has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - Eliminate redundant variables
>  - buf skip

src/java.base/share/classes/jdk/internal/classfile/impl/AbstractPoolEntry.java 
line 449:

> 447:                         }
> 448:                         int byteLengthFinal = byteLength;
> 449:                         pool.patchU2(pool.size() - i - 2, 
> byteLengthFinal);

This change is causing conflict with your utf8 writing enhancement. Can you 
revert this change and squash commits, or merge latest master to fix this 
conflict?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20780#discussion_r1746202190

Reply via email to