Re: RFR: 8338544: Dedicated Array class descriptor implementation [v6]

2024-10-22 Thread Chen Liang
On Wed, 23 Oct 2024 04:09:37 GMT, Mandy Chung wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Relax displayName spec > > src/java.base/share/classes/java/lang/constant/ClassDesc.java line 278: > >> 276: >> 277:

Re: RFR: 8338544: Dedicated Array class descriptor implementation [v6]

2024-10-22 Thread Mandy Chung
On Tue, 22 Oct 2024 04:50:29 GMT, Chen Liang wrote: >> @cl4es discovered that Stack Map generation in ClassFile API uses >> `componentType` and `arrayType` for `aaload` `aastore` instructions, which >> are currently quite slow. We can split out array class descriptors from >> class or interfac

Re: RFR: 8338544: Dedicated Array class descriptor implementation [v6]

2024-10-22 Thread Chen Liang
On Tue, 22 Oct 2024 23:48:34 GMT, Mandy Chung wrote: >> I believe the specification for class or interface display name is too >> tight: if we have `java.awt.List` versus `java.util.List`, our current >> implementation prints `List` for both cases. It makes sense for an >> implementation to pr

Re: RFR: 8338544: Dedicated Array class descriptor implementation [v6]

2024-10-22 Thread Mandy Chung
On Tue, 22 Oct 2024 23:29:29 GMT, Chen Liang wrote: >> src/java.base/share/classes/java/lang/constant/ClassDesc.java line 278: >> >>> 276: >>> 277: /** >>> 278: * {@return a human-readable name for this {@code ClassDesc}} >> >> I don't see the merit of making the string representation

Re: RFR: 8338544: Dedicated Array class descriptor implementation [v6]

2024-10-22 Thread Chen Liang
On Tue, 22 Oct 2024 20:53:14 GMT, Mandy Chung wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Relax displayName spec > > src/java.base/share/classes/java/lang/constant/ClassDesc.java line 278: > >> 276: >> 277:

Re: RFR: 8338544: Dedicated Array class descriptor implementation [v6]

2024-10-22 Thread Mandy Chung
On Tue, 22 Oct 2024 04:50:29 GMT, Chen Liang wrote: >> @cl4es discovered that Stack Map generation in ClassFile API uses >> `componentType` and `arrayType` for `aaload` `aastore` instructions, which >> are currently quite slow. We can split out array class descriptors from >> class or interfac

Re: RFR: 8338544: Dedicated Array class descriptor implementation [v6]

2024-10-21 Thread Chen Liang
> @cl4es discovered that Stack Map generation in ClassFile API uses > `componentType` and `arrayType` for `aaload` `aastore` instructions, which > are currently quite slow. We can split out array class descriptors from class > or interfaces to support faster `arrayType` and `componentType` opera