Re: RFR: 8336741: Optimize LocalTime.toString with StringBuilder.repeat [v4]

2024-07-24 Thread duke
On Thu, 18 Jul 2024 15:43:05 GMT, Shaojin Wen wrote: >> class LocalTime { >> public String toString() { >> // ... >> if (nanoValue % 1000_000 == 0) { >> buf.append(Integer.toString((nanoValue / 1000_000) + >> 1000).substring(1)); >>

Re: RFR: 8336741: Optimize LocalTime.toString with StringBuilder.repeat [v4]

2024-07-24 Thread Naoto Sato
On Thu, 18 Jul 2024 15:43:05 GMT, Shaojin Wen wrote: >> class LocalTime { >> public String toString() { >> // ... >> if (nanoValue % 1000_000 == 0) { >> buf.append(Integer.toString((nanoValue / 1000_000) + >> 1000).substring(1)); >>

Re: RFR: 8336741: Optimize LocalTime.toString with StringBuilder.repeat [v4]

2024-07-24 Thread Roger Riggs
On Thu, 18 Jul 2024 15:43:05 GMT, Shaojin Wen wrote: >> class LocalTime { >> public String toString() { >> // ... >> if (nanoValue % 1000_000 == 0) { >> buf.append(Integer.toString((nanoValue / 1000_000) + >> 1000).substring(1)); >>

Re: RFR: 8336741: Optimize LocalTime.toString with StringBuilder.repeat [v4]

2024-07-24 Thread Shaojin Wen
On Thu, 18 Jul 2024 15:43:05 GMT, Shaojin Wen wrote: >> class LocalTime { >> public String toString() { >> // ... >> if (nanoValue % 1000_000 == 0) { >> buf.append(Integer.toString((nanoValue / 1000_000) + >> 1000).substring(1)); >>

Re: RFR: 8336741: Optimize LocalTime.toString with StringBuilder.repeat [v4]

2024-07-18 Thread Chen Liang
On Thu, 18 Jul 2024 15:43:05 GMT, Shaojin Wen wrote: >> class LocalTime { >> public String toString() { >> // ... >> if (nanoValue % 1000_000 == 0) { >> buf.append(Integer.toString((nanoValue / 1000_000) + >> 1000).substring(1)); >>

Re: RFR: 8336741: Optimize LocalTime.toString with StringBuilder.repeat [v2]

2024-07-18 Thread Shaojin Wen
> class LocalTime { > public String toString() { > // ... > if (nanoValue % 1000_000 == 0) { > buf.append(Integer.toString((nanoValue / 1000_000) + > 1000).substring(1)); > } else if (nanoValue % 1000 == 0) { > buf

Re: RFR: 8336741: Optimize LocalTime.toString with StringBuilder.repeat [v4]

2024-07-18 Thread Shaojin Wen
> class LocalTime { > public String toString() { > // ... > if (nanoValue % 1000_000 == 0) { > buf.append(Integer.toString((nanoValue / 1000_000) + > 1000).substring(1)); > } else if (nanoValue % 1000 == 0) { > buf

Re: RFR: 8336741: Optimize LocalTime.toString with StringBuilder.repeat [v3]

2024-07-18 Thread Shaojin Wen
On Thu, 18 Jul 2024 15:28:23 GMT, Shaojin Wen wrote: >> class LocalTime { >> public String toString() { >> // ... >> if (nanoValue % 1000_000 == 0) { >> buf.append(Integer.toString((nanoValue / 1000_000) + >> 1000).substring(1)); >>

Re: RFR: 8336741: Optimize LocalTime.toString with StringBuilder.repeat [v3]

2024-07-18 Thread Shaojin Wen
> class LocalTime { > public String toString() { > // ... > if (nanoValue % 1000_000 == 0) { > buf.append(Integer.toString((nanoValue / 1000_000) + > 1000).substring(1)); > } else if (nanoValue % 1000 == 0) { > buf

Re: RFR: 8336741: Optimize LocalTime.toString with StringBuilder.repeat

2024-07-18 Thread Brett Okken
On Thu, 18 Jul 2024 11:32:47 GMT, Shaojin Wen wrote: > class LocalTime { > public String toString() { > // ... > if (nanoValue % 1000_000 == 0) { > buf.append(Integer.toString((nanoValue / 1000_000) + > 1000).substring(1)); > } else

Re: RFR: 8336741: Optimize LocalTime.toString with StringBuilder.repeat

2024-07-18 Thread Chen Liang
On Thu, 18 Jul 2024 11:32:47 GMT, Shaojin Wen wrote: > class LocalTime { > public String toString() { > // ... > if (nanoValue % 1000_000 == 0) { > buf.append(Integer.toString((nanoValue / 1000_000) + > 1000).substring(1)); > } else

Re: RFR: 8336741: Optimize LocalTime.toString with StringBuilder.repeat

2024-07-18 Thread Shaojin Wen
On Thu, 18 Jul 2024 11:32:47 GMT, Shaojin Wen wrote: > class LocalTime { > public String toString() { > // ... > if (nanoValue % 1000_000 == 0) { > buf.append(Integer.toString((nanoValue / 1000_000) + > 1000).substring(1)); > } else

Re: RFR: 8336741: Optimize LocalTime.toString with StringBuilder.repeat

2024-07-18 Thread Roger Riggs
On Thu, 18 Jul 2024 11:32:47 GMT, Shaojin Wen wrote: > class LocalTime { > public String toString() { > // ... > if (nanoValue % 1000_000 == 0) { > buf.append(Integer.toString((nanoValue / 1000_000) + > 1000).substring(1)); > } else

Re: RFR: 8336741: Optimize LocalTime.toString with StringBuilder.repeat

2024-07-18 Thread Shaojin Wen
On Thu, 18 Jul 2024 11:32:47 GMT, Shaojin Wen wrote: > class LocalTime { > public String toString() { > // ... > if (nanoValue % 1000_000 == 0) { > buf.append(Integer.toString((nanoValue / 1000_000) + > 1000).substring(1)); > } else

Re: RFR: 8336741: Optimize LocalTime.toString with StringBuilder.repeat

2024-07-18 Thread Chen Liang
On Thu, 18 Jul 2024 11:32:47 GMT, Shaojin Wen wrote: > class LocalTime { > public String toString() { > // ... > if (nanoValue % 1000_000 == 0) { > buf.append(Integer.toString((nanoValue / 1000_000) + > 1000).substring(1)); > } else

Re: RFR: 8336741: Optimize LocalTime.toString with StringBuilder.repeat

2024-07-18 Thread Shaojin Wen
On Thu, 18 Jul 2024 11:32:47 GMT, Shaojin Wen wrote: > class LocalTime { > public String toString() { > // ... > if (nanoValue % 1000_000 == 0) { > buf.append(Integer.toString((nanoValue / 1000_000) + > 1000).substring(1)); > } else

Re: RFR: 8336741: Optimize LocalTime.toString with StringBuilder.repeat

2024-07-18 Thread Chen Liang
On Thu, 18 Jul 2024 11:32:47 GMT, Shaojin Wen wrote: > class LocalTime { > public String toString() { > // ... > if (nanoValue % 1000_000 == 0) { > buf.append(Integer.toString((nanoValue / 1000_000) + > 1000).substring(1)); > } else

RFR: 8336741: Optimize LocalTime.toString with StringBuilder.repeat

2024-07-18 Thread Shaojin Wen
class LocalTime { public String toString() { // ... if (nanoValue % 1000_000 == 0) { buf.append(Integer.toString((nanoValue / 1000_000) + 1000).substring(1)); } else if (nanoValue % 1000 == 0) { buf.append(Integer.