On Wed, 26 Jun 2024 14:55:44 GMT, Shaojin Wen wrote:
>> The current versions of FloatToDecimal and DoubleToDecimal allocate
>> additional objects. Reducing these allocations can improve the performance
>> of Float/Double.toString and AbstractStringBuilder's append(float/double).
>>
>> This pat
On Wed, 26 Jun 2024 17:42:13 GMT, Chen Liang wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 1. revert code change.
>> 2. comment remove space
>
> src/java.base/share/classes/jdk/internal/math/DoubleToDecimal.java
On Wed, 26 Jun 2024 14:55:44 GMT, Shaojin Wen wrote:
>> The current versions of FloatToDecimal and DoubleToDecimal allocate
>> additional objects. Reducing these allocations can improve the performance
>> of Float/Double.toString and AbstractStringBuilder's append(float/double).
>>
>> This pat
On Wed, 26 Jun 2024 14:55:44 GMT, Shaojin Wen wrote:
>> The current versions of FloatToDecimal and DoubleToDecimal allocate
>> additional objects. Reducing these allocations can improve the performance
>> of Float/Double.toString and AbstractStringBuilder's append(float/double).
>>
>> This pat
On Wed, 26 Jun 2024 14:55:44 GMT, Shaojin Wen wrote:
>> The current versions of FloatToDecimal and DoubleToDecimal allocate
>> additional objects. Reducing these allocations can improve the performance
>> of Float/Double.toString and AbstractStringBuilder's append(float/double).
>>
>> This pat
On Wed, 26 Jun 2024 14:22:03 GMT, Raffaello Giulietti
wrote:
>> I looked at it again and I think @cl4es 's suggestion is correct. Can I
>> submit the change? @rgiulietti
>
> Of course, nothing has been approved as of now.
>
> Since you are preparing a commit anyway, may I ask you to revert bac
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
On Wed, 26 Jun 2024 14:17:47 GMT, Shaojin Wen wrote:
>> Yeah, I'm just musing about the perils of leaking/replicating those
>> implementation details, but as you say this is internal code only used by
>> `String` and `StringBuilder` to it's loosely part of that complex. Not
>> requesting any c
On Wed, 26 Jun 2024 14:00:36 GMT, Claes Redestad wrote:
>> I have written a version using boolean locally, but because this class is
>> mainly used by String and StringBuilder, it uses the same style as
>> String/StringBuilder.
>
> Yeah, I'm just musing about the perils of leaking/replicating t
On Wed, 26 Jun 2024 13:23:14 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/jdk/internal/math/ToDecimal.java line 47:
>>
>>> 45: static final int NAN = 5 << 8;
>>> 46:
>>> 47: static final byte LATIN1 = 0;
>>
>> I think this somewhat unnecessarily copies names and inter
On Wed, 26 Jun 2024 13:20:58 GMT, Shaojin Wen wrote:
>> In principle, you should not arbitrarily change code that is correct, and
>> only limit your changes to reach the goal of the PR.
>> My suggestion is the minimal change required, yours is more than strictly
>> needed.
>
> Got it, should I
On Wed, 26 Jun 2024 13:14:13 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> from @liach: use s.getBytes for performance
>
> src/java.base/share/classes/jdk/internal/math/ToDecimal.java line 47:
On Wed, 26 Jun 2024 12:50:38 GMT, Raffaello Giulietti
wrote:
>> I like the new implementation, the code is cleaner, is your suggestion to
>> revert to the original version due to smaller changes?
>
> In principle, you should not arbitrarily change code that is correct, and
> only limit your ch
On Tue, 25 Jun 2024 17:29:04 GMT, Shaojin Wen wrote:
>> The current versions of FloatToDecimal and DoubleToDecimal allocate
>> additional objects. Reducing these allocations can improve the performance
>> of Float/Double.toString and AbstractStringBuilder's append(float/double).
>>
>> This pat
On Tue, 25 Jun 2024 17:02:10 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/jdk/internal/math/DoubleToDecimal.java line 236:
>>
>>> 234: dk = -1;
>>> 235: }
>>> 236: return toDecimal(str, index, Q_MIN, t, dk, fd) - start;
>>
>> I sugge
On Wed, 26 Jun 2024 11:30:25 GMT, Raffaello Giulietti
wrote:
>> All suggestions have been fixed, can this PR be integrated? @cl4es @liach
>
> @wenshao Looks good, thanks for the improvements.
>
> Let me know when you are finished with your changes.
> Once approved, you should refrain from addi
On Tue, 25 Jun 2024 01:58:29 GMT, Shaojin Wen wrote:
>> Just suggesting some improvements
>
> All suggestions have been fixed, can this PR be integrated? @cl4es @liach
@wenshao Looks good, thanks for the improvements.
Let me know when you are finished with your changes.
Once approved, you shou
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
On Tue, 25 Jun 2024 14:47:45 GMT, Raffaello Giulietti
wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Utf16 case remove `append first utf16 char`
>
> src/java.base/share/classes/jdk/internal/math/DoubleToDecimal.ja
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
On Mon, 17 Jun 2024 04:58:41 GMT, Shaojin Wen wrote:
>> The current versions of FloatToDecimal and DoubleToDecimal allocate
>> additional objects. Reducing these allocations can improve the performance
>> of Float/Double.toString and AbstractStringBuilder's append(float/double).
>>
>> This pat
On Mon, 17 Jun 2024 04:58:41 GMT, Shaojin Wen wrote:
>> The current versions of FloatToDecimal and DoubleToDecimal allocate
>> additional objects. Reducing these allocations can improve the performance
>> of Float/Double.toString and AbstractStringBuilder's append(float/double).
>>
>> This pat
On Sun, 16 Jun 2024 21:25:42 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code format
>
> Just suggesting some improvements
All suggestions have been fixed, can this PR be integrated? @cl4es
On Sun, 16 Jun 2024 21:00:41 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code format
>
> src/java.base/share/classes/jdk/internal/math/ToDecimal.java line 171:
>
>> 169: /* Using the dep
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
On Sun, 16 Jun 2024 23:49:18 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/jdk/internal/math/ToDecimal.java line 169:
>>
>>> 167: }
>>> 168:
>>> 169: /* Using the deprecated constructor enhances performance */
>>
>> Enhances performance over what, `new String(str, 0, index,
>
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
On Sun, 16 Jun 2024 21:02:09 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code format
>
> src/java.base/share/classes/jdk/internal/math/ToDecimal.java line 169:
>
>> 167: }
>> 168:
>> 16
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
On Sat, 15 Jun 2024 13:27:41 GMT, Shaojin Wen wrote:
>> The current versions of FloatToDecimal and DoubleToDecimal allocate
>> additional objects. Reducing these allocations can improve the performance
>> of Float/Double.toString and AbstractStringBuilder's append(float/double).
>>
>> This pat
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
On Sat, 15 Jun 2024 02:45:40 GMT, Chen Liang wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use JLA replace Unsafe
>
> src/java.base/share/classes/jdk/internal/math/ToDecimal.java line 41:
>
>> 39: public sealed c
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is just a code refactoring to reduce object allocation, b
On Sat, 15 Jun 2024 03:02:19 GMT, Chen Liang wrote:
>> The current versions of FloatToDecimal and DoubleToDecimal allocate
>> additional objects. Reducing these allocations can improve the performance
>> of Float/Double.toString and AbstractStringBuilder's append(float/double).
>>
>> This patc
On Sat, 15 Jun 2024 01:59:42 GMT, Shaojin Wen wrote:
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is
On Sat, 15 Jun 2024 01:59:42 GMT, Shaojin Wen wrote:
> The current versions of FloatToDecimal and DoubleToDecimal allocate
> additional objects. Reducing these allocations can improve the performance of
> Float/Double.toString and AbstractStringBuilder's append(float/double).
>
> This patch is
The current versions of FloatToDecimal and DoubleToDecimal allocate additional
objects. Reducing these allocations can improve the performance of
Float/Double.toString and AbstractStringBuilder's append(float/double).
This patch is just a code refactoring to reduce object allocation, but does no
48 matches
Mail list logo
