On Sat, 15 Jun 2024 02:45:40 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> use JLA replace Unsafe > > src/java.base/share/classes/jdk/internal/math/ToDecimal.java line 41: > >> 39: public sealed class ToDecimal permits DoubleToDecimal, FloatToDecimal{ >> 40: static final byte LATIN1 = 0; >> 41: static final byte UTF16 = 1; > > @cl4es All these string latin1 vs utf16 infrastructure are duplicates of > those in StringLatin1 and StringUTF16 in java.lang. Should we move those > String internals to jdk.internal packages so it's more accessible to such > coder-aware special optimizations, like we did with ConstantDesc? I have used JavaLangAccess instead of Usnafe ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19730#discussion_r1640769814