Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc [v4]

2024-04-26 Thread Jin Kwon
On Sat, 27 Apr 2024 01:45:47 GMT, Jaikiran Pai wrote: >> Jin Kwon has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8330686: Fix typos in the DatabaseMetaData javadoc >> >> Reviewed-by: jpai, lancea, iris > > Yes, the PR has been merg

Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc [v4]

2024-04-26 Thread Jaikiran Pai
On Sat, 27 Apr 2024 00:35:26 GMT, Jin Kwon wrote: >> Fix typos within the `DatabaseMetaData.java`. > > Jin Kwon has updated the pull request incrementally with one additional > commit since the last revision: > > 8330686: Fix typos in the DatabaseMetaData javadoc > > Reviewed-by: jpai, l

Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc [v4]

2024-04-26 Thread Jin Kwon
On Sat, 27 Apr 2024 01:09:58 GMT, Jaikiran Pai wrote: >> Jin Kwon has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8330686: Fix typos in the DatabaseMetaData javadoc >> >> Reviewed-by: jpai, lancea, iris > > Hello Jin, once a PR is a

Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc [v4]

2024-04-26 Thread Jaikiran Pai
On Sat, 27 Apr 2024 00:35:26 GMT, Jin Kwon wrote: >> Fix typos within the `DatabaseMetaData.java`. > > Jin Kwon has updated the pull request incrementally with one additional > commit since the last revision: > > 8330686: Fix typos in the DatabaseMetaData javadoc > > Reviewed-by: jpai, l

Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc [v4]

2024-04-26 Thread Jin Kwon
> Fix typos within the `DatabaseMetaData.java`. Jin Kwon has updated the pull request incrementally with one additional commit since the last revision: 8330686: Fix typos in the DatabaseMetaData javadoc Reviewed-by: jpai, lancea, iris - Changes: - all: https://git.openjdk.

Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc [v3]

2024-04-24 Thread Iris Clark
On Wed, 24 Apr 2024 08:54:53 GMT, Jin Kwon wrote: >> Fix typos within the `DatabaseMetaData.java`. > > Jin Kwon has updated the pull request incrementally with one additional > commit since the last revision: > > 8330686: Fix typos in the DatabaseMetaData javadoc > > Reviewed-by: jpai M

Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc [v2]

2024-04-24 Thread Lance Andersen
On Tue, 23 Apr 2024 09:32:40 GMT, Jin Kwon wrote: >> Fix typos within the `DatabaseMetaData.java`. > > Jin Kwon has updated the pull request incrementally with one additional > commit since the last revision: > > [JDK-8330686] Update copyright year Marked as reviewed by lancea (Reviewer). -

Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc [v3]

2024-04-24 Thread Jin Kwon
> Fix typos within the `DatabaseMetaData.java`. Jin Kwon has updated the pull request incrementally with one additional commit since the last revision: 8330686: Fix typos in the DatabaseMetaData javadoc Reviewed-by: jpai - Changes: - all: https://git.openjdk.org/jdk/pull/1

Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc [v2]

2024-04-23 Thread Jaikiran Pai
On Tue, 23 Apr 2024 09:32:40 GMT, Jin Kwon wrote: >> Fix typos within the `DatabaseMetaData.java`. > > Jin Kwon has updated the pull request incrementally with one additional > commit since the last revision: > > [JDK-8330686] Update copyright year Thank you for the update. The changes look

Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc

2024-04-23 Thread Jin Kwon
On Sat, 20 Apr 2024 04:35:05 GMT, Jaikiran Pai wrote: >> @openjdk with issue from where? > > Hello @onacit, it appears a JBS issue has been filed for this > https://bugs.openjdk.org/browse/JDK-8330686. Please change the title of this > PR to `8330686: Fix typos in the DatabaseMetaData javadoc`

Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc [v2]

2024-04-23 Thread Jin Kwon
> Fix typos within the `DatabaseMetaData.java`. Jin Kwon has updated the pull request incrementally with one additional commit since the last revision: [JDK-8330686] Update copyright year - Changes: - all: https://git.openjdk.org/jdk/pull/18860/files - new: https://git.openjd

Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc

2024-04-23 Thread Jaikiran Pai
On Fri, 19 Apr 2024 11:33:48 GMT, Jin Kwon wrote: > Fix typos within the `DatabaseMetaData.java`. These typo fixes look fine to me. Please update the copyright year on the file from `1996, 2022,` to `1996, 2024,` - PR Review: https://git.openjdk.org/jdk/pull/18860#pullrequestrevie

RFR: 8330686: Fix typos in the DatabaseMetaData javadoc

2024-04-20 Thread Jin Kwon
Fix typos within the `DatabaseMetaData.java`. - Commit messages: - Merge branch 'master' of github.com:onacit/jdk - Merge branch 'master' of github.com:onacit/jdk - Fix more typos - Fix typo - Fix wrongly typed constant name - Fix more typos - Fix typo - Fix wrongly typed cons

Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc

2024-04-20 Thread Jaikiran Pai
On Fri, 19 Apr 2024 11:36:48 GMT, Jin Kwon wrote: >> Fix typos within the `DatabaseMetaData.java`. > > @openjdk with issue from where? Hello @onacit, it appears a JBS issue has been filed for this https://bugs.openjdk.org/browse/JDK-8330686. Please change the title of this PR to `8330686: Fix

Re: RFR: 8330686: Fix typos in the DatabaseMetaData javadoc

2024-04-20 Thread Jin Kwon
On Fri, 19 Apr 2024 11:33:48 GMT, Jin Kwon wrote: > Fix typos within the `DatabaseMetaData.java`. @openjdk with issue from where? - PR Comment: https://git.openjdk.org/jdk/pull/18860#issuecomment-2066389888