On Sat, 27 Apr 2024 01:09:58 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Jin Kwon has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8330686: Fix typos in the DatabaseMetaData javadoc >> >> Reviewed-by: jpai, lancea, iris > > Hello Jin, once a PR is approved, unless there are additional review comments > to address, it's a good idea not to update/change the PR. > > In this case, it appears that you only updated the commit message to include > the `Reviewed-By` line. Contributions to the JDK repo these days use bots > which automatically add the `Reviewed-By` line when the PR is actually being > integrated. We used to previously (before migrating to GitHub pull requests) > expect the contributors to add that line themselves, but that's no longer the > case. > > I have reviewed this PR afresh and the change still looks good to me. I'll go > ahead and sponsor this now. @jaikiran Is everything O.K. with this PR? Is it merged? Please help me. Thank you anyway. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18860#issuecomment-2080307272
