On Thu, 30 Nov 2023 17:39:30 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove ensureOpen()
Thanks all for the reviews!
---
On Thu, 30 Nov 2023 17:39:30 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove ensureOpen()
Marked as reviewed by mbaesken (Revi
On Thu, 30 Nov 2023 17:39:30 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove ensureOpen()
Thank you for the update Naoto. The
On Tue, 28 Nov 2023 19:30:34 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> corrected fromIndex
Created an equivalent issue for addr
> It is best practice to zero out the underlying buffer after use.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
remove ensureOpen()
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16861/files
- new: https://git.o
On Thu, 30 Nov 2023 10:58:13 GMT, Jaikiran Pai wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> corrected fromIndex
>
> src/java.base/share/classes/sun/nio/cs/StreamDecoder.java line 293:
>
>> 291:
>> 292: priva
On Thu, 30 Nov 2023 11:10:44 GMT, Jaikiran Pai wrote:
> Given that the default `JdkConsole` provider implementation is the one that
> uses jline (in `jdk.internal.le` module), should we also do something to zero
> out this data in its implementation too. A brief glance suggests that it too
> u
On Tue, 28 Nov 2023 19:30:34 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> corrected fromIndex
Given that the default `JdkConsole`
On Tue, 28 Nov 2023 19:30:34 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> corrected fromIndex
src/java.base/share/classes/sun/nio/
On Tue, 28 Nov 2023 19:27:45 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/sun/nio/cs/StreamDecoder.java line 294:
>>
>>> 292: private void lockedFillZeroToPosition() throws IOException {
>>> 293: ensureOpen();
>>> 294: Arrays.fill(bb.array(), 0, bb.arrayOffset() + bb
On Tue, 28 Nov 2023 19:30:34 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> corrected fromIndex
Marked as reviewed by alanb (Reviewe
On Tue, 28 Nov 2023 19:30:34 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> corrected fromIndex
Marked as reviewed by joehw (Reviewe
On Tue, 28 Nov 2023 19:30:34 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> corrected fromIndex
Marked as reviewed by lancea (Review
On Tue, 28 Nov 2023 19:30:34 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> corrected fromIndex
Looks good now.
-
Mark
On Tue, 28 Nov 2023 19:23:45 GMT, Brian Burkhalter wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> corrected fromIndex
>
> src/java.base/share/classes/sun/nio/cs/StreamDecoder.java line 294:
>
>> 292: private vo
> It is best practice to zero out the underlying buffer after use.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
corrected fromIndex
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16861/files
- new: https://git.o
On Tue, 28 Nov 2023 19:12:50 GMT, Naoto Sato wrote:
> It is best practice to zero out the underlying buffer after use.
src/java.base/share/classes/sun/nio/cs/StreamDecoder.java line 294:
> 292: private void lockedFillZeroToPosition() throws IOException {
> 293: ensureOpen();
> 294:
It is best practice to zero out the underlying buffer after use.
-
Commit messages:
- copyright year
- fill zero to position
- initial commit
Changes: https://git.openjdk.org/jdk/pull/16861/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16861&range=00
Issue: https://bug
18 matches
Mail list logo
