Re: RFR: 8320665: update jdk_core at test/jdk/TEST.groups [v2]

2023-11-28 Thread Alan Bateman
On Tue, 28 Nov 2023 18:26:37 GMT, Ivan Šipka wrote: >> @bwhuang-us @mahendrachhipa > > Ivan Šipka has updated the pull request incrementally with one additional > commit since the last revision: > > added jdk_core_no_security as additional group defintion, reverting old > base definition te

Re: RFR: 8320665: update jdk_core at test/jdk/TEST.groups

2023-11-28 Thread Ivan Šipka
On Mon, 27 Nov 2023 08:03:04 GMT, Alan Bateman wrote: > > > I use the jdk_core test group. I know the split doesn't impact users of > > > this test group but it's not clear why the change is being done. Would it > > > be possible to explain why you are doing this? There is nothing in the > > >

Re: RFR: 8320665: update jdk_core at test/jdk/TEST.groups [v2]

2023-11-28 Thread Ivan Šipka
> @bwhuang-us @mahendrachhipa Ivan Šipka has updated the pull request incrementally with one additional commit since the last revision: added jdk_core_no_security as additional group defintion, reverting old base definition - Changes: - all: https://git.openjdk.org/jdk/pull/16

Re: RFR: 8320665: update jdk_core at test/jdk/TEST.groups

2023-11-27 Thread Alan Bateman
On Fri, 24 Nov 2023 11:28:23 GMT, Ivan Šipka wrote: > > I use the jdk_core test group. I know the split doesn't impact users of > > this test group but it's not clear why the change is being done. Would it > > be possible to explain why you are doing this? There is nothing in the JBS > > issue

Re: RFR: 8320665: update jdk_core at test/jdk/TEST.groups

2023-11-24 Thread Ivan Šipka
On Fri, 24 Nov 2023 07:57:41 GMT, Alan Bateman wrote: > I use the jdk_core test group. I know the split doesn't impact users of this > test group but it's not clear why the change is being done. Would it be > possible to explain why you are doing this? There is nothing in the JBS issue > or PR

Re: RFR: 8320665: update jdk_core at test/jdk/TEST.groups

2023-11-24 Thread Mark Sheppard
On Thu, 23 Nov 2023 14:31:40 GMT, Ivan Šipka wrote: > @bwhuang-us @mahendrachhipa Marked as reviewed by msheppar (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16796#pullrequestreview-1747718538

Re: RFR: 8320665: update jdk_core at test/jdk/TEST.groups

2023-11-24 Thread Alan Bateman
On Thu, 23 Nov 2023 14:31:40 GMT, Ivan Šipka wrote: > @bwhuang-us @mahendrachhipa As a user of the jdk_core test group, would it be possible to explain why you are doing this? There is nothing in the JBS issue or PR to explain. - PR Comment: https://git.openjdk.org/jdk/pull/16796#

RFR: 8320665: update jdk_core at test/jdk/TEST.groups

2023-11-23 Thread Ivan Šipka
@bwhuang-us @mahendrachhipa - Commit messages: - 8320665: update jdk_core at test/jdk/TEST.groups - 8316121: JDK22 ATR tasks job definition updates Changes: https://git.openjdk.org/jdk/pull/16796/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16796&range=00 Issue: https: