Re: RFR: 8316804: Gracefully handle the case where --release is not specified last [v3]

2024-12-20 Thread Alan Bateman
On Fri, 20 Dec 2024 12:18:46 GMT, Christian Stein wrote: >> test/jdk/tools/jar/ReleaseBeforeFiles.java line 26: >> >>> 24: /* >>> 25: * @test >>> 26: * @bug 8167237 8316804 >> >> Have you looked at multiRelease/Basic.java, that might be a better place for >> this. > > Yes, looked at it and t

Re: RFR: 8316804: Gracefully handle the case where --release is not specified last [v3]

2024-12-20 Thread Alan Bateman
On Wed, 18 Dec 2024 15:37:12 GMT, Jaikiran Pai wrote: > @AlanBateman @LanceAndersen do you think this proposal is OK? Right now, the section in the man page for --release $N is when creating a MR JAR. Using --describe-module with --release $N is a useful combination as I might have a module-i

Re: RFR: 8316804: Gracefully handle the case where --release is not specified last [v3]

2024-12-20 Thread Christian Stein
On Fri, 20 Dec 2024 12:13:13 GMT, Alan Bateman wrote: >> Christian Stein has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add two more valid use-cases > > test/jdk/tools/jar/ReleaseBeforeFiles.java line 26: > >> 24: /* >> 25: * @test >>

Re: RFR: 8316804: Gracefully handle the case where --release is not specified last [v3]

2024-12-20 Thread Alan Bateman
On Thu, 12 Dec 2024 07:44:50 GMT, Christian Stein wrote: >> Please review this change for the `jar` tool to gracefully handle the case >> where `--release` is not specified as the last arguments. >> >> Prior to this commit, operation modes `-d --describe-module` and >> `--validate` expected to

Re: RFR: 8316804: Gracefully handle the case where --release is not specified last [v3]

2024-12-18 Thread Jaikiran Pai
On Wed, 18 Dec 2024 15:37:12 GMT, Jaikiran Pai wrote: > Interestingly, neither the help text nor the jar tool specification > https://docs.oracle.com/en/java/javase/23/docs/specs/man/jar.html states > anywhere that the --release option is supported by the --describe-module or > the --validate

Re: RFR: 8316804: Gracefully handle the case where --release is not specified last [v3]

2024-12-18 Thread Jaikiran Pai
On Thu, 12 Dec 2024 07:44:50 GMT, Christian Stein wrote: >> Please review this change for the `jar` tool to gracefully handle the case >> where `--release` is not specified as the last arguments. >> >> Prior to this commit, operation modes `-d --describe-module` and >> `--validate` expected to

Re: RFR: 8316804: Gracefully handle the case where --release is not specified last [v3]

2024-12-18 Thread Jaikiran Pai
On Thu, 12 Dec 2024 07:44:50 GMT, Christian Stein wrote: >> Please review this change for the `jar` tool to gracefully handle the case >> where `--release` is not specified as the last arguments. >> >> Prior to this commit, operation modes `-d --describe-module` and >> `--validate` expected to

Re: RFR: 8316804: Gracefully handle the case where --release is not specified last [v3]

2024-12-18 Thread Jaikiran Pai
On Thu, 12 Dec 2024 07:44:50 GMT, Christian Stein wrote: >> Please review this change for the `jar` tool to gracefully handle the case >> where `--release` is not specified as the last arguments. >> >> Prior to this commit, operation modes `-d --describe-module` and >> `--validate` expected to

Re: RFR: 8316804: Gracefully handle the case where --release is not specified last [v3]

2024-12-18 Thread Jaikiran Pai
On Thu, 12 Dec 2024 07:44:50 GMT, Christian Stein wrote: >> Please review this change for the `jar` tool to gracefully handle the case >> where `--release` is not specified as the last arguments. >> >> Prior to this commit, operation modes `-d --describe-module` and >> `--validate` expected to

Re: RFR: 8316804: Gracefully handle the case where --release is not specified last [v3]

2024-12-18 Thread Jaikiran Pai
On Thu, 12 Dec 2024 07:44:50 GMT, Christian Stein wrote: >> Please review this change for the `jar` tool to gracefully handle the case >> where `--release` is not specified as the last arguments. >> >> Prior to this commit, operation modes `-d --describe-module` and >> `--validate` expected to

Re: RFR: 8316804: Gracefully handle the case where --release is not specified last [v3]

2024-12-11 Thread Christian Stein
> Please review this change for the `jar` tool to gracefully handle the case > where `--release` is not specified as the last arguments. > > Prior to this commit, operation modes `-d --describe-module` and `--validate` > expected to read the optional `--release` option as a file argument: `jar -

Re: RFR: 8316804: Gracefully handle the case where --release is not specified last [v2]

2024-12-06 Thread Jaikiran Pai
On Wed, 13 Nov 2024 16:08:44 GMT, Christian Stein wrote: >> Please review this change for the `jar` tool to gracefully handle the case >> where `--release` is not specified as the last arguments. >> >> Prior to this commit, operation modes `-d --describe-module` and >> `--validate` expected to

Re: RFR: 8316804: Gracefully handle the case where --release is not specified last [v2]

2024-12-04 Thread Jan Lahoda
On Wed, 13 Nov 2024 16:08:44 GMT, Christian Stein wrote: >> Please review this change for the `jar` tool to gracefully handle the case >> where `--release` is not specified as the last arguments. >> >> Prior to this commit, operation modes `-d --describe-module` and >> `--validate` expected to

RFR: 8316804: Gracefully handle the case where --release is not specified last

2024-11-13 Thread Christian Stein
Please review this change for the `jar` tool to gracefully handle the case where `--release` is not specified as the last arguments. Prior to this commit, operation modes `-d --describe-module` and `--validate` expected to read the optional `--release` option as a file argument: `jar -d -f a.ja

Re: RFR: 8316804: Gracefully handle the case where --release is not specified last [v2]

2024-11-13 Thread Henry Jen
On Wed, 13 Nov 2024 16:08:44 GMT, Christian Stein wrote: >> Please review this change for the `jar` tool to gracefully handle the case >> where `--release` is not specified as the last arguments. >> >> Prior to this commit, operation modes `-d --describe-module` and >> `--validate` expected to

Re: RFR: 8316804: Gracefully handle the case where --release is not specified last [v2]

2024-11-13 Thread Christian Stein
> Please review this change for the `jar` tool to gracefully handle the case > where `--release` is not specified as the last arguments. > > Prior to this commit, operation modes `-d --describe-module` and `--validate` > expected to read the optional `--release` option as a file argument: `jar -