> This PR proposes to slightly improve some iterators of `AbstractMap`:
>
> * Declare two fields `final`
> * Use distinct classes rather than anonymous classes
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Remove comment
--
On Fri, 8 Sep 2023 16:13:16 GMT, Per Minborg wrote:
>> This PR proposes to slightly improve some iterators of `AbstractMap`:
>>
>> * Declare two fields `final`
>> * Use distinct classes rather than anonymous classes
>
> Per Minborg has updated the pull request incrementally with two additional
On Fri, 8 Sep 2023 16:13:16 GMT, Per Minborg wrote:
>> This PR proposes to slightly improve some iterators of `AbstractMap`:
>>
>> * Declare two fields `final`
>> * Use distinct classes rather than anonymous classes
>
> Per Minborg has updated the pull request incrementally with two additional
On Fri, 8 Sep 2023 18:55:29 GMT, altrisi wrote:
>> Per Minborg has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Fix additional formating issue
>> - Don't use polymorphism and reformat code
>
> With the recent changes this ends up just
On Fri, 8 Sep 2023 16:13:16 GMT, Per Minborg wrote:
>> This PR proposes to slightly improve some iterators of `AbstractMap`:
>>
>> * Code reuse
>> * A field declared `final`
>> * Add missing `@Override` annotations
>
> Per Minborg has updated the pull request incrementally with two additional
>
> This PR proposes to slightly improve some iterators of `AbstractMap`:
>
> * Code reuse
> * A field declared `final`
> * Add missing `@Override` annotations
Per Minborg has updated the pull request incrementally with two additional
commits since the last revision:
- Fix additional formating i
On Thu, 7 Sep 2023 18:05:51 GMT, Stuart Marks wrote:
>> Hello,
>> In Java, sharing code may have a runtime cost (or not) depending on the
>> shape of the code, because the VM may have to speculate on the class of some
>> value at runtime.
>> Here, in hasNext() and remove(), the VM has to find t
On Thu, 7 Sep 2023 12:24:58 GMT, Rémi Forax wrote:
>> This PR proposes to slightly improve some iterators of `AbstractMap`:
>>
>> * Code reuse
>> * A field declared `final`
>> * Add missing `@Override` annotations
>
> Hello,
> In Java, sharing code may have a runtime cost (or not) depending on t
On Thu, 7 Sep 2023 17:23:20 GMT, Per Minborg wrote:
>> This PR proposes to slightly improve some iterators of `AbstractMap`:
>>
>> * Code reuse
>> * A field declared `final`
>> * Add missing `@Override` annotations
>
> Per Minborg has updated the pull request incrementally with one additional
>
> This PR proposes to slightly improve some iterators of `AbstractMap`:
>
> * Code reuse
> * A field declared `final`
> * Add missing `@Override` annotations
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Remove @Override annotations
On Thu, 7 Sep 2023 11:48:51 GMT, Per Minborg wrote:
> This PR proposes to slightly improve some iterators of `AbstractMap`:
>
> * Code reuse
> * A field declared `final`
> * Add missing `@Override` annotations
Hello,
In Java, sharing code may have a runtime cost (or not) depending on the shape
This PR proposes to slightly improve some iterators of `AbstractMap`:
* Code reuse
* A field declared `final`
* Add missing `@Override` annotations
-
Commit messages:
- Improve AbstractMap anonymous Iterator classes
Changes: https://git.openjdk.org/jdk/pull/15615/files
Webrev: htt
12 matches
Mail list logo