Re: RFR: 8315532: Compiler Implementation for Unnamed Variables and Patterns [v7]

2023-10-18 Thread Aggelos Biboudis
> This PR finalizes the feature of unnamed variables and patterns. Aggelos Biboudis has updated the pull request incrementally with one additional commit since the last revision: Remove preview lines from a new .out file - Changes: - all: https://git.openjdk.org/jdk/pull/15649/

Re: RFR: 8315532: Compiler Implementation for Unnamed Variables and Patterns [v6]

2023-10-17 Thread Aggelos Biboudis
> This PR finalizes the feature of unnamed variables and patterns. Aggelos Biboudis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional co

Re: RFR: 8315532: Compiler Implementation for Unnamed Variables and Patterns [v5]

2023-10-16 Thread Aggelos Biboudis
> This PR finalizes the feature of unnamed variables and patterns. Aggelos Biboudis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional comm

Re: RFR: 8315532: Compiler Implementation for Unnamed Variables and Patterns [v4]

2023-10-11 Thread Aggelos Biboudis
> This PR finalizes the feature of unnamed variables and patterns. Aggelos Biboudis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional com

Re: RFR: 8315532: Compiler Implementation for Unnamed Variables and Patterns [v3]

2023-09-28 Thread Maurizio Cimadamore
On Thu, 28 Sep 2023 08:38:27 GMT, Aggelos Biboudis wrote: >> I agree. Also, this is not helped by the fact that in this particular >> message, the `_` does not appear in a variable declaration. Maybe we should >> use two distinct messages for when `_` is found as an "expression" (e.g. an >> i

Re: RFR: 8315532: Compiler Implementation for Unnamed Variables and Patterns [v3]

2023-09-28 Thread Maurizio Cimadamore
On Thu, 28 Sep 2023 08:40:20 GMT, Aggelos Biboudis wrote: >> This PR finalizes the feature of unnamed variables and patterns. >> >> - >> ### Progress >> - [ ] Change must be properly reviewed (1 review required, with at least 1 >> [Reviewer](https://openjdk.org/bylaws#reviewer)) >> - [

Re: RFR: 8315532: Compiler Implementation for Unnamed Variables and Patterns [v3]

2023-09-28 Thread Aggelos Biboudis
On Tue, 26 Sep 2023 10:21:06 GMT, Maurizio Cimadamore wrote: >> test/langtools/tools/javac/lambda/IdentifierTest9.out line 33: >> >>> 31: IdentifierTest.java:152:17: compiler.err.use.of.underscore.not.allowed >>> 32: IdentifierTest.java:158:16: >>> compiler.err.use.of.underscore.not.allowed.wi

Re: RFR: 8315532: Compiler Implementation for Unnamed Variables and Patterns [v3]

2023-09-28 Thread Aggelos Biboudis
> This PR finalizes the feature of unnamed variables and patterns. > > - > ### Progress > - [ ] Change must be properly reviewed (1 review required, with at least 1 > [Reviewer](https://openjdk.org/bylaws#reviewer)) > - [x] Change must not contain extraneous whitespace > - [x] Commit mess

Re: RFR: 8315532: Compiler Implementation for Unnamed Variables and Patterns [v2]

2023-09-26 Thread Aggelos Biboudis
> This PR finalizes the feature of unnamed variables and patterns. > > - > ### Progress > - [ ] Change must be properly reviewed (1 review required, with at least 1 > [Reviewer](https://openjdk.org/bylaws#reviewer)) > - [x] Change must not contain extraneous whitespace > - [x] Commit mess

Re: RFR: 8315532: Compiler Implementation for Unnamed Variables and Patterns [v2]

2023-09-26 Thread Aggelos Biboudis
On Mon, 25 Sep 2023 17:05:49 GMT, Jan Lahoda wrote: >> Aggelos Biboudis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review by @lahodaj > > test/langtools/tools/javac/diags/examples/UnderscoreInLambdaExpression.java > line 24

Re: RFR: 8315532: Compiler Implementation for Unnamed Variables and Patterns

2023-09-26 Thread Maurizio Cimadamore
On Mon, 25 Sep 2023 16:59:30 GMT, Jan Lahoda wrote: >> This PR finalizes the feature of unnamed variables and patterns. >> >> - >> ### Progress >> - [ ] Change must be properly reviewed (1 review required, with at least 1 >> [Reviewer](https://openjdk.org/bylaws#reviewer)) >> - [x] Chan

Re: RFR: 8315532: Compiler Implementation for Unnamed Variables and Patterns

2023-09-25 Thread Jan Lahoda
On Sat, 9 Sep 2023 00:02:20 GMT, Aggelos Biboudis wrote: > This PR finalizes the feature of unnamed variables and patterns. > > - > ### Progress > - [ ] Change must be properly reviewed (1 review required, with at least 1 > [Reviewer](https://openjdk.org/bylaws#reviewer)) > - [x] Chang

RFR: 8315532: Compiler Implementation for Unnamed Variables and Patterns

2023-09-25 Thread Aggelos Biboudis
8315532: Compiler Implementation for Unnamed Variables and Patterns - Commit messages: - 8315532: Compiler Implementation for Unnamed Variables and Patterns Changes: https://git.openjdk.org/jdk/pull/15649/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15649&range=00 Issue