Re: RFR: 8311968: Clarify Three-letter time zone IDs in java.util.TimeZone [v4]

2023-07-14 Thread Lance Andersen
On Thu, 13 Jul 2023 22:43:27 GMT, Justin Lu wrote: >> Please review this PR and associated >> [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list >> of deprecated three-letter IDs in java.util.TimeZone >> >> Although it is made apparent in TimeZone that certain 3-lette

Re: RFR: 8311968: Clarify Three-letter time zone IDs in java.util.TimeZone [v4]

2023-07-14 Thread Naoto Sato
On Thu, 13 Jul 2023 22:43:27 GMT, Justin Lu wrote: >> Please review this PR and associated >> [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list >> of deprecated three-letter IDs in java.util.TimeZone >> >> Although it is made apparent in TimeZone that certain 3-lette

Re: RFR: 8311968: Clarify Three-letter time zone IDs in java.util.TimeZone [v4]

2023-07-13 Thread Justin Lu
> Please review this PR and associated > [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list > of deprecated three-letter IDs in java.util.TimeZone > > Although it is made apparent in TimeZone that certain 3-letter IDs are > deprecated, it does not actually list them in

Re: RFR: 8311968: Clarify Three-letter time zone IDs in java.util.TimeZone [v2]

2023-07-13 Thread Justin Lu
On Thu, 13 Jul 2023 20:21:57 GMT, Justin Lu wrote: >> src/java.base/share/classes/java/util/TimeZone.java line 135: >> >>> 133: * recognize one of them. The full list of the deprecated IDs and >>> their mappings >>> 134: * can be viewed at {@link java.time.ZoneId#SHORT_IDS}. It should be >>>

Re: RFR: 8311968: Clarify Three-letter time zone IDs in java.util.TimeZone [v2]

2023-07-13 Thread Justin Lu
On Thu, 13 Jul 2023 19:38:35 GMT, Lance Andersen wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review: update wording to include mappings > > src/java.base/share/classes/java/util/TimeZone.java line 135: > >> 133:

Re: RFR: 8311968: Clarify Three-letter time zone IDs in java.util.TimeZone [v3]

2023-07-13 Thread Justin Lu
> Please review this PR and associated > [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list > of deprecated three-letter IDs in java.util.TimeZone > > Although it is made apparent in TimeZone that certain 3-letter IDs are > deprecated, it does not actually list them in

Re: RFR: 8311968: Clarify Three-letter time zone IDs in java.util.TimeZone [v2]

2023-07-13 Thread Lance Andersen
On Thu, 13 Jul 2023 18:41:47 GMT, Justin Lu wrote: >> Please review this PR and associated >> [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list >> of deprecated three-letter IDs in java.util.TimeZone >> >> Although it is made apparent in TimeZone that certain 3-lette

Re: RFR: 8311968: Clarify Three-letter time zone IDs in java.util.TimeZone [v2]

2023-07-13 Thread Naoto Sato
On Thu, 13 Jul 2023 18:41:47 GMT, Justin Lu wrote: >> Please review this PR and associated >> [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list >> of deprecated three-letter IDs in java.util.TimeZone >> >> Although it is made apparent in TimeZone that certain 3-lette

Re: RFR: 8311968: Clarify Three-letter time zone IDs in java.util.TimeZone [v2]

2023-07-13 Thread Justin Lu
> Please review this PR and associated > [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list > of deprecated three-letter IDs in java.util.TimeZone > > Although it is made apparent in TimeZone that certain 3-letter IDs are > deprecated, it does not actually list them in

Re: RFR: 8311968: Clarify Three-letter time zone IDs in java.util.TimeZone [v2]

2023-07-13 Thread Justin Lu
On Thu, 13 Jul 2023 18:29:05 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review: update wording to include mappings > > src/java.base/share/classes/java/util/TimeZone.java line 133: > >> 131: * f

Re: RFR: 8311968: Clarify Three-letter time zone IDs in java.util.TimeZone

2023-07-13 Thread Naoto Sato
On Thu, 13 Jul 2023 06:34:09 GMT, Justin Lu wrote: > Please review this PR and associated > [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list > of deprecated three-letter IDs in java.util.TimeZone > > Although it is made apparent in TimeZone that certain 3-letter IDs

RFR: 8311968: Clarify Three-letter time zone IDs in java.util.TimeZone

2023-07-12 Thread Justin Lu
Please review this PR and associated [CSR](https://bugs.openjdk.org/browse/JDK-8311979) which links the full list of deprecated three-letter IDs in java.util.TimeZone Although it is made apparent in TimeZone that certain 3-letter IDs are deprecated, it does not actually list them in the specifi