On Wed, 22 Nov 2023 08:58:41 GMT, Alan Bateman wrote:
> I'm happy with the addition of the JDK built-in catalog, the inclusion of the
> DTD defined by Java SE, and the docs updates.
Thanks again, Alan, I really appreciate it! Finally got all pieces together, a
nice foundation for the next.
--
> Implement the built-in Catalog.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
fix whitespace
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16719/files
- new: https://git.openjdk.org/jdk/pull/16719/files/4914278a
On Wed, 22 Nov 2023 08:08:39 GMT, Andrey Turbanov wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add a note; fix alignment
>
> test/jaxp/javax/xml/jaxp/unittest/common/catalog/CatalogTestBase.java line
> 299:
>
>> 2
On Mon, 20 Nov 2023 17:46:53 GMT, Joe Wang wrote:
>> Implement the built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add a note; fix alignment
I'm happy with the addition of the JDK built-in catalog, the inclus
On Mon, 20 Nov 2023 17:46:53 GMT, Joe Wang wrote:
>> Implement the built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add a note; fix alignment
src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/
On Mon, 20 Nov 2023 17:46:53 GMT, Joe Wang wrote:
>> Implement the built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add a note; fix alignment
Thank you Joe.
All good by me and Congrats on moving this across t
On Mon, 20 Nov 2023 16:48:51 GMT, Lance Andersen wrote:
> Hi Joe,
>
> Thank you for all of your hard work and perseverance to drive this project as
> I realize it was a lot of work and iterations based on feedback from the team.
>
> Overall looks good. A couple of minor comments below
Thanks
> Implement the built-in Catalog.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
add a note; fix alignment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16719/files
- new: https://git.openjdk.org/jdk/pull/16719/fil
On Mon, 20 Nov 2023 16:38:54 GMT, Magnus Ihse Bursie wrote:
> Build change trivially okay
Thanks Magnus!
-
PR Comment: https://git.openjdk.org/jdk/pull/16719#issuecomment-1819529895
On Sun, 19 Nov 2023 23:36:16 GMT, Joe Wang wrote:
>> Implement the built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove J2SE directory; add note explaining how DTDs are resolved
Hi Joe,
Thank you for all o
On Sun, 19 Nov 2023 23:36:16 GMT, Joe Wang wrote:
>> Implement the built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove J2SE directory; add note explaining how DTDs are resolved
Build change trivially okay
On Sun, 19 Nov 2023 23:36:16 GMT, Joe Wang wrote:
>> Implement the built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove J2SE directory; add note explaining how DTDs are resolved
Tests: Tier 1-3 and JCK pass
On Sun, 19 Nov 2023 08:46:30 GMT, Alan Bateman wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove J2SE directory; add note explaining how DTDs are resolved
>
> src/java.xml/share/classes/module-info.java line 910:
On Sun, 19 Nov 2023 08:45:29 GMT, Alan Bateman wrote:
>> src/java.xml/share/classes/jdk/xml/internal/jdkcatalog/JDKCatalog.xml line
>> 34:
>>
>>> 32:
>>> 33: http://java.sun.com/dtd/preferences.dtd";
>>> uri="J2SE/preferences.dtd"/>
>>> 34: http://java.sun.com/dtd/properti
> Implement the built-in Catalog.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
remove J2SE directory; add note explaining how DTDs are resolved
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16719/files
- new: htt
On Sun, 19 Nov 2023 08:44:01 GMT, Alan Bateman wrote:
>> Implement the built-in Catalog.
>
> src/java.xml/share/classes/jdk/xml/internal/jdkcatalog/JDKCatalog.xml line 34:
>
>> 32:
>> 33: http://java.sun.com/dtd/preferences.dtd";
>> uri="J2SE/preferences.dtd"/>
>> 34: http:
On Fri, 17 Nov 2023 20:22:40 GMT, Joe Wang wrote:
> Implement the built-in Catalog.
src/java.xml/share/classes/jdk/xml/internal/jdkcatalog/JDKCatalog.xml line 34:
> 32:
> 33: http://java.sun.com/dtd/preferences.dtd";
> uri="J2SE/preferences.dtd"/>
> 34: http://java.sun.com
Implement the built-in Catalog.
-
Commit messages:
- fix whitespace error
- 8306055: Add a built-in Catalog to JDK XML module
Changes: https://git.openjdk.org/jdk/pull/16719/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16719&range=00
Issue: https://bugs.openjdk.org/bro
18 matches
Mail list logo
