On Fri, 17 Nov 2023 20:22:40 GMT, Joe Wang <jo...@openjdk.org> wrote:
> Implement the built-in Catalog. src/java.xml/share/classes/jdk/xml/internal/jdkcatalog/JDKCatalog.xml line 34: > 32: <group id="javadtds" prefer = "system" xml:base = "java/dtd/"> > 33: <system systemId="http://java.sun.com/dtd/preferences.dtd"; > uri="J2SE/preferences.dtd"/> > 34: <system systemId="http://java.sun.com/dtd/properties.dtd"; > uri="J2SE/properties.dtd"/> Would it be possible to provide a summary on how the relative uri in the "uri" attribute is handled? Asking as it's not clear to me how the decoding is handling, meaning this is a relative URI, not a relative file path. src/java.xml/share/classes/module-info.java line 910: > 908: * <td style="text-align:center"><a href="#Processor">Method 1</a></td> > 909: * <td style="text-align:center">22</td> > 910: * </tr> I went through a number of iterations with Joe on this implNote so happy with this version. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16719#discussion_r1398355355 PR Review Comment: https://git.openjdk.org/jdk/pull/16719#discussion_r1398355680
