Re: RFR: 8304450: [vectorapi] Refactor VectorShuffle implementation [v4]

2023-03-23 Thread Xiaohong Gong
On Wed, 22 Mar 2023 12:46:33 GMT, Quan Anh Mai wrote: >> Hi, >> >> This patch reimplements `VectorShuffle` implementations to be a vector of >> the bit type. Currently, VectorShuffle is stored as a byte array, and would >> be expanded upon usage. This poses several drawbacks: >> >> 1. Ineffic

Re: RFR: 8304450: [vectorapi] Refactor VectorShuffle implementation [v4]

2023-03-22 Thread Xiaohong Gong
On Wed, 22 Mar 2023 12:42:15 GMT, Quan Anh Mai wrote: >> src/hotspot/share/opto/vectorIntrinsics.cpp line 2059: >> >>> 2057: if (need_load_shuffle) { >>> 2058: shuffle = gvn().transform(new VectorLoadShuffleNode(shuffle, vt)); >>> 2059: } >> >> How about generating `VectorLoadShuffleNod

Re: RFR: 8304450: [vectorapi] Refactor VectorShuffle implementation [v4]

2023-03-22 Thread Xiaohong Gong
On Wed, 22 Mar 2023 12:39:27 GMT, Quan Anh Mai wrote: >> src/hotspot/share/opto/vectorIntrinsics.cpp line 2426: >> >>> 2424: if (is_vector_shuffle(vbox_klass_from)) { >>> 2425: return false; // vector shuffles aren't supported >>> 2426: } >> >> Is it better to change this as an "asserti

Re: RFR: 8304450: [vectorapi] Refactor VectorShuffle implementation [v4]

2023-03-22 Thread Quan Anh Mai
On Wed, 22 Mar 2023 07:59:40 GMT, Xiaohong Gong wrote: >> Quan Anh Mai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reviews > > src/hotspot/share/opto/vectorIntrinsics.cpp line 2059: > >> 2057: if (need_load_shuffle) { >> 2058:

Re: RFR: 8304450: [vectorapi] Refactor VectorShuffle implementation [v4]

2023-03-22 Thread Quan Anh Mai
> Hi, > > This patch reimplements `VectorShuffle` implementations to be a vector of the > bit type. Currently, VectorShuffle is stored as a byte array, and would be > expanded upon usage. This poses several drawbacks: > > 1. Inefficient conversions between a shuffle and its corresponding vector