Re: RFR: 8303891: Speed up Zip64SizeTest using a small ZIP64 file [v5]

2024-02-12 Thread Jaikiran Pai
On Fri, 9 Feb 2024 10:41:18 GMT, Eirik Bjørsnøs wrote: >> test/jdk/java/util/zip/ZipFile/Zip64SizeTest.java line 112: >> >>> 110: ZipEntry e1 = new ZipEntry("first"); >>> 111: // Make room for an 8-byte ZIP64 extra field >>> 112: e1.setExtra(createOpaqueExtra(

Re: RFR: 8303891: Speed up Zip64SizeTest using a small ZIP64 file [v5]

2024-02-09 Thread Eirik Bjørsnøs
On Fri, 9 Feb 2024 06:39:31 GMT, Jaikiran Pai wrote: >> Eirik Bjørsnøs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 13 additional >> commits

Re: RFR: 8303891: Speed up Zip64SizeTest using a small ZIP64 file [v5]

2024-02-08 Thread Jaikiran Pai
On Thu, 8 Feb 2024 14:09:35 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which suggests we speed up the `Zip64SizeTest` using a >> small-sized ZIP64 ZIP file specifically created to reproduce the issue being >> tested. >> >> The disk space requirement of this test is known to cause prob

Re: RFR: 8303891: Speed up Zip64SizeTest using a small ZIP64 file [v5]

2024-02-08 Thread Jaikiran Pai
On Thu, 8 Feb 2024 14:09:35 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which suggests we speed up the `Zip64SizeTest` using a >> small-sized ZIP64 ZIP file specifically created to reproduce the issue being >> tested. >> >> The disk space requirement of this test is known to cause prob

Re: RFR: 8303891: Speed up Zip64SizeTest using a small ZIP64 file [v5]

2024-02-08 Thread Eirik Bjørsnøs
On Thu, 8 Feb 2024 14:09:35 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which suggests we speed up the `Zip64SizeTest` using a >> small-sized ZIP64 ZIP file specifically created to reproduce the issue being >> tested. >> >> The disk space requirement of this test is known to cause prob

Re: RFR: 8303891: Speed up Zip64SizeTest using a small ZIP64 file [v5]

2024-02-08 Thread Eirik Bjørsnøs
> Please review this PR which suggests we speed up the `Zip64SizeTest` using a > small-sized ZIP64 ZIP file specifically created to reproduce the issue being > tested. > > The disk space requirement of this test is known to cause problems in some > builds, see [JDK-8259866](https://bugs.openjdk