> Please review this PR which suggests we speed up the `Zip64SizeTest` using a > small-sized ZIP64 ZIP file specifically created to reproduce the issue being > tested. > > The disk space requirement of this test is known to cause problems in some > builds, see [JDK-8259866](https://bugs.openjdk.org/browse/JDK-8259866) > > By using a sparse file, we reduce consumed disk space from 5GB to 266 bytes > and also reduce the runtime from ~35 seconds to ~1 seconds on my Macbook Pro. > > The PR also fixes the `@summary` tag, which seems to have been copied from an > unrelated test.
Eirik Bjørsnøs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision: - Use a small ZIP64 file to reproduce the issue. Convert test to JUnit - Update copyright year for 2024 - Use ENTRY instead of FILE when refering to names and sizes of file entries in the ZIP file - Merge branch 'master' into zip64-size-test-sparse - Merge branch 'master' into zip64-size-test-sparse - Sparse files must be created explicitly on NTFS - Merge branch 'master' into zip64-size-test-sparse - Merge branch 'master' into zip64-size-test-sparse - Make test method public - Add a missing "when" in Javadocs for SparseOutputStream - ... and 3 more: https://git.openjdk.org/jdk/compare/ae023a61...41b2ba5e ------------- Changes: - all: https://git.openjdk.org/jdk/pull/12948/files - new: https://git.openjdk.org/jdk/pull/12948/files/adcca52c..41b2ba5e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=12948&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12948&range=03-04 Stats: 1546371 lines in 16853 files changed: 754316 ins; 616810 del; 175245 mod Patch: https://git.openjdk.org/jdk/pull/12948.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/12948/head:pull/12948 PR: https://git.openjdk.org/jdk/pull/12948
