Re: RFR: 8302815 Use new Math.clamp method in core libraries [v3]

2023-02-22 Thread Pavel Rappo
On Tue, 21 Feb 2023 20:39:53 GMT, Tagir F. Valeev wrote: >> For cleanup and dogfooding the new method, it would be nice to use >> Math.clamp where possible in java.base. See PR #12428. >> >> As Math.clamp performs an additional check that min is not greater than max, >> I conservatively replac

Re: RFR: 8302815 Use new Math.clamp method in core libraries [v3]

2023-02-22 Thread Pavel Rappo
On Tue, 21 Feb 2023 20:39:53 GMT, Tagir F. Valeev wrote: >> For cleanup and dogfooding the new method, it would be nice to use >> Math.clamp where possible in java.base. See PR #12428. >> >> As Math.clamp performs an additional check that min is not greater than max, >> I conservatively replac

Re: RFR: 8302815 Use new Math.clamp method in core libraries [v2]

2023-02-21 Thread Tagir F . Valeev
On Sun, 19 Feb 2023 08:54:56 GMT, Alan Bateman wrote: >> Tagir F. Valeev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert changes in JrtPath, as it seems to be compiled with bootstrap JDK > >> Revert changes in JrtPath, as it seems

Re: RFR: 8302815 Use new Math.clamp method in core libraries [v3]

2023-02-21 Thread Tagir F . Valeev
> For cleanup and dogfooding the new method, it would be nice to use Math.clamp > where possible in java.base. See PR #12428. > > As Math.clamp performs an additional check that min is not greater than max, > I conservatively replaced only those occurrences where I can see that this > invariant

Re: RFR: 8302815 Use new Math.clamp method in core libraries [v2]

2023-02-20 Thread Alan Bateman
On Sat, 18 Feb 2023 21:40:08 GMT, Tagir F. Valeev wrote: >> For cleanup and dogfooding the new method, it would be nice to use >> Math.clamp where possible in java.base. See PR #12428. >> >> As Math.clamp performs an additional check that min is not greater than max, >> I conservatively replac

Re: RFR: 8302815 Use new Math.clamp method in core libraries [v2]

2023-02-19 Thread Alan Bateman
On Sat, 18 Feb 2023 21:40:08 GMT, Tagir F. Valeev wrote: > Revert changes in JrtPath, as it seems to be compiled with bootstrap JDK Yes, the jrt file system provider is compiled --release 8 to create lib/jrt-fs.jar. That's the plumbing needed to allow IDEs/tools running on JDK 8 access the con

Re: RFR: 8302815 Use new Math.clamp method in core libraries [v2]

2023-02-18 Thread Tagir F . Valeev
> For cleanup and dogfooding the new method, it would be nice to use Math.clamp > where possible in java.base. See PR #12428. > > As Math.clamp performs an additional check that min is not greater than max, > I conservatively replaced only those occurrences where I can see that this > invariant

RFR: 8302815 Use new Math.clamp method in core libraries

2023-02-18 Thread Tagir F . Valeev
For cleanup and dogfooding the new method, it would be nice to use Math.clamp where possible in java.base. See PR #12428. As Math.clamp performs an additional check that min is not greater than max, I conservatively replaced only those occurrences where I can see that this invariant is always h