> For cleanup and dogfooding the new method, it would be nice to use Math.clamp 
> where possible in java.base. See PR #12428.
> 
> As Math.clamp performs an additional check that min is not greater than max, 
> I conservatively replaced only those occurrences where I can see that this 
> invariant is always held. There are more occurrences, where clamp can be 
> potentially used but it's unclear whether min <= max is always true.

Tagir F. Valeev has updated the pull request incrementally with one additional 
commit since the last revision:

  Revert changes in JrtPath, as it seems to be compiled with bootstrap JDK

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12633/files
  - new: https://git.openjdk.org/jdk/pull/12633/files/3f3618ae..be13683b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12633&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12633&range=00-01

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/12633.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12633/head:pull/12633

PR: https://git.openjdk.org/jdk/pull/12633

Reply via email to