Re: RFR: 8298619: java/io/File/GetXSpace.java is failing [v4]

2023-09-05 Thread Brian Burkhalter
The changes to this test were developed on a native Windows 11 machine. I have never seen this problem. A web search suggests that this is a Windows error message possibly due to drive error. On Sep 4, 2023, at 5:16 AM, Andrey Turbanov mailto:aturba...@openjdk.org>> wrote: It seems after refa

Re: RFR: 8298619: java/io/File/GetXSpace.java is failing [v4]

2023-09-04 Thread Andrey Turbanov
On Wed, 29 Mar 2023 18:05:46 GMT, Brian Burkhalter wrote: >> Modify the `Space` instances used for size comparison to be created with >> total number of bytes derived from the Windows `diskFree` utility instead of >> Cygwin’s `df`. > > Brian Burkhalter has updated the pull request incrementally

Re: RFR: 8298619: java/io/File/GetXSpace.java is failing [v4]

2023-04-03 Thread Roger Riggs
On Wed, 29 Mar 2023 18:05:46 GMT, Brian Burkhalter wrote: >> Modify the `Space` instances used for size comparison to be created with >> total number of bytes derived from the Windows `diskFree` utility instead of >> Cygwin’s `df`. > > Brian Burkhalter has updated the pull request incrementally

Re: RFR: 8298619: java/io/File/GetXSpace.java is failing [v3]

2023-04-03 Thread Brian Burkhalter
On Wed, 29 Mar 2023 16:10:34 GMT, Roger Riggs wrote: >> Brian Burkhalter has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> comm

Re: RFR: 8298619: java/io/File/GetXSpace.java is failing [v4]

2023-04-03 Thread Brian Burkhalter
On Tue, 28 Feb 2023 21:26:55 GMT, Brian Burkhalter wrote: >> Spawning `df` and `diskFree` processes have been replaced with native calls. >> For a reason as yet undetermined, the Windows function >> `GetDiskSpaceInformationW` fails to load on Windows Server 2016 so it is >> loaded dynamically

Re: RFR: 8298619: java/io/File/GetXSpace.java is failing [v4]

2023-03-29 Thread Brian Burkhalter
> Modify the `Space` instances used for size comparison to be created with > total number of bytes derived from the Windows `diskFree` utility instead of > Cygwin’s `df`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8305157:

Re: RFR: 8298619: java/io/File/GetXSpace.java is failing [v3]

2023-03-29 Thread Roger Riggs
On Mon, 27 Feb 2023 22:05:20 GMT, Brian Burkhalter wrote: >> Modify the `Space` instances used for size comparison to be created with >> total number of bytes derived from the Windows `diskFree` utility instead of >> Cygwin’s `df`. > > Brian Burkhalter has updated the pull request with a new ta

Re: RFR: 8298619: java/io/File/GetXSpace.java is failing [v3]

2023-03-29 Thread Brian Burkhalter
On Mon, 27 Feb 2023 22:05:20 GMT, Brian Burkhalter wrote: >> Modify the `Space` instances used for size comparison to be created with >> total number of bytes derived from the Windows `diskFree` utility instead of >> Cygwin’s `df`. > > Brian Burkhalter has updated the pull request with a new ta

Re: RFR: 8298619: java/io/File/GetXSpace.java is failing [v3]

2023-02-28 Thread Brian Burkhalter
On Wed, 22 Feb 2023 18:26:49 GMT, Brian Burkhalter wrote: >> There has definitely been a problem with quotas on Windows. I set up quotas >> on actual Windows 11 hardware and replicated the same failure. I am not sure >> how much lack of system quiescence is to blame, but there would be no harm

Re: RFR: 8298619: java/io/File/GetXSpace.java is failing [v3]

2023-02-27 Thread Brian Burkhalter
> Modify the `Space` instances used for size comparison to be created with > total number of bytes derived from the Windows `diskFree` utility instead of > Cygwin’s `df`. Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excl

Re: RFR: 8298619: java/io/File/GetXSpace.java is failing [v2]

2023-02-22 Thread Brian Burkhalter
On Tue, 14 Feb 2023 16:31:48 GMT, Brian Burkhalter wrote: >>> Another possibility would be to add a native method to the test itself to >>> invoke >>> [GetDiskSpaceInformationW](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getdiskspaceinformationw) >>> to obtain the v

Re: RFR: 8298619: java/io/File/GetXSpace.java is failing [v2]

2023-02-22 Thread Brian Burkhalter
> Modify the `Space` instances used for size comparison to be created with > total number of bytes derived from the Windows `diskFree` utility instead of > Cygwin’s `df`. Brian Burkhalter has updated the pull request incrementally with two additional commits since the last revision: - 8298619

Re: RFR: 8298619: java/io/File/GetXSpace.java is failing

2023-02-14 Thread Brian Burkhalter
On Sun, 12 Feb 2023 09:34:37 GMT, Alan Bateman wrote: >>> It seems a bit fragile to be parsing the output of `fsutil volume diskFree` >>> as the output seems to vary by Windows releases and maybe configuration. So >>> minimally, I think it should be changed to use ProcessTools so that the >>>

Re: RFR: 8298619: java/io/File/GetXSpace.java is failing

2023-02-12 Thread Alan Bateman
On Fri, 10 Feb 2023 17:10:46 GMT, Brian Burkhalter wrote: > Another possibility would be to add a native method to the test itself to > invoke > [GetDiskSpaceInformationW](https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getdiskspaceinformationw) > to obtain the value of

Re: RFR: 8298619: java/io/File/GetXSpace.java is failing

2023-02-10 Thread Brian Burkhalter
On Fri, 10 Feb 2023 13:51:24 GMT, Alan Bateman wrote: > It seems a bit fragile to be parsing the output of `fsutil volume diskFree` > as the output seems to vary by Windows releases and maybe configuration. So > minimally, I think it should be changed to use ProcessTools so that the > command

Re: RFR: 8298619: java/io/File/GetXSpace.java is failing

2023-02-10 Thread Alan Bateman
On Fri, 3 Feb 2023 02:02:39 GMT, Brian Burkhalter wrote: > Modify the `Space` instances used for size comparison to be created with > total number of bytes derived from the Windows `diskFree` utility instead of > Cygwin’s `df`. test/jdk/java/io/File/GetXSpace.java line 152: > 150: } > 151

Re: RFR: 8298619: java/io/File/GetXSpace.java is failing

2023-02-02 Thread Brian Burkhalter
On Fri, 3 Feb 2023 02:02:39 GMT, Brian Burkhalter wrote: > Modify the `Space` instances used for size comparison to be created with > total number of bytes derived from the Windows `diskFree` utility instead of > Cygwin’s `df`. With reference to the Windows `DISK_SPACE_INFORMATION` structure,

RFR: 8298619: java/io/File/GetXSpace.java is failing

2023-02-02 Thread Brian Burkhalter
Modify the `Space` instances used for size comparison to be created with total number of bytes derived from the Windows `diskFree` utility instead of Cygwin’s `df`. - Commit messages: - 8298619: java/io/File/GetXSpace.java is failing Changes: https://git.openjdk.org/jdk/pull/12397