On Fri, 3 Feb 2023 02:02:39 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
> Modify the `Space` instances used for size comparison to be created with > total number of bytes derived from the Windows `diskFree` utility instead of > Cygwin’s `df`. With reference to the Windows `DISK_SPACE_INFORMATION` structure, the `File` methods `getTotalSpace`, `getFreeSpace`, and `getUsableSpace` return the number of bytes implied by `CallerTotalAllocationUnits`, `ActualAvailableAllocationUnits`, and `CallerAvailableAllocationUnits`, respectively. The total and usable values reflect any quota imposed on the user. Currently the reference values against which these space values are compared are derived from the Cygwin `df` command. The total number of bytes given by `df` corresponds to `ActualTotalAllocationUnits` and does not account for quotas. Hence it is not appropriate as a reference when quotas are imposed. The total number of bytes indicated by the output of the Windows `diskFree` utility is however equivalent to `CallerTotalAllocationUnits` hence is the correct reference. With this change the test passes on all platforms, include 110 repeats on Windows. ------------- PR: https://git.openjdk.org/jdk/pull/12397
