Re: RFR: 8295000: java/util/Formatter/Basic test cleanup [v2]

2022-10-27 Thread Justin Lu
On Thu, 27 Oct 2022 17:13:23 GMT, Lance Andersen wrote: >> Justin Lu has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains four additional commits >>

Re: RFR: 8295000: java/util/Formatter/Basic test cleanup [v2]

2022-10-27 Thread Lance Andersen
On Wed, 26 Oct 2022 21:00:43 GMT, Justin Lu wrote: >> Issue: java/util/Formatter/Basic regression test emits lots of warning >> messages (~60). >> >> Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files >> where the errors originate from are generated from the template.

Re: RFR: 8295000: java/util/Formatter/Basic test cleanup [v2]

2022-10-26 Thread Naoto Sato
On Wed, 26 Oct 2022 21:00:43 GMT, Justin Lu wrote: >> Issue: java/util/Formatter/Basic regression test emits lots of warning >> messages (~60). >> >> Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files >> where the errors originate from are generated from the template.

Re: RFR: 8295000: java/util/Formatter/Basic test cleanup [v2]

2022-10-26 Thread Brent Christian
On Wed, 26 Oct 2022 21:00:43 GMT, Justin Lu wrote: >> Issue: java/util/Formatter/Basic regression test emits lots of warning >> messages (~60). >> >> Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files >> where the errors originate from are generated from the template.

Re: RFR: 8295000: java/util/Formatter/Basic test cleanup [v2]

2022-10-26 Thread Justin Lu
> Issue: java/util/Formatter/Basic regression test emits lots of warning > messages (~60). > > Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files > where the errors originate from are generated from the template. > > Note: The reason why there is white space added (and

Re: RFR: 8295000: java/util/Formatter/Basic test cleanup

2022-10-18 Thread Brent Christian
On Tue, 18 Oct 2022 19:48:15 GMT, Justin Lu wrote: >> So, the above suggestion gives explicit auto-boxing, though some might find >> it wordier than necessary. >> >> Since `v.byteValue()` already returns a `byte`, the `(byte)` cast doesn't >> seem necessary. I see that L242 does: >>> `return -

Re: RFR: 8295000: java/util/Formatter/Basic test cleanup

2022-10-18 Thread Justin Lu
On Tue, 18 Oct 2022 19:10:00 GMT, Brent Christian wrote: >> test/jdk/java/util/Formatter/BasicByteObject.java line 232: >> >>> 230: >>> 231: private static Byte negate(Byte v) { >>> 232: return (byte) -v.byteValue(); >> >> We want to be returning a `Byte`, so casting to `(byte)` do

Re: RFR: 8295000: java/util/Formatter/Basic test cleanup

2022-10-18 Thread Brent Christian
On Fri, 14 Oct 2022 00:37:53 GMT, Brent Christian wrote: >> Issue: java/util/Formatter/Basic regression test emits lots of warning >> messages (~60). >> >> Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files >> where the errors originate from are generated from the templ

Re: RFR: 8295000: java/util/Formatter/Basic test cleanup

2022-10-18 Thread Brent Christian
On Thu, 13 Oct 2022 01:02:43 GMT, Justin Lu wrote: > Issue: java/util/Formatter/Basic regression test emits lots of warning > messages (~60). > > Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files > where the errors originate from are generated from the template. > >

Re: RFR: 8295000: java/util/Formatter/Basic test cleanup

2022-10-13 Thread Brent Christian
On Thu, 13 Oct 2022 01:02:43 GMT, Justin Lu wrote: > Issue: java/util/Formatter/Basic regression test emits lots of warning > messages (~60). > > Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files > where the errors originate from are generated from the template. > >

RFR: 8295000: java/util/Formatter/Basic test cleanup

2022-10-13 Thread Justin Lu
Issue: java/util/Formatter/Basic regression test emits lots of warning messages (~60). Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files where the errors originate from are generated from the template. Note: The reason why there is white space added (and already existi