On Wed, 26 Oct 2022 21:00:43 GMT, Justin Lu <d...@openjdk.org> wrote:
>> Issue: java/util/Formatter/Basic regression test emits lots of warning >> messages (~60). >> >> Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files >> where the errors originate from are generated from the template. >> >> Note: The reason why there is white space added (and already existing in the >> BasicXXX files) is due to how the template is generated. > > Justin Lu has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains four additional commits since > the last revision: > > - Merge master > - Adjust template to reduce whitespace > - Re-add modified BasicDateTime test contents removed by generated template > - Adjust template to cleanup errors Hi Justin I think this looks oK overall. There is some additional cleanup that can be done at a later time as we discussed but should be separate from this issue ------------- Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.org/jdk/pull/10684
