Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v13]

2022-10-24 Thread Brent Christian
On Mon, 24 Oct 2022 21:19:21 GMT, Justin Lu wrote: >> Issue: Resource bundle name does not follow proper naming conventions >> according to [getBundle >> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Local

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v13]

2022-10-24 Thread Justin Lu
> Issue: Resource bundle name does not follow proper naming conventions > according to [getBundle > method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module)) > for base name parameter > > Fix

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v12]

2022-10-24 Thread Naoto Sato
On Mon, 24 Oct 2022 16:37:56 GMT, Justin Lu wrote: >> Issue: Resource bundle name does not follow proper naming conventions >> according to [getBundle >> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Local

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v12]

2022-10-24 Thread Lance Andersen
On Mon, 24 Oct 2022 16:37:56 GMT, Justin Lu wrote: >> Issue: Resource bundle name does not follow proper naming conventions >> according to [getBundle >> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Local

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v12]

2022-10-24 Thread Lance Andersen
On Mon, 24 Oct 2022 17:54:20 GMT, Brent Christian wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use data provider for getBundle test > > test/jdk/javax/sql/resourceBundleTests/ValidateGetBundle.java line 81: > >> 7

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v12]

2022-10-24 Thread Brent Christian
On Mon, 24 Oct 2022 16:37:56 GMT, Justin Lu wrote: >> Issue: Resource bundle name does not follow proper naming conventions >> according to [getBundle >> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Local

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v12]

2022-10-24 Thread Justin Lu
> Issue: Resource bundle name does not follow proper naming conventions > according to [getBundle > method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module)) > for base name parameter > > Fix

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v11]

2022-10-21 Thread Justin Lu
On Fri, 21 Oct 2022 22:10:45 GMT, Brent Christian wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> white space > > test/jdk/javax/sql/resourceBundleTests/ValidateGetBundle.java line 49: > >> 47: // The resourc

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v11]

2022-10-21 Thread Brent Christian
On Fri, 21 Oct 2022 19:55:55 GMT, Justin Lu wrote: >> Issue: Resource bundle name does not follow proper naming conventions >> according to [getBundle >> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Local

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v11]

2022-10-21 Thread Justin Lu
> Issue: Resource bundle name does not follow proper naming conventions > according to [getBundle > method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module)) > for base name parameter > > Fix

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v10]

2022-10-21 Thread Justin Lu
> Issue: Resource bundle name does not follow proper naming conventions > according to [getBundle > method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module)) > for base name parameter > > Fix

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v8]

2022-10-21 Thread Justin Lu
On Fri, 21 Oct 2022 18:04:29 GMT, Lance Andersen wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Pass exception to constuctor directly > > test/jdk/javax/sql/testng/test/rowset/ValidateResourceBundleAccess.java line

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v8]

2022-10-21 Thread Justin Lu
On Fri, 21 Oct 2022 18:03:27 GMT, Lance Andersen wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Pass exception to constuctor directly > > test/jdk/javax/sql/testng/test/rowset/ValidateResourceBundleAccess.java line

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v8]

2022-10-21 Thread Lance Andersen
On Fri, 21 Oct 2022 17:35:22 GMT, Justin Lu wrote: >> Issue: Resource bundle name does not follow proper naming conventions >> according to [getBundle >> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Local

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v9]

2022-10-21 Thread Justin Lu
> Issue: Resource bundle name does not follow proper naming conventions > according to [getBundle > method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module)) > for base name parameter > > Fix

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v8]

2022-10-21 Thread Justin Lu
> Issue: Resource bundle name does not follow proper naming conventions > according to [getBundle > method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module)) > for base name parameter > > Fix

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v4]

2022-10-21 Thread Justin Lu
On Fri, 21 Oct 2022 01:13:31 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Run Validate_.java in othervm mode > > test/jdk/javax/sql/resourceBundleTests/ValidateGetBundle.java line 67: > >> 65:

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v4]

2022-10-21 Thread Justin Lu
On Fri, 21 Oct 2022 01:08:36 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Run Validate_.java in othervm mode > > test/jdk/javax/sql/resourceBundleTests/ValidateGetBundle.java line 61: > >> 59:

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v7]

2022-10-21 Thread Justin Lu
> Issue: Resource bundle name does not follow proper naming conventions > according to [getBundle > method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module)) > for base name parameter > > Fix

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v4]

2022-10-21 Thread Justin Lu
On Fri, 21 Oct 2022 01:17:33 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Run Validate_.java in othervm mode > > test/jdk/javax/sql/testng/test/rowset/ValidateResourceBundleAccess.java line > 49: >

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v6]

2022-10-21 Thread Justin Lu
> Issue: Resource bundle name does not follow proper naming conventions > according to [getBundle > method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module)) > for base name parameter > > Fix

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v5]

2022-10-21 Thread Justin Lu
> Issue: Resource bundle name does not follow proper naming conventions > according to [getBundle > method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module)) > for base name parameter > > Fix

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v4]

2022-10-20 Thread Naoto Sato
On Thu, 20 Oct 2022 23:34:05 GMT, Justin Lu wrote: >> Issue: Resource bundle name does not follow proper naming conventions >> according to [getBundle >> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Local

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v4]

2022-10-20 Thread Justin Lu
On Wed, 19 Oct 2022 22:21:04 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Run Validate_.java in othervm mode > > test/jdk/javax/sql/resourceBundleTests/ValidateGetBundle.java line 45: > >> 43:

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v4]

2022-10-20 Thread Justin Lu
> Issue: Resource bundle name does not follow proper naming conventions > according to [getBundle > method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module)) > for base name parameter > > Fix

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v3]

2022-10-20 Thread Justin Lu
> Issue: Resource bundle name does not follow proper naming conventions > according to [getBundle > method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module)) > for base name parameter > > Fix

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java [v2]

2022-10-20 Thread Justin Lu
> Issue: Resource bundle name does not follow proper naming conventions > according to [getBundle > method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Locale,java.lang.Module)) > for base name parameter > > Fix

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java

2022-10-19 Thread Justin Lu
On Wed, 19 Oct 2022 22:27:27 GMT, Naoto Sato wrote: >> Issue: Resource bundle name does not follow proper naming conventions >> according to [getBundle >> method](https://docs.oracle.com/javase/8/docs/api/java/util/ResourceBundle.html#getBundle-java.lang.String-java.util.Locale-) >> for base n

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java

2022-10-19 Thread Justin Lu
On Wed, 19 Oct 2022 22:44:34 GMT, Naoto Sato wrote: > btw, the link to getBundle javadoc points to JDK8's, where the module has not > yet been introduced. I was scratching my head why I couldn't find the > overload that takes a Module 😀 I intended to focus on "baseName - the base name of the r

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java

2022-10-19 Thread Naoto Sato
On Fri, 7 Oct 2022 18:24:02 GMT, Justin Lu wrote: > Issue: Resource bundle name does not follow proper naming conventions > according to [getBundle > method](https://docs.oracle.com/javase/8/docs/api/java/util/ResourceBundle.html#getBundle-java.lang.String-java.util.Locale-) > for base name pa

Re: RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java

2022-10-19 Thread Naoto Sato
On Fri, 7 Oct 2022 18:24:02 GMT, Justin Lu wrote: > Issue: Resource bundle name does not follow proper naming conventions > according to [getBundle > method](https://docs.oracle.com/javase/8/docs/api/java/util/ResourceBundle.html#getBundle-java.lang.String-java.util.Locale-) > for base name pa

RFR: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java

2022-10-19 Thread Justin Lu
Issue: Resource bundle name does not follow proper naming conventions according to [getBundle method](https://docs.oracle.com/javase/8/docs/api/java/util/ResourceBundle.html#getBundle-java.lang.String-java.util.Locale-) for base name parameter Fix: Modified bundle name to be a fully qualified c