On Fri, 21 Oct 2022 01:17:33 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Run Validate_.java in othervm mode
>
> test/jdk/javax/sql/testng/test/rowset/ValidateResourceBundleAccess.java line
> 49:
>
>> 47: public void testResourceBundleAccess() throws SQLException {
>> 48: // Checking against English messages, set to US Locale
>> 49: Locale.setDefault(Locale.US);
>
> Could be placed in a separate static method with `@BeforeAll` annotation.
Good point, used TestNg's @BeforeClass
> test/jdk/javax/sql/testng/test/rowset/ValidateResourceBundleAccess.java line
> 60:
>
>> 58: jrs.getMetaData();
>> 59: // Unexpected case where exception is not forced
>> 60: var msg = "$$$ Error: SQLException was not caught!%n";
>
> The literal can directly be used as the argument to the constructor.
Right, made the change
-------------
PR: https://git.openjdk.org/jdk/pull/10612
