On Thu, 11 Aug 2022 14:16:51 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8290041?
>>
>> As noted by the reporter, the current implementation is buggy since the
>> calculation can result in a different value
On Mon, 15 Aug 2022 16:07:45 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> incorporate review comments and add more testing
>
> test/jdk/java/lang/module/ModuleDescriptorHashCodeTest.java line 1
On Thu, 11 Aug 2022 14:16:51 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8290041?
>>
>> As noted by the reporter, the current implementation is buggy since the
>> calculation can result in a different value
On Wed, 10 Aug 2022 15:23:12 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> incorporate review comments and add more testing
>
> test/jdk/java/lang/module/ModuleDescriptorHashCodeTest.java line 7
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8290041?
>
> As noted by the reporter, the current implementation is buggy since the
> calculation can result in a different value of the hashcode depending on the
> order of iteration of the
