Re: RFR: 8288327: Executable.hasRealParameterData should not be volatile [v4]

2022-06-30 Thread Сергей Цыпанов
On Wed, 29 Jun 2022 18:11:50 GMT, liach wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8288327: Mark ParameterData.parameters as @Stable and rename real -> isReal > > src/java.base/share/classes/java/lang/reflec

Re: RFR: 8288327: Executable.hasRealParameterData should not be volatile [v4]

2022-06-29 Thread liach
On Fri, 17 Jun 2022 11:21:49 GMT, Сергей Цыпанов wrote: >> If there are two threads calling `Executable.hasRealParameterData()` under >> race and the first one writes into volatile `Executable.parameters` field >> (doing _releasing store_) and the second thread reads non-null value from >> the

Re: RFR: 8288327: Executable.hasRealParameterData should not be volatile [v4]

2022-06-17 Thread liach
On Fri, 17 Jun 2022 11:17:18 GMT, Сергей Цыпанов wrote: >> src/java.base/share/classes/java/lang/reflect/Executable.java line 777: >> >>> 775: } >>> 776: >>> 777: record ParameterData(Parameter[] parameters, boolean real) {} >> >> The `ParameterData.parameters` field can probably be ma

Re: RFR: 8288327: Executable.hasRealParameterData should not be volatile [v4]

2022-06-17 Thread Сергей Цыпанов
> If there are two threads calling `Executable.hasRealParameterData()` under > race and the first one writes into volatile `Executable.parameters` field > (doing _releasing store_) and the second thread reads non-null value from the > same field (doing acquiring read) then it must read exactly t

Re: RFR: 8288327: Executable.hasRealParameterData should not be volatile [v4]

2022-06-17 Thread Сергей Цыпанов
On Fri, 17 Jun 2022 10:31:39 GMT, ExE Boss wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8288327: Mark ParameterData.parameters as @Stable and rename real -> isReal > > src/java.base/share/classes/java/lang/ref