On Fri, 17 Jun 2022 10:31:39 GMT, ExE Boss <d...@openjdk.org> wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8288327: Mark ParameterData.parameters as @Stable and rename real -> isReal
>
> src/java.base/share/classes/java/lang/reflect/Executable.java line 777:
>
>> 775: }
>> 776:
>> 777: record ParameterData(Parameter[] parameters, boolean real) {}
>
> The `ParameterData.parameters` field can probably be marked as [`@Stable`]
> (since the `parameters` array is never modified):
> Suggestion:
>
> record ParameterData(@Stable Parameter[] parameters, boolean real) {}
>
>
> Also the `real` record component should probably be renamed to `isReal` as
> @liach suggested in [GH‑9143 (comment)].
>
> [GH‑9143 (comment)]:
> https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9143*discussion_r899802093__;Iw!!ACWV5N9M2RV99hQ!PPLP0cqTBjkLFwhsIrte6kC_0rHTBaDkXEkEhu1D1VgRyiTiYjNKzT8X7812VcB4h64d6A33thLyzviiW7es$
>
> [`@Stable`]:
> https://urldefense.com/v3/__https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/jdk/internal/vm/annotation/Stable.java__;!!ACWV5N9M2RV99hQ!PPLP0cqTBjkLFwhsIrte6kC_0rHTBaDkXEkEhu1D1VgRyiTiYjNKzT8X7812VcB4h64d6A33thLyzunOu8jW$
>
Done!
-------------
PR: https://git.openjdk.org/jdk/pull/9143
