Re: RFR: 8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message [v3]

2025-04-17 Thread kerr
On Fri, 28 Mar 2025 13:19:50 GMT, Viktor Klang wrote: >> He-Pin(kerr) has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - . >> - . > > test/jdk/java/util/concurrent/tck/ThreadPoolExecuto

Re: RFR: 8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message [v4]

2025-04-17 Thread kerr
> Motivation: > When a user passes a wrong parameter, the current implementation throws an > IllegalArgumentException with an error message `null`, which is not helpful. > > Modification: > Add detail error messages. > > Result: > Helpful messages. He-Pin(kerr) h

Re: RFR: 8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message [v3]

2025-03-01 Thread kerr
> Motivation: > When a user passes a wrong parameter, the current implementation throws an > IllegalArgumentException with an error message `null`, which is not helpful. > > Modification: > Add detail error messages. > > Result: > Helpful messages. He-Pin(kerr) h

Re: RFR: 8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message [v2]

2025-02-24 Thread kerr
> Motivation: > When a user passes a wrong parameter, the current implementation throws an > IllegalArgumentException with an error message `null`, which is not helpful. > > Modification: > Add detail error messages. > > Result: > Helpful messages. He-Pin(kerr) h

Re: RFR: 8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message

2025-02-10 Thread kerr
On Sat, 11 Jan 2025 07:10:53 GMT, He-Pin(kerr) wrote: > Motivation: > When a user passes a wrong parameter, the current implementation throws an > IllegalArgumentException with an error message `null`, which is not helpful. > > Modification: > Add detail error messages. >

Re: RFR: 8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message

2025-01-24 Thread kerr
On Sat, 11 Jan 2025 07:10:53 GMT, He-Pin(kerr) wrote: > Motivation: > When a user passes a wrong parameter, the current implementation throws an > IllegalArgumentException with an error message `null`, which is not helpful. > > Modification: > Add detail error messages. >

RFR: 8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message

2025-01-24 Thread kerr
Motivation: When a user passes a wrong parameter, the current implementation throws an IllegalArgumentException with an error message `null`, which is not helpful. Modification: Add detail error messages. Result: Helpful messages. - Commit messages: - . - chore: add messages for

Re: [jdk24] RFR: 8347542: Gatherers.mapConcurrent exhibits undesired behavior under variable delays, interruption, and finishing

2025-01-13 Thread kerr
On Mon, 13 Jan 2025 12:59:06 GMT, Viktor Klang wrote: > Backport to jdk24 of https://bugs.openjdk.org/browse/JDK-8347274 Does this fix the OOM problem? import java.util.stream.Gatherers; import java.util.stream.IntStream; /** * TODO: description of this file * * @author 虎鸣 */ public class

Re: RFR: 8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message

2025-01-13 Thread kerr
On Mon, 13 Jan 2025 16:28:52 GMT, Viktor Klang wrote: > Seems sensible to improve this given that it can be tricky to figure out > which parameter caused the exception to be thrown. https://github.com/openjdk/jdk/pull/23050 There is already a pr for this:) As I encountered this in production

Re: RFR: 8312436: CompletableFuture never completes when 'Throwable.toString()' method throws Exception

2024-06-27 Thread kerr
On Sun, 28 Apr 2024 09:54:34 GMT, Viktor Klang wrote: > Primarily offering this PR for discussion, as Throwables throwing exceptions > on toString(), getLocalizedMessage(), or getMessage() seems like a rather > unreasonable thing to do. > > Nevertheless, there is some things we can do, as witn

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v8]

2024-01-15 Thread kerr
On Mon, 4 Dec 2023 13:56:55 GMT, Doug Lea wrote: >> This update cascades timeouts to trim subsequent workers after the first >> keepAlive inactive period. > > Doug Lea has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelate

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v8]

2024-01-13 Thread kerr
On Fri, 12 Jan 2024 13:41:39 GMT, kerr wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 10 additional com

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v8]

2024-01-12 Thread kerr
On Mon, 4 Dec 2023 13:56:55 GMT, Doug Lea wrote: >> This update cascades timeouts to trim subsequent workers after the first >> keepAlive inactive period. > > Doug Lea has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelate