Re: RFR: 8333893: Optimization for StringBuilder append boolean & null [v20]

2025-02-01 Thread altrisi
On Fri, 18 Oct 2024 21:56:53 GMT, Shaojin Wen wrote: >> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into >> primitive arrays by combining values ​​into larger stores. >> >> This PR rewrites the code of appendNull and append(boolean) methods so that >> these two meth

Re: RFR: 8333893: Optimization for StringBuilder append boolean & null [v20]

2025-02-01 Thread altrisi
On Fri, 18 Oct 2024 21:56:53 GMT, Shaojin Wen wrote: >> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into >> primitive arrays by combining values ​​into larger stores. >> >> This PR rewrites the code of appendNull and append(boolean) methods so that >> these two meth

Re: RFR: 8348880: Replace ConcurrentMap with AtomicReferenceArray for ZoneOffset.QUARTER_CACHE [v8]

2025-01-29 Thread altrisi
On Wed, 29 Jan 2025 06:42:02 GMT, Shaojin Wen wrote: >> ZoneOffset.MINUTES_15_CACHE uses AtomicReferenceArray to replace >> ConcurrentMap to avoid object allocation caused by boxing from int to >> Integer during access. > > Shaojin Wen has updated the pull request incrementally with one additio

Re: RFR: 8315850: Improve AbstractMap anonymous Iterator classes [v3]

2023-09-08 Thread altrisi
On Fri, 8 Sep 2023 16:13:16 GMT, Per Minborg wrote: >> This PR proposes to slightly improve some iterators of `AbstractMap`: >> >> * Code reuse >> * A field declared `final` >> * Add missing `@Override` annotations > > Per Minborg has updated the pull request incrementally with two additional >

Re: RFR: 8300979: Lazily initialize (byte, char)arr in java.io.DataInputStream [v3]

2023-03-23 Thread altrisi
On Wed, 22 Mar 2023 10:12:26 GMT, Per Minborg wrote: >> This PR proposed to lazily initialize the scratch arrays only if/when needed. > > Per Minborg has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought

Re: RFR: 8301834: Templated Buffer classes leave a lot of empty lines in the generated source

2023-02-06 Thread altrisi
On Mon, 6 Feb 2023 06:57:43 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which proposes to fix the issue > noted in https://bugs.openjdk.org/browse/JDK-8301834? > > Some classes in `java.nio` package are generated from template files, during > the build. The template fi

Re: RFR: 8300236: Use VarHandle access in Data(Input | Output)Stream classes [v8]

2023-01-25 Thread altrisi
On Tue, 24 Jan 2023 12:44:17 GMT, Per Minborg wrote: >> This PR proposes using a performance optimization using a new supported API >> for operations similar to those found in `java.io.Bits` > > Per Minborg has updated the pull request incrementally with one additional > commit since the last r

Re: RFR: 8299502: Usage of constructors of primitive wrapper classes should be avoided in javax.xml API docs [v2]

2023-01-14 Thread altrisi
On Fri, 6 Jan 2023 21:59:13 GMT, Justin Lu wrote: >> Removed constructors of primitive wrapper classes (deprecated for removal) >> in _javax.xml.stream.XMLOutputFactory_ >> >> Replaced with Boolean static fields: Boolean.TRUE and Boolean.FALSE > > Justin Lu has updated the pull request increme

Re: RFR: 8299502: Usage of constructors of primitive wrapper classes should be avoided in javax.xml API docs [v2]

2023-01-11 Thread altrisi
On Fri, 6 Jan 2023 21:59:13 GMT, Justin Lu wrote: >> Removed constructors of primitive wrapper classes (deprecated for removal) >> in _javax.xml.stream.XMLOutputFactory_ >> >> Replaced with Boolean static fields: Boolean.TRUE and Boolean.FALSE > > Justin Lu has updated the pull request increme

Integrated: 8284640: CollectorImpl class could be a record class

2022-06-28 Thread altrisi
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote: > Changes the definition of `CollectorImpl` to be a record. This pull request has now been integrated. Changeset: af008807 Author: altrisi Committer: Paul Hohensee URL: https://git.openjdk.org/jdk/com

Re: RFR: 8284640: CollectorImpl class could be a record class

2022-06-28 Thread altrisi
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote: > Changes the definition of `CollectorImpl` to be a record. Thanks for the review! - PR: https://git.openjdk.org/jdk/pull/8179

Re: RFR: 8284640: CollectorImpl class could be a record class

2022-06-27 Thread altrisi
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote: > Changes the definition of `CollectorImpl` to be a record. Hi, is this small PR missing anything in order to be reviewed? Thanks! - PR: https://git.openjdk.org/jdk/pull/8179