On Thu, 6 Feb 2025 10:33:34 GMT, Tobias Hartmann wrote:
> Added missing comma.
>
> Thanks,
> Tobias
This pull request has now been integrated.
Changeset: 4618993e
Author:Tobias Hartmann
URL:
https://git.openjdk.org/jdk/commit/4618993e27c806e5b349de98c020a91475727d65
Added missing comma.
Thanks,
Tobias
-
Commit messages:
- And another one
- 8349537: Bad copyright in TestArrayStructs.java
Changes: https://git.openjdk.org/jdk/pull/23489/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23489&range=00
Issue: https://bugs.openjdk.org/brow
On Thu, 6 Feb 2025 10:33:34 GMT, Tobias Hartmann wrote:
> Added missing comma.
>
> Thanks,
> Tobias
Thanks for the quick review!
Thanks again!
-
PR Comment: https://git.openjdk.org/jdk/pull/23489#issuecomment-2639437494
PR Comment: https://git.openjdk.org/jd
On Fri, 22 Nov 2024 14:19:57 GMT, Tobias Hartmann wrote:
> Some tests specify `-XX:+EnableX86ECoreOpts` which does not work well with
> `-Xcheck:jni` on Windows. Disable `CheckJNICalls` for now with these tests
> until [JDK-8344802](https://bugs.openjdk.org/browse/JDK-8344802)
On Fri, 22 Nov 2024 14:19:57 GMT, Tobias Hartmann wrote:
> Some tests specify `-XX:+EnableX86ECoreOpts` which does not work well with
> `-Xcheck:jni` on Windows. Disable `CheckJNICalls` for now with these tests
> until [JDK-8344802](https://bugs.openjdk.org/browse/JDK-8344802)
Some tests specify `-XX:+EnableX86ECoreOpts` which does not work well with
`-Xcheck:jni` on Windows. Disable `CheckJNICalls` for now with these tests
until [JDK-8344802](https://bugs.openjdk.org/browse/JDK-8344802) is fixed.
Thanks,
Tobias
-
Commit messages:
- Disable it
- 834486
On Sun, 10 Nov 2024 08:58:18 GMT, Shaojin Wen wrote:
>> Move getChars methods of StringLatin1 and StringUTF16 to DecimalDigits to
>> reduce duplication
>>
>> 1. HexDigits and OctalDigits also include getCharsLatin1 and getCharsUTF16
>> 2. Putting these two methods into DecimalDigits can avoid t
On Thu, 24 Oct 2024 13:36:50 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> for following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>
On Fri, 27 Sep 2024 14:21:57 GMT, Galder Zamarreño wrote:
>> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
>> order to help improve vectorization performance.
>>
>> Currently vectorization does not kick in for loops containing either of
>> these calls because of
On Wed, 9 Oct 2024 11:05:15 GMT, Galder Zamarreño wrote:
>> You've probably seen this but the new test is failing IR verification:
>>
>>
>> Failed IR Rules (4) of Methods (4)
>> --
>> 1) Method "private static double
>> compiler.intrinsics.math.TestMinMaxInlinin
On Thu, 3 Oct 2024 16:54:40 GMT, Aleksey Shipilev wrote:
>> test/micro/org/openjdk/bench/java/lang/ref/ReferenceClear.java line 2:
>>
>>> 1: //
>>> 2: // * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
>>
>> Drive-by comment: The `// *` format looks weird.
>
> Actually, this
On Mon, 30 Sep 2024 16:59:16 GMT, Aleksey Shipilev wrote:
>> [JDK-8240696](https://bugs.openjdk.org/browse/JDK-8240696) added the native
>> method for `Reference.clear`. The original patch skipped intrinsification of
>> this method, because we thought `Reference.clear` is not on a performance
On Fri, 27 Sep 2024 14:21:57 GMT, Galder Zamarreño wrote:
>> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
>> order to help improve vectorization performance.
>>
>> Currently vectorization does not kick in for loops containing either of
>> these calls because of
On Tue, 24 Sep 2024 14:18:58 GMT, Tobias Hartmann wrote:
> When investigating an intermittent NPE with an Oracle internal test on
> AArch64, I noticed that the NPE is actually a SIGSEGV in the code emitted by
> `MethodHandles::jump_to_lambda_form` when trying to load the
> `Member
On Wed, 25 Sep 2024 17:23:21 GMT, Abdelhak Zaaim wrote:
>> When investigating an intermittent NPE with an Oracle internal test on
>> AArch64, I noticed that the NPE is actually a SIGSEGV in the code emitted by
>> `MethodHandles::jump_to_lambda_form` when trying to load the
>> `MemberName::meth
On Tue, 24 Sep 2024 15:11:58 GMT, Chen Liang wrote:
>> When investigating an intermittent NPE with an Oracle internal test on
>> AArch64, I noticed that the NPE is actually a SIGSEGV in the code emitted by
>> `MethodHandles::jump_to_lambda_form` when trying to load the
>> `MemberName::method`
On Tue, 24 Sep 2024 14:18:58 GMT, Tobias Hartmann wrote:
> When investigating an intermittent NPE with an Oracle internal test on
> AArch64, I noticed that the NPE is actually a SIGSEGV in the code emitted by
> `MethodHandles::jump_to_lambda_form` when trying to load the
> `Member
On Tue, 24 Sep 2024 15:18:19 GMT, Tobias Hartmann wrote:
>> test/jdk/java/lang/invoke/TestLambdaFormCustomization.java line 32:
>>
>>> 30: * @bug 8340812
>>> 31: * @summary Verify that LambdaForm customization via
>>> MethodHandle::updateForm
On Tue, 24 Sep 2024 17:15:21 GMT, Aleksey Shipilev wrote:
>> When investigating an intermittent NPE with an Oracle internal test on
>> AArch64, I noticed that the NPE is actually a SIGSEGV in the code emitted by
>> `MethodHandles::jump_to_lambda_form` when trying to load the
>> `MemberName::me
On Tue, 24 Sep 2024 14:18:58 GMT, Tobias Hartmann wrote:
> When investigating an intermittent NPE with an Oracle internal test on
> AArch64, I noticed that the NPE is actually a SIGSEGV in the code emitted by
> `MethodHandles::jump_to_lambda_form` when trying to load the
> `Member
On Tue, 24 Sep 2024 15:11:58 GMT, Chen Liang wrote:
>> When investigating an intermittent NPE with an Oracle internal test on
>> AArch64, I noticed that the NPE is actually a SIGSEGV in the code emitted by
>> `MethodHandles::jump_to_lambda_form` when trying to load the
>> `MemberName::method`
When investigating an intermittent NPE with an Oracle internal test on AArch64,
I noticed that the NPE is actually a SIGSEGV in the code emitted by
`MethodHandles::jump_to_lambda_form` when trying to load the
`MemberName::method` field because the `MemberName` we retrieved from
`LambdaForm::vme
On Thu, 22 Aug 2024 07:14:29 GMT, Dean Long wrote:
>> src/hotspot/share/opto/library_call.cpp line 3787:
>>
>>> 3785: set_all_memory(input_memory_state);
>>> 3786: uncommon_trap_exact(Deoptimization::Reason_intrinsic,
>>> 3787: Deoptimization::Action_reinterpret);
On Wed, 21 Aug 2024 20:11:05 GMT, Markus Grönlund wrote:
> Greetings,
>
> Please help review this change set that implements C2 intrinsics for
> jdk.internal.vm.Continuation.pin() and jdk.internal.vm.Continuation.unpin().
>
> This work is a consequence of
> [JDK-8338417](https://bugs.openjdk.
On Wed, 24 Jul 2024 16:00:10 GMT, Shaojin Wen wrote:
>> [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We
>> need a JMH Benchmark to evaluate the performance of various batch operations
>> and the effect of MergeStore.
>
> Shaojin Wen has updated the pull request with
On Wed, 22 May 2024 14:19:36 GMT, Volodymyr Paprotski wrote:
>> Volodymyr Paprotski has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains 17
>> additi
On Fri, 31 May 2024 09:01:38 GMT, MaxXing wrote:
> This patch changes the algorithm of `Node::dominates` to make the result more
> precise, and allows the iterators of `ConcurrentHashMap` to be scalar
> replaced.
>
> The previous algorithm will return a conservative result when encountering a
On Wed, 29 May 2024 22:20:31 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Tue, 21 May 2024 17:41:46 GMT, Volodymyr Paprotski wrote:
>> Performance. Before:
>>
>> Benchmark(algorithm) (dataSize) (keyLength)
>> (provider) Mode Cnt ScoreError Units
>> SignatureBench.ECDSA.signSHA256withECDSA1024 256
On Tue, 21 May 2024 17:41:46 GMT, Volodymyr Paprotski wrote:
>> Performance. Before:
>>
>> Benchmark(algorithm) (dataSize) (keyLength)
>> (provider) Mode Cnt ScoreError Units
>> SignatureBench.ECDSA.signSHA256withECDSA1024 256
On Fri, 17 May 2024 21:16:47 GMT, Volodymyr Paprotski wrote:
>> Performance. Before:
>>
>> Benchmark(algorithm) (dataSize) (keyLength)
>> (provider) Mode Cnt ScoreError Units
>> SignatureBench.ECDSA.signSHA256withECDSA1024 256
On Fri, 17 May 2024 21:16:47 GMT, Volodymyr Paprotski wrote:
>> Performance. Before:
>>
>> Benchmark(algorithm) (dataSize) (keyLength)
>> (provider) Mode Cnt ScoreError Units
>> SignatureBench.ECDSA.signSHA256withECDSA1024 256
On Thu, 2 May 2024 05:57:50 GMT, Tobias Hartmann wrote:
> Removed the Classpath exception from the copyright header of some compiler
> tests and benchmarks.
>
> Thanks,
> Tobias
Thanks for the review David!
-
PR Comment: https://git.openjdk.org/jdk/pull/190
On Thu, 2 May 2024 05:57:50 GMT, Tobias Hartmann wrote:
> Removed the Classpath exception from the copyright header of some compiler
> tests and benchmarks.
>
> Thanks,
> Tobias
This pull request has now been integrated.
Changeset: d3bf5262
Author:Tobias Hartmann
UR
Removed the Classpath exception from the copyright header of some compiler
tests and benchmarks.
Thanks,
Tobias
-
Commit messages:
- 8331518: Tests should not use the Classpath exception form of the legal
header
Changes: https://git.openjdk.org/jdk/pull/19047/files
Webrev: http
On Sat, 20 Apr 2024 22:31:48 GMT, Scott Gibbons wrote:
>> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
>> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
>> this change.
>>
>> Overall, making this an intrinsic improves overall performanc
On Tue, 21 Nov 2023 21:03:20 GMT, Steve Dohrmann wrote:
>> Update: the XorTest::xor results shown in this message used test code from
>> PR commit 7cc272e862791 which was based on Maurizio Cimadamore's commit
>> a788f066af17. The XorTest has since been updated and XorTest::copy is no
>> longe
On Thu, 16 Nov 2023 21:26:47 GMT, Steve Dohrmann wrote:
>> Below is baseline data collected using a modified version of the
>> java.lang.foreign.xor micro benchmark referenced by @mcimadamore in the bug
>> report. I collected data on an Ubuntu 22.04 laptop with a Tigerlake
>> i7-1185G7, whic
On Thu, 16 Nov 2023 21:26:47 GMT, Steve Dohrmann wrote:
>> Below is baseline data collected using a modified version of the
>> java.lang.foreign.xor micro benchmark referenced by @mcimadamore in the bug
>> report. I collected data on an Ubuntu 22.04 laptop with a Tigerlake
>> i7-1185G7, whic
On Thu, 16 Nov 2023 09:31:57 GMT, Claes Redestad wrote:
>>> This cause a crash if I run with -XX:UseAVX=3 -XX:AVX3Threshold=0:
>>
>> Good catch! Do we have a test for that scenario? If not, one should be added.
>>
>>> Alternatively [...]
>>
>> I would suggest to use `jmp(copy_chars_loop)` here
On Wed, 15 Nov 2023 15:40:49 GMT, Claes Redestad wrote:
>> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 8617:
>>
>>> 8615: lea(dst, Address(dst, tmp5, Address::times_1));
>>> 8616: subptr(len, tmp5);
>>> 8617: jmpb(copy_chars_loop);
>>
>> This cause a crash if I run with `-XX:Use
On Wed, 8 Nov 2023 23:23:48 GMT, Steve Dohrmann wrote:
> Below is baseline data collected using a modified version of the
> java.lang.foreign.xor micro benchmark referenced by @mcimadamore in the bug
> report. I collected data on an Ubuntu 22.04 laptop with a Tigerlake
> i7-1185G7, which doe
On Thu, 9 Nov 2023 04:16:25 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that might
On Thu, 10 Aug 2023 13:41:05 GMT, Doug Simon wrote:
>> In a test that stresses metaspace (such as
>> `vmTestbase/vm/mlvm/hiddenloader/stress/oome/metaspace/Test.java`) that also
>> uses `-Xcomp -XX:-TieredCompilation`, we've seen a failure in
>> `TranslatedException.` due to exhausted metaspac
On Tue, 8 Aug 2023 20:52:29 GMT, Doug Simon wrote:
> In a test that stresses metaspace (such as
> `vmTestbase/vm/mlvm/hiddenloader/stress/oome/metaspace/Test.java`) that also
> uses `-Xcomp -XX:-TieredCompilation`, we've seen a failure in
> `TranslatedException.` due to exhausted metaspace:
>
On Mon, 7 Aug 2023 12:27:39 GMT, Per Minborg wrote:
> This PR fixes a formatting error in a copyright header.
Looks good and trivial to me.
-
Marked as reviewed by thartmann (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15175#pullrequestreview-1565217211
On Mon, 31 Jul 2023 08:13:55 GMT, Jorn Vernee wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [6fca2898](https://github.com/openjdk/jdk/commit/6fca28988794b52a6aa974bed1ed6f4f07e0994b)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bein
On Wed, 26 Jul 2023 19:22:08 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList java/util/concurrent/tck/JSR166TestCase.java on
> select platforms.
I agree, we will temporarily disable the assert in JDK 21 and revert the
problem listing change with https://github.com/openjdk/jdk21
On Mon, 3 Jul 2023 07:13:14 GMT, Tobias Hartmann wrote:
> Backport of [JDK-8310829](https://bugs.openjdk.java.net/browse/JDK-8310829).
> Applies cleanly.
>
> Thanks,
> Tobias
This pull request has now been integrated.
Changeset: 6de4e8f6
Author:Tobias Hartmann
UR
On Mon, 3 Jul 2023 07:13:14 GMT, Tobias Hartmann wrote:
> Backport of [JDK-8310829](https://bugs.openjdk.java.net/browse/JDK-8310829).
> Applies cleanly.
>
> Thanks,
> Tobias
Thanks, Christian!
-
PR Comment: https://git.openjdk.org/jdk21/pull/91#issuecomment-1617875850
Backport of [JDK-8310829](https://bugs.openjdk.java.net/browse/JDK-8310829).
Applies cleanly.
Thanks,
Tobias
-
Commit messages:
- 8310829: guarantee(!HAS_PENDING_EXCEPTION) failed in
ExceptionTranslation::doit
Changes: https://git.openjdk.org/jdk21/pull/91/files
Webrev: https://
On Tue, 27 Jun 2023 07:46:24 GMT, Tobias Hartmann wrote:
> Backport of [JDK-8310459](https://bugs.openjdk.java.net/browse/JDK-8310459).
> Applies cleanly.
>
> Thanks,
> Tobias
This pull request has now been integrated.
Changeset: 9998c07b
Author:Tobias Hartmann
UR
On Tue, 27 Jun 2023 07:46:24 GMT, Tobias Hartmann wrote:
> Backport of [JDK-8310459](https://bugs.openjdk.java.net/browse/JDK-8310459).
> Applies cleanly.
>
> Thanks,
> Tobias
Thanks, Vladimir!
-
PR Comment: https://git.openjdk.org/jdk21/pull/68#issuecomment-1610754095
Backport of [JDK-8310459](https://bugs.openjdk.java.net/browse/JDK-8310459).
Applies cleanly.
Thanks,
Tobias
-
Commit messages:
- 8310459: [BACKOUT] 8304450: [vectorapi] Refactor VectorShuffle implementation
Changes: https://git.openjdk.org/jdk21/pull/68/files
Webrev: https://web
On Fri, 23 Jun 2023 16:43:32 GMT, Jatin Bhateja wrote:
> Backing out shuffle related overhaul done with
> [JDK-8304450](https://bugs.openjdk.org/browse/JDK-8304450), we saw
> significant performance degradation in VectorAPI JMH micros and some of our
> internal benchmarks. Following two issues
On Sat, 10 Jun 2023 12:25:57 GMT, Tobias Holenstein
wrote:
>> At the moment `CompileCommand` and `CompileOnly` use different syntax for
>> matching methods.
>>
>> ### Old CompileOnly format
>> - matching a **method name** with **class name** and **package name**:
>> `-XX:CompileOnly=package/p
On Tue, 30 May 2023 13:31:16 GMT, Jie Fu wrote:
> Just remove the `static` to fix the build failure.
> Thanks.
Looks good and trivial.
-
Marked as reviewed by thartmann (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14218#pullrequestreview-1450983424
On Mon, 29 May 2023 02:20:07 GMT, Chang Peng wrote:
>> In Vector API Java level, vector mask is represented as a boolean array with
>> 0x00/0x01 (8 bits of each element) as values, aka in-memory format. When it
>> is loaded into vector register, e.g. Neon, the in-memory format will be
>> conve
On Tue, 2 May 2023 11:35:54 GMT, Tobias Holenstein
wrote:
> Currently, errors during compile command parsing just print an error but
> don't exit the VM. As a result, issues go unnoticed.
>
> With this PR the behavior is changed to exit the VM when an error occurs.
>
> E.g. `java -XX:Compile
On Thu, 4 May 2023 13:36:22 GMT, Tobias Holenstein
wrote:
> At the moment `CompileCommand` and `CompileOnly` use different syntax for
> matching methods.
>
> ### Old CompileOnly format
> - matching a **method name** with **class name** and **package name**:
> `-XX:CompileOnly=package/path/Cla
Hi Kosta,
Thanks again for the report! This test is owned by core-libs/java.lang, I'm
forwarding to
core-libs-dev and CC'ing Leonid, the author of
https://bugs.openjdk.org/browse/CODETOOLS-7903373.
I can see these failures in our testing as well but no one filed a bug yet. I
filed:
https://bug
On Mon, 27 Feb 2023 02:16:21 GMT, Yi Yang wrote:
>> Hi, can I have a review for this patch? I noticed a strange field
>> Integer.sizeTable which is used by PhaseStringOpts, after digging into the
>> history, I think it could be replaced by an in-place array allocation and
>> initialization. Be
e last revision:
>
> - Enable intrinsic for StrictMath.sqrt; thanks to Tobias Hartmann for
> assistance with the HotSpot updates.
> - Merge branch 'master' into JDK-8302040
> - Implement review feedback.
> - Add one one unsigned shift comment.
> - Respond to review feedba
On Tue, 11 Oct 2022 17:00:53 GMT, Smita Kamath wrote:
>> I started new testing.
>
> @vnkozlov Thank you for reviewing the patch.
There is an issue with the `_floatToFloat16` intrinsic, leading to incorrect
results: [JDK-8302976](https://bugs.openjdk.org/browse/JDK-8302976).
@smita-kamath, coul
On Fri, 18 Nov 2022 09:19:26 GMT, Matthias Baesken wrote:
> As discussed in https://bugs.openjdk.org/browse/JDK-8296945 , let us switch
> off VerifyDependencies in this test because of slow machines when
> (fast)debug builds are used, the test sometimes times out after the
> [JDK-8266074](htt
On Fri, 11 Nov 2022 13:00:06 GMT, Claes Redestad wrote:
>> Continuing the work initiated by @luhenry to unroll and then intrinsify
>> polynomial hash loops.
>>
>> I've rewired the library changes to route via a single `@IntrinsicCandidate`
>> method. To make this work I've harmonized how they
66 matches
Mail list logo
