On Thu, 10 Apr 2025 10:36:31 GMT, Magnus Ihse Bursie wrote:
>> As a follow-up to
>> [JDK-8354213](https://bugs.openjdk.org/browse/JDK-8354213), I found some
>> additional places where unicode characters are unnecessarily used instead of
>> pure ASCII.
>
> Magnus Ihse Bursie has updated the pul
On Thu, 6 Feb 2025 14:30:30 GMT, Per Minborg wrote:
>> `MethodHandles.byteArrayViewVarHandle` exposes checked multi-byte access to
>> byte arrays via VarHandle. This larger access speeds up many operations, yet
>> it cannot be used in early bootstrap, and as a result, people tend to use
>> `Un
On Fri, 24 Jan 2025 10:58:24 GMT, Hannes Wallnöfer wrote:
>> Please review a doc-only change to mostly add missing `@serial` javadoc
>> tags. This is a sub-task of [JDK-8286931] to allow us to re-enable the
>> javadoc `-serialwarn` option in the JDK doc build, which has been disabled
>> since
On Wed, 22 Jan 2025 09:23:10 GMT, Hannes Wallnöfer wrote:
>> src/java.datatransfer/share/classes/java/awt/datatransfer/DataFlavor.java
>> line 1288:
>>
>>> 1286:
>>> 1287: /**
>>> 1288: * Serializes this {@code DataFlavor}.
>>
>> This most definitely changes the serialisation spec. S
On Wed, 8 Jan 2025 20:13:50 GMT, Hannes Wallnöfer wrote:
> Please review a doc-only change to mostly add missing `@serial` javadoc tags.
> This is a sub-task of [JDK-8286931] to allow us to re-enable the javadoc
> `-serialwarn` option in the JDK doc build, which has been disabled since JDK
> 1
On Mon, 23 Dec 2024 20:29:09 GMT, Phil Race wrote:
>> test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/table/resources/oscars.xml
>> line 2:
>>
>>> 1:
>>> 2: http://www.fatdog.com/oscar-results";
>>
>> Does this change aff
On Mon, 23 Dec 2024 19:30:56 GMT, Kim Barrett wrote:
>> This patch fixes unmatched brackets in some source files.
>
> test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/table/resources/oscars.xml
> line 2:
>
>> 1:
>> 2: http://www.fatdog.com/oscar-results";
>
> Does this change
On Mon, 23 Dec 2024 19:42:34 GMT, Kim Barrett wrote:
> > That makes it harder to review and to manage the review, because it is
> > large and affects a wide range of areas, so may need many reviewers.
>
> And many of the appropriate reviewers might be unavailable for a while, since
> it's righ
On Tue, 17 Dec 2024 15:41:51 GMT, Magnus Ihse Bursie wrote:
> When the static launcher was introduced in
> [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480), due to time and
> resource constraints, it was only working properly on Linux and macOS, while
> the Windows port compiled but
On Tue, 17 Dec 2024 15:41:51 GMT, Magnus Ihse Bursie wrote:
> When the static launcher was introduced in
> [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480), due to time and
> resource constraints, it was only working properly on Linux and macOS, while
> the Windows port compiled but
On Wed, 18 Dec 2024 14:58:26 GMT, Roger Riggs wrote:
> Continuing SM removal cleanup of tests for test/jdk/java/beans and
> test/jdk/java/io/Serializable.
> Removing doPrivileged, Permissions, and SecurityException.
Beans changes look fine
-
Marked as reviewed by prr (Reviewer).
On Tue, 10 Dec 2024 09:31:21 GMT, Prasanta Sadhukhan
wrote:
> not sure why client label is added, no java.desktop/accessibility files are
> in there
I was puzzling over that too.
-
PR Comment: https://git.openjdk.org/jdk/pull/22640#issuecomment-2532895836
On Thu, 21 Nov 2024 22:21:47 GMT, Phil Race wrote:
> Clean up permission checks in java.awt.Desktop class
> Also remove no longer needed exports from java.base to java.desktop
This pull request has now been integrated.
Changeset: 50c099d6
Author: Phil Race
URL:
> Clean up permission checks in java.awt.Desktop class
> Also remove no longer needed exports from java.base to java.desktop
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8344799
-
Changes:
- all:
On Thu, 21 Nov 2024 23:46:14 GMT, Alexander Zvegintsev
wrote:
> There is a mention of the `GetPropertyAction` left in the comment:
>
> https://github.com/openjdk/jdk/blob/c199f5326b8dd41f33a12e5db7552331e0844601/src/java.desktop/share/classes/sun/awt/util/PerformanceLogger.java#L130
Did you me
Clean up permission checks in java.awt.Desktop class
Also remove no longer needed exports from java.base to java.desktop
-
Commit messages:
- 8344799
Changes: https://git.openjdk.org/jdk/pull/22311/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22311&range=00
Issue: http
On Wed, 23 Oct 2024 05:07:37 GMT, Julian Waters wrote:
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unuse
On Thu, 14 Nov 2024 23:51:24 GMT, Phil Race wrote:
> remove uses of SM APIs from the java.datatransfer module. Also cleans up the
> now un-needed export from java.base
This pull request has now been integrated.
Changeset: 99070658
Author: Phil Race
URL:
https://git.openjdk.o
remove uses of SM APIs from the java.datatransfer module. Also cleans up the
now un-needed export from java.base
-
Commit messages:
- 8344065
Changes: https://git.openjdk.org/jdk/pull/22127/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22127&range=00
Issue: https://bug
On Tue, 5 Nov 2024 01:41:00 GMT, SendaoYan wrote:
> Hi all,
> The copyright year of some files which has been changed by
> [JDK-8341692](https://bugs.openjdk.org/browse/JDK-8341692) wasn't update
> correctly. This PR update the copyright year of
> [JDK-8341692](https://bugs.openjdk.org/browse
On Fri, 1 Nov 2024 18:06:47 GMT, Alexey Ivanov wrote:
> > I'd not looked at this test before but when I do the thing I noticed is
> > that createPrivateValue is no longer used. But I don't see a problem with
> > keeping the rest of the test.
>
> @prrace Do I understand correctly that _“`create
On Fri, 8 Nov 2024 13:49:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main cha
On Fri, 1 Nov 2024 16:04:55 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Mon, 28 Oct 2024 12:29:07 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 25 Oct 2024 21:06:28 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/imageio/spi/AppletContextTest/IIOPluginTest.java line 42:
>>
>>> 40: } catch (ServiceConfigurationError sce) {
>>> 41: System.out.println("Expected ServiceConfigurationError \n"
>>> + sce);
>>> 42:
On Fri, 25 Oct 2024 21:23:26 GMT, Harshitha Onkar wrote:
>> The tests with “Audit Core Reflection” in their summary fall into this
>> category, we may consider removing them.
>
> @prrace Can you please advice on “Audit Core Reflection” category of tests.
> I'm not 100% sure if these tests need
On Wed, 23 Oct 2024 05:11:19 GMT, Prasanta Sadhukhan
wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNo
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 22 Oct 2024 15:22:08 GMT, Sean Mullan wrote:
>> test/jdk/javax/swing/JComboBox/8080972/TestBasicComboBoxEditor.java line 26:
>>
>>> 24: import javax.swing.SwingUtilities;
>>> 25: import javax.swing.plaf.basic.BasicComboBoxEditor;
>>> 26: /*
>>
>> I think we have finally decided that jtr
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Mon, 14 Oct 2024 13:52:24 GMT, Sean Mullan wrote:
> This is the implementation of JEP 486: Permanently Disable the Security
> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
> main change
On Wed, 9 Oct 2024 12:57:36 GMT, Axel Boldt-Christmas
wrote:
>> This is the implementation task for `JEP 490: ZGC: Remove the
>> Non-Generational Mode`. See the JEP for details.
>> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
>
> Axel Boldt-Christmas has updated the pull request
On Thu, 3 Oct 2024 18:15:55 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in this pull request, please see the
>> c
On Fri, 27 Sep 2024 18:08:54 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in this pull request, please see the
>>
On Wed, 25 Sep 2024 12:17:59 GMT, Matthias Baesken wrote:
> There is some old awt/2d coding where warnings occur when running with ubsan
> enabled binaries.
> However at most of these locations the coding should work (at least on our
> supported platform set) so the warnings can be disabled at
On Thu, 26 Sep 2024 16:25:21 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review: update wording of instructions
>
> test/jdk/java/util/TimeZone/DefaultTimeZoneTest.java line 80:
>
>> 78:
On Wed, 25 Sep 2024 22:03:59 GMT, Justin Lu wrote:
> Not sure if it will be ran by anyone as it is manual,
I don't know about other vendors, but for Oracle, manual tests are run at least
once on every release some time after RDP1 and before RDP2.
-
PR Comment: https://git.openjd
On Wed, 11 Sep 2024 09:19:21 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this trivial change which replaces the usages
>> of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are
>> o
On Wed, 21 Aug 2024 22:14:40 GMT, Magnus Ihse Bursie wrote:
>> As a preparation for Hermetic Java, we need to have a way to look up during
>> runtime if we are using a statically linked library or not.
>>
>> This change will be the first step needed towards compiling the object files
>> only o
On Tue, 16 Jul 2024 08:59:20 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The tra
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote:
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK. Primarily, the changes between JDK 22
> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>
> The translati
On Fri, 17 May 2024 13:38:25 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Fri, 17 May 2024 13:38:25 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Mon, 13 May 2024 10:49:30 GMT, Maurizio Cimadamore
wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> make/conf/module-loader-map.conf line 105:
>
>> 103: java.smartcardio \
On Thu, 2 May 2024 21:05:38 GMT, Alexander Zvegintsev
wrote:
> Trivial fix.
Marked as reviewed by prr (Reviewer).
OK. I see. The problem is that the test is out of sync with the actual usage of
Platform.
Arguably isOnWayland() and all these others should be in some OTHER class
entirely.
Some
On Thu, 2 May 2024 21:05:38 GMT, Alexander Zvegintsev
wrote:
> Trivial fix.
I see you added test.lib.Platform.isOnWayland() in this PR
https://github.com/openjdk/jdk/pull/18995/files#diff-a1fe81399728999601f16ae9aaf5caae27f009c394377d2cd86c71f6d5e0e54c
So, that helps me understand why it is a
On Thu, 2 May 2024 21:05:38 GMT, Alexander Zvegintsev
wrote:
> Trivial fix.
I'd love to approve this but could you please explain what this is about ?
I see the failure log in the bug report but I am none the wiser.
Why exactly is this a problem ?
-
PR Comment: https://git.openjd
On Fri, 26 Apr 2024 16:04:09 GMT, Jonathan Gibbons wrote:
>> Please review the updates to support a proposed new
>> `-Xlint:dangling-doc-comments` option.
>>
>> The work can be thought of as in 3 parts:
>>
>> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
>> is po
On Thu, 18 Apr 2024 11:32:13 GMT, Per Minborg wrote:
>> While `SymbolLookup` correctly uses an `Optional` return to denote whether a
>> symbol has been found by the lookup or not (which enables composition of
>> symbol lookups), many clients end up just calling `Optional::get`, or
>> `Optional
On Mon, 5 Feb 2024 10:58:17 GMT, Magnus Ihse Bursie wrote:
>> Inspired by (the later backed-out)
>> [JDK-8296115](https://bugs.openjdk.org/browse/JDK-8296115), I propose to
>> enable `-Wpedantic` for clang. This has already found some irregularities in
>> the code, like mistakenly using `#impo
On Thu, 15 Feb 2024 12:19:31 GMT, Magnus Ihse Bursie wrote:
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or if jcheck
> chan
On Wed, 22 Nov 2023 19:26:40 GMT, Phil Race wrote:
> Many printing tests do not have the @printer keyword. This adds them to those
> that need it.
> I also found one test that has nothing to do with printing in the print
> folder and moved it out.
This pull request has now bee
On Thu, 30 Nov 2023 19:50:00 GMT, Sergey Bylokhov wrote:
> probably we can link this from our wiki page where we describe the usage of
> keywords?:
> https://wiki.openjdk.org/display/ClientLibs/Automated+client+GUI+testing+system+set+up+requirements
Good idea, once this is pushed, I'll add th
> Many printing tests do not have the @printer keyword. This adds them to those
> that need it.
> I also found one test that has nothing to do with printing in the print
> folder and moved it out.
Phil Race has updated the pull request incrementally with one additional commit
si
On Thu, 30 Nov 2023 17:08:21 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8320608
>
> test/jdk/java/awt/print/PrinterJob/EmptyFill.java line 72:
>
On Thu, 30 Nov 2023 15:41:28 GMT, Alexey Ivanov wrote:
>> "Should not" is strong. Why ? There's no requirement do to this even though
>> you can.
>> https://openjdk.org/jtreg/faq.html#can-i-use-the-author-run-etc.-tags-in-other-files
>
> That's the reason why I prefer you keep the `@run` tag in
On Thu, 30 Nov 2023 15:59:29 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8320608
>
> test/jdk/java/awt/print/PageFormat/SmallPaperPrinting.java line 73:
>
&g
> Many printing tests do not have the @printer keyword. This adds them to those
> that need it.
> I also found one test that has nothing to do with printing in the print
> folder and moved it out.
Phil Race has updated the pull request incrementally with one additional commit
si
On Thu, 23 Nov 2023 20:39:50 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/print/PageFormat/SetOrient.java line 28:
>>
>>> 26: * @summary Confirm that the clip and transform of the Graphics2D is
>>> 27: * affected by the landscape orientation of the PageFormat.
>>> 28: */
>>
>> Sin
On Thu, 23 Nov 2023 07:02:54 GMT, Alan Bateman wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> test/jdk/TEST.ROOT line 15:
>
>> 13
On Thu, 23 Nov 2023 11:10:35 GMT, Alexey Ivanov wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> test/jdk/java/awt/PrintJob/EdgeTest
Many printing tests do not have the @printer keyword. This adds them to those
that need it.
I also found one test that has nothing to do with printing in the print folder
and moved it out.
-
Commit messages:
- 8320608
Changes: https://git.openjdk.org/jdk/pull/16785/files
Webrev:
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
This pull request has now been integrated.
Changeset: f69e6653
Author: Phil Race
URL:
https://git.openjdk.org/jdk/commit/f69e6653f86a7dd781db6c8523f114c0d3f7c
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8318364
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15476/files
- new: ht
On Thu, 16 Nov 2023 13:48:38 GMT, Prasanta Sadhukhan
wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> indentation
>
> src/java.desktop/share/classes/sun/font/HBShaper.java line 628:
&g
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8318364
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15476/files
- new: ht
On Wed, 15 Nov 2023 15:06:55 GMT, Jayathirth D V wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> indentation
>
> src/java.desktop/share/classes/sun/font/HBShaper.java line 66:
>
>
On Thu, 16 Nov 2023 19:35:53 GMT, Jorn Vernee wrote:
> > > > > layoutCnt=16000 total=193ms <<< app fully displayed
> > > > > vs
> > > > > layoutCnt=16000 total=453ms <<< app fully displayed
> > > >
> > > >
> > > > It looks strange that 16000 calls are not enough to warmup, and the
> > > > diff
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
Phil Race has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 21 commits:
- Merge remote-tracking branch 'upstream/master' into harfbuzz_pa
On Wed, 15 Nov 2023 15:52:43 GMT, Jayathirth D V wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> indentation
>
> src/java.desktop/share/classes/sun/font/HBShaper.java line 142:
>
On Wed, 23 Aug 2023 15:18:03 GMT, Matthias Baesken wrote:
>> Currently there is a number of functionality that would be interesting to
>> have for shared lib load operations in the JDK C code.
>> Some examples :
>> Events::log_dll_message for hs-err files reporting
>> JFR event NativeLibraryLoad
On Mon, 6 Nov 2023 23:58:11 GMT, Sergey Bylokhov wrote:
> > So we have somewhere around a fixed 125ms startup cost for the FFM case -
> > as measured on my Mac,
> > but only 35-40ms of that is attributable to the specific needs of layout.
>
> That looks unfortunate. I guess if we will start to
On Mon, 6 Nov 2023 18:52:05 GMT, Sergey Bylokhov wrote:
> Since we plan to import it into jdk22, do you have some performance data to
> share? any positive or negative effects of this migration?
There's three phases - (1) startup, (2) warmup and (3) warmed up performance.
JNI has minimal star
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
indentation
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15476/files
- new: ht
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
Use new arrayElementVarHandle method
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15476/fi
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
Phil Race has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 18 commits:
- Merge remote-tracking branch 'upstream/master' into harfbuzz_panama
Me
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
That's interesting. As soon as this went RFR, skara started to send all the
emails from several weeks of already resolved discussions but with a current
timestamp,
On Wed, 18 Oct 2023 06:16:15 GMT, Jorn Vernee wrote:
>>> > I'm unclear why it is "better". It seems more obscure to me.
>>>
>>> Ok. I think it's better because it doesn't require creating a maximum size
>>> sequence layout in order to then make a var handle out of, which is a bit
>>> of a hack
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
I've added a test, which although it does not check the rendering is correct,
it checks that the rendering would be identical in both the JNI and FFM cases.
So
On Wed, 18 Oct 2023 03:43:15 GMT, Jorn Vernee wrote:
> > I'm unclear why it is "better". It seems more obscure to me.
>
> Ok. I think it's better because it doesn't require creating a maximum size
> sequence layout in order to then make a var handle out of, which is a bit of
> a hack IMO. One
On Tue, 17 Oct 2023 11:50:20 GMT, Jorn Vernee wrote:
>> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
>
> src/java.desktop/share/classes/sun/font/HBShaper.java line 310:
>
>> 308: SequenceLayout glyphInfosLayout =
>> MemoryLayout.sequenceLayout(maxinfo, GlyphInfoL
On Wed, 30 Aug 2023 02:55:34 GMT, Sergey Bylokhov wrote:
> @prrace did you check how this change affects the performance, especially
> startup? I have experimented with Panama for littlecms:
> https://bugs.openjdk.org/browse/JDK-8313344 and found that the biggest issue
> is a cold start, 8 ms
8318364: Add an FFM-based implementation of harfbuzz OpenType layout
-
Commit messages:
- remove tailing white space
- use scaling
- Fix windows build, remove perf. logging
- Add test, fix bug
- use allocateFrom
- add offset param
- suppressed restricted warnings, now builds bu
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote:
> Currently there is a number of functionality that would be interesting to
> have for shared lib load operations in the JDK C code.
> Some examples :
> Events::log_dll_message for hs-err files reporting
> JFR event NativeLibraryLoad
> Th
On Wed, 5 Jul 2023 16:20:07 GMT, Roger Riggs wrote:
>> Source code cleanup.
>> Add @since, remove unused imports and remove unnecessary SuppressWarnings of
>> deprecation.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Rem
On Wed, 5 Jul 2023 14:51:31 GMT, Roger Riggs wrote:
> Source code cleanup.
> Add @since, remove unused imports and remove unnecessary SuppressWarnings of
> deprecation.
unless my eyes deceive me the suppresswarnings is still present.
-
Changes requested by prr (Reviewer).
PR Revi
On Mon, 19 Jun 2023 06:55:52 GMT, Axel Boldt-Christmas
wrote:
>> The current implementation for testing generational ZGC with jtreg is
>> implemented with a filter on the mode flag `ZGenerational`. Because of this
>> only environments which set this flag explicitly will run most of the tests.
On Thu, 1 Jun 2023 11:49:24 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
On Thu, 1 Jun 2023 11:49:24 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
On Fri, 26 May 2023 08:31:46 GMT, JoKern65 wrote:
>> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
>> on AIX , we run into various "warnings as errors".
>> Some of those are in shared codebase and could be addressed by small
>> adjustments.
>> A lot of those chang
On Wed, 17 May 2023 12:28:47 GMT, Artem Semenov wrote:
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
I don't like this approach at all. if github had a "reject" button I'd be
pushing it now.
updat
On Fri, 28 Apr 2023 01:03:28 GMT, Jiangli Zhou wrote:
> Initial implementation for supporting building a fully statically linked
> (with a desired set of JDK native libraries and libjvm) Java launcher
> executable, which is named as 'javastatic'.
>
> In this PR, the support is only added for t
On Fri, 31 Mar 2023 05:57:01 GMT, Julian Waters wrote:
>> A couple of spots wrongly refer to boolean and jboolean as the same thing.
>> While this does still compile thanks to a happy accident and implicit
>> conversions, they are not the same at all, and should be fixed before a
>> future com
On Thu, 6 Apr 2023 19:25:19 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X8
On Mon, 13 Mar 2023 21:16:24 GMT, Naoto Sato wrote:
> Proposing accessor methods to Emoji properties defined in [Unicode Technical
> Standard #51](https://unicode.org/reports/tr51/) in `java.lang.Character`
> class. This is per a request from the client group, as well as refining the
> current
On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo wrote:
> Please review this superficial documentation cleanup that was triggered by
> unrelated analysis of doc comments in JDK API.
>
> The only effect that this multi-area PR has on the JDK API Documentation
> (i.e. the observable effect on the ge
On Tue, 24 Jan 2023 22:12:26 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revisi
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote:
> Hi all,
>
> Please review the fix for the build failure with clang-15.
>
> 1. -Wbitwise-instead-of-logical
>
>1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the
> warning
>2) src/hotspot/share/runtime/notificationThre
On Tue, 17 Jan 2023 13:35:25 GMT, Kevin Rushforth wrote:
>>> Normally, such changes in third-party libraries need to be done upstream,
>>> and not locally. @prrace can confirm.
>>
>> Thanks @kevinrushforth for your review.
>>
>> Yes, it had been fixed in the upstream and I just follow it.
>> P
1 - 100 of 115 matches
Mail list logo
