On Wed, 15 Nov 2023 15:52:43 GMT, Jayathirth D V <j...@openjdk.org> wrote:
>> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> indentation > > src/java.desktop/share/classes/sun/font/HBShaper.java line 142: > >> 140: private static final MemorySegment get_contour_pt_stub; >> 141: >> 142: private static final MemorySegment store_layout_results_stub; > > I see this Upcall is named `store_layout_results` in case of FFM and we call > it similar function in JNI case as `storeGVData`. If we can find some common > name and use it will be beneficial in future when we want to compare code > between FFM and JNI implementation. noted, but not something I intend to change here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15476#discussion_r1395138283
