rietary API" warnings after this
> patch, it is acceptable because the relevant APIs are bound for removal
> for the integrity of the platform.
Nicole Xu has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated ch
On Thu, 27 Feb 2025 03:22:27 GMT, Nicole Xu wrote:
> Would it be possible to configure the build of the microbenchmarks to not
> pass `-Werror`, so they don't break when sunapi diagnostics are emitted?
>
> > Note that even it will raise "proprietary API" warning
On Wed, 8 Jan 2025 09:04:47 GMT, Nicole Xu wrote:
> Suite `MaskedLogicOpts.maskedLogicOperationsLong512()` failed on both x86 and
> AArch64 with the following error:
>
>
> java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249
>
>
> The varia
On Thu, 27 Feb 2025 01:55:59 GMT, Xiaohong Gong wrote:
>> Nicole Xu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8346954: [JMH] jdk.incubator.vector.MaskedLogicOpts fails due to
>> IndexOutOfBoun
On Fri, 21 Feb 2025 07:01:42 GMT, Nicole Xu wrote:
>> The UnsafeOps JMH benchmark fails with the following error:
>>
>> ```
>> java.lang.IllegalAccessError: class
>> org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520
On Mon, 17 Feb 2025 10:43:36 GMT, Emanuel Peter wrote:
>> Hi @eme64, do you see any risks here? Would you please help to review the
>> patch? Thanks.
>
> @xyyNicole @jatin-bhateja I think it is reasonable to just fix the benchmark
> so that it still has the same behaviour, just without the out-
On Tue, 25 Feb 2025 00:00:23 GMT, Paul Sandoz wrote:
>> Thanks for pointing that out. Typically, ARRAYLEN is almost always a POT
>> value, which is also assumed by many other benchmarks. Are we realistically
>> going to test with an ARRAYLEN of 30?
>>
>> I think the POT assumption is reasonab
On Fri, 21 Feb 2025 07:01:42 GMT, Nicole Xu wrote:
>> The UnsafeOps JMH benchmark fails with the following error:
>>
>> ```
>> java.lang.IllegalAccessError: class
>> org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520
On Thu, 20 Feb 2025 09:31:45 GMT, Jatin Bhateja wrote:
> > Sure. Since I am very new to openJDK, I asked my teammate for help to file
> > the follow-up RFE.
> > Here is the https://bugs.openjdk.org/browse/JDK-8350215 with description of
> > the discussed issues.
>
> Hi @xyyNicole ,
>
> I have
ry for all vector species. This is also
> consistent with other kernel functions.
>
> Additionally, some defined but unused variables have been removed.
Nicole Xu has updated the pull request incrementally with two additional
commits since the last revision:
- 8346954: [JMH] jdk.incub
On Fri, 21 Feb 2025 07:10:16 GMT, Alan Bateman wrote:
> Thanks for restoring, this micro was specifically for sun.misc.Unsafe. I'm
> not wondering about the FFM micros that were also changed by JDK-8332744.
> Might not matter there but I think the original motive was to compare against
> sun.m
se does not export jdk.internal.misc to unnamed module @0x520a3426
>
> To resolve this, we add the required `--add-opens` flag to grant access for
> the benchmark.
Nicole Xu has updated the pull request incrementally with two additional
commits since the last revision:
- 8349944: [JMH
On Thu, 13 Feb 2025 08:35:47 GMT, Nicole Xu wrote:
> As is suggested in
> [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958), `jvmArgs` should
> be used consistently in microbenchmarks to 'align with the intuition that
> when you use jvmArgsAppend/-Prepend intent is t
On Thu, 13 Feb 2025 20:04:05 GMT, Chen Liang wrote:
>> As is suggested in
>> [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958), `jvmArgs` should
>> be used consistently in microbenchmarks to 'align with the intuition that
>> when you use jvmArgsAppend/-Prepend intent is to add to a se
On Thu, 13 Feb 2025 08:35:47 GMT, Nicole Xu wrote:
> As is suggested in
> [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958), `jvmArgs` should
> be used consistently in microbenchmarks to 'align with the intuition that
> when you use jvmArgsAppend/-Prepend intent is t
On Wed, 19 Feb 2025 07:53:15 GMT, Nicole Xu wrote:
> The UnsafeOps JMH benchmark fails with the following error:
>
> java.lang.IllegalAccessError: class
> org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot
> access class jdk.internal.misc.Un
The UnsafeOps JMH benchmark fails with the following error:
java.lang.IllegalAccessError: class org.openjdk.bench.sun.misc.UnsafeOps
(in unnamed module @0x520a3426) cannot access class jdk.internal.misc.Unsafe
(in module java.base) because module java.base does not export
jdk.internal.mis
On Wed, 8 Jan 2025 09:04:47 GMT, Nicole Xu wrote:
> Suite MaskedLogicOpts.maskedLogicOperationsLong512() failed on both x86 and
> AArch64 with the following error:
>
>
> java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249
>
>
> The varia
On Thu, 13 Feb 2025 11:51:53 GMT, Jatin Bhateja wrote:
>> Suite MaskedLogicOpts.maskedLogicOperationsLong512() failed on both x86 and
>> AArch64 with the following error:
>>
>>
>> java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249
>>
>>
>> The variable `long256_arr_i
On Thu, 13 Feb 2025 12:09:43 GMT, Jatin Bhateja wrote:
>> test/micro/org/openjdk/bench/jdk/incubator/vector/MaskedLogicOpts.java line
>> 122:
>>
>>> 120: @Setup(Level.Invocation)
>>> 121: public void init_per_invoc() {
>>> 122: int512_arr_idx = (int512_arr_idx + 16) & (ARRAYLEN-
As is suggested in [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958),
`jvmArgs` should be used consistently in microbenchmarks to 'align with the
intuition that when you use jvmArgsAppend/-Prepend intent is to add to a set of
existing flags, while if you supply jvmArgs intent is "run wi
On Tue, 4 Feb 2025 18:55:25 GMT, Emanuel Peter wrote:
>> Suite MaskedLogicOpts.maskedLogicOperationsLong512() failed on both x86 and
>> AArch64 with the following error:
>>
>>
>> java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249
>>
>>
>> The variable `long256_arr_id
On Wed, 8 Jan 2025 09:04:47 GMT, Nicole Xu wrote:
> Suite MaskedLogicOpts.maskedLogicOperationsLong512() failed on both x86 and
> AArch64 with the following error:
>
>
> java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249
>
>
> The varia
On Tue, 4 Feb 2025 18:55:25 GMT, Emanuel Peter wrote:
>> Suite MaskedLogicOpts.maskedLogicOperationsLong512() failed on both x86 and
>> AArch64 with the following error:
>>
>>
>> java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249
>>
>>
>> The variable `long256_arr_id
Suite MaskedLogicOpts.maskedLogicOperationsLong512() failed on both x86 and
AArch64 with the following error:
java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249
The variable `long256_arr_idx` is misused when indexing 'LongVector l2, l3,
l4, l5' in function `maskedLog
On Wed, 8 Jan 2025 09:08:55 GMT, Nicole Xu wrote:
> I am a member of Nvidia Java compiler team.
BTW, Nvidia has signed the OCA recently. Please help to check. Thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/22963#issuecomment-2581667116
On Wed, 8 Jan 2025 09:04:47 GMT, Nicole Xu wrote:
> Suite MaskedLogicOpts.maskedLogicOperationsLong512() failed on both x86 and
> AArch64 with the following error:
>
>
> java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249
>
>
> The varia
27 matches
Mail list logo
