On Thu, 27 Feb 2025 03:22:27 GMT, Nicole Xu <d...@openjdk.org> wrote:
> Would it be possible to configure the build of the microbenchmarks to not > pass `-Werror`, so they don't break when sunapi diagnostics are emitted? > > > Note that even it will raise "proprietary API" warnings after this patch, > > it is acceptable because the relevant APIs are bound for removal for the > > integrity of the platform. > > It will not raise those diagnostics today, because they don't work for this > compilation due to > [JDK-8349846](https://bugs.openjdk.org/browse/JDK-8349846). If that issue is > fixed again it would break the build of these benchmarks, e.g. with > [1ab1c1d](https://github.com/openjdk/jdk/commit/1ab1c1d53b86228be85aac96fa5d69db39ac6317) > backed out and with this change it would fail with: > > ``` > test/micro/org/openjdk/bench/sun/misc/UnsafeOps.java:27: warning: Unsafe is > internal proprietary API and may be removed in a future release > import sun.misc.Unsafe; > ^ > ... > error: warnings found and -Werror specified > ``` I saw the recent patch [`7aeaa3c`](https://github.com/openjdk/jdk/commit/7aeaa3c21c1420191fe8ff59e4cf99eae830754d), which introduced the `--disable-java-warnings-as-errors` configure option. I tried to execute the test compilation with this option offline, and the error you mentioned became warnings. Would this address the issue you raised? @cushon ------------- PR Comment: https://git.openjdk.org/jdk/pull/23686#issuecomment-2792144752
