Re: RFR: 8356443: Update open/test/jdk/TEST.groups manual test groups definitions with missing manual test

2025-05-26 Thread Mahendra Chhipa
On Wed, 21 May 2025 15:37:34 GMT, serhiysachkov wrote: > Update open/test/jdk/TEST.groups manual test groups definitions with missing > manual test LGTM - PR Comment: https://git.openjdk.org/jdk/pull/25360#issuecomment-2910047397

Re: RFR: 8329335: HttpsURLConnectionTest fails due to network firewall rules

2024-06-17 Thread Mahendra Chhipa
On Mon, 17 Jun 2024 09:16:45 GMT, Fernando Guallini wrote: > Since HttpsURLConnectionTest attempts to reach external servers, it can fail > if run on hosts without outbound traffic allowed. Therefore, it should not be > executed in CI pipelines but rather manually on a host with no firewall ru

Integrated: 8319678: Several tests from corelibs areas ignore VM flags

2024-04-11 Thread Mahendra Chhipa
On Wed, 3 Apr 2024 11:47:45 GMT, Mahendra Chhipa wrote: > Updated following tests to use ProcessTools methods: > test/jdk/java/lang/Thread/UncaughtExceptionsTest.java > test/jdk/java/lang/annotation/LoaderLeakTest.java > test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java

Re: RFR: 8319678: Several tests from corelibs areas ignore VM flags [v3]

2024-04-11 Thread Mahendra Chhipa
On Thu, 11 Apr 2024 09:26:27 GMT, Jaikiran Pai wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comments. > > test/jdk/javax/naming/spi/providers/In

Re: RFR: 8319678: Several tests from corelibs areas ignore VM flags [v4]

2024-04-11 Thread Mahendra Chhipa
ConfigTest.java > test/jdk/javax/naming/spi/providers/InitialContextTest.java Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Removed commented code. - Changes: - all: https://git.openjdk.org/jdk/pull/18602/fi

Re: RFR: 8319678: Several tests from corelibs areas ignore VM flags [v3]

2024-04-11 Thread Mahendra Chhipa
ConfigTest.java > test/jdk/javax/naming/spi/providers/InitialContextTest.java Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/1

Re: RFR: 8319678: Several tests from corelibs areas ignore VM flags [v2]

2024-04-11 Thread Mahendra Chhipa
On Wed, 10 Apr 2024 10:57:33 GMT, Jaikiran Pai wrote: >> test/jdk/javax/naming/spi/providers/InitialContextTest.java line 286: >> >>> 284: OutputAnalyzer outputAnalyzer = >>> ProcessTools.executeCommand(commands.toArray(new String[commands.size()])); >>> 285: if(outputAn

Re: RFR: 8319678: Several tests from corelibs areas ignore VM flags [v2]

2024-04-11 Thread Mahendra Chhipa
On Wed, 10 Apr 2024 10:40:55 GMT, Jaikiran Pai wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented review comments. >> Updated EscapePath test. > >

Re: RFR: JDK-8319678: Several tests from corelibs areas ignore VM flags [v2]

2024-04-04 Thread Mahendra Chhipa
On Wed, 3 Apr 2024 20:08:43 GMT, Naoto Sato wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented review comments. >> Updated EscapePath test. > > test/jdk/

Re: RFR: JDK-8319678: Several tests from corelibs areas ignore VM flags [v2]

2024-04-04 Thread Mahendra Chhipa
On Wed, 3 Apr 2024 20:08:04 GMT, Naoto Sato wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented review comments. >> Updated EscapePath test. > > test/jdk/

Re: RFR: JDK-8319678: Several tests from corelibs areas ignore VM flags [v2]

2024-04-04 Thread Mahendra Chhipa
ConfigTest.java > test/jdk/javax/naming/spi/providers/InitialContextTest.java Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented review comments. Updated EscapePath test. - Changes: - all: https://g

RFR: JDK-8319678: Several tests from corelibs areas ignore VM flags

2024-04-03 Thread Mahendra Chhipa
Updated following tests to use ProcessTools methods: test/jdk/java/lang/Thread/UncaughtExceptionsTest.java test/jdk/java/lang/annotation/LoaderLeakTest.java test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java test/jdk/java/time/nontestng/java/time/chrono/HijrahConfigTest.java test/jdk/

Re: RFR: JDK-8311961 Update Manual Test Groups for ATR JDK22

2023-11-07 Thread Mahendra Chhipa
On Mon, 6 Nov 2023 22:25:46 GMT, Bill Huang wrote: > Updated jdk_core_manual test groups. LGTM - PR Comment: https://git.openjdk.org/jdk/pull/16531#issuecomment-1798412093

Integrated: JDK-8077371: Binary files in JAXP test should be removed

2023-10-20 Thread Mahendra Chhipa
On Wed, 19 Apr 2023 15:51:01 GMT, Mahendra Chhipa wrote: > Test is updated to create the binary files during test execution. This pull request has now been integrated. Changeset: 40106422 Author: Mahendra Chhipa URL: https://git.openjdk.org/jdk/com

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v11]

2023-10-19 Thread Mahendra Chhipa
On Wed, 18 Oct 2023 14:55:13 GMT, Roger Riggs wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Corrected use of whitespace in text block. > > test/jdk/j

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v12]

2023-10-19 Thread Mahendra Chhipa
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Added indentation to generate the properly indented code. Revert back to Formatter class from HexFormat cl

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v11]

2023-10-15 Thread Mahendra Chhipa
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Corrected use of whitespace in text block. - Changes: - all: https://git.openjdk.org/jdk/p

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v10]

2023-10-15 Thread Mahendra Chhipa
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with two additional commits since the last revision: - Removed commented code. - Use of HexFormatter clas instead of Formatter. Addition of copyright section

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v9]

2023-10-13 Thread Mahendra Chhipa
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Tests with base64 input are removed. - Changes: - all: https://git.openjdk.org/jdk/pull/13

Re: RFR: JDK-8249832: java/util/zip/DataDescriptorSignatureMissing.java uses @ignore w/o bug-id [v2]

2023-10-13 Thread Mahendra Chhipa
On Thu, 12 Oct 2023 14:18:16 GMT, Agnibho Hom Chowdhury wrote: >> Please review this PR as a fix of >> [JDK-8249832](https://bugs.openjdk.org/browse/JDK-8249832). I have added the >> bug with after @ignore annotation. > > Agnibho Hom Chowdhury has updated the pull request incrementally with on

Re: RFR: JDK-8249832: java/util/zip/DataDescriptorSignatureMissing.java uses @ignore w/o bug-id

2023-10-12 Thread Mahendra Chhipa
On Fri, 6 Oct 2023 12:43:02 GMT, Agnibho Hom Chowdhury wrote: > Please review this PR as a fix of > [JDK-8249832](https://bugs.openjdk.org/browse/JDK-8249832). I have added the > bug with after @ignore annotation. test/jdk/java/util/zip/DataDescriptorSignatureMissing.java line 1: > 1: /* Cou

Re: RFR: JDK-8249832: java/util/zip/DataDescriptorSignatureMissing.java uses @ignore w/o bug-id

2023-10-12 Thread Mahendra Chhipa
On Fri, 6 Oct 2023 12:43:02 GMT, Agnibho Hom Chowdhury wrote: > Please review this PR as a fix of > [JDK-8249832](https://bugs.openjdk.org/browse/JDK-8249832). I have added the > bug with after @ignore annotation. Looks good to me. - PR Comment: https://git.openjdk.org/jdk/pull/1

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v8]

2023-10-09 Thread Mahendra Chhipa
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additio

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v7]

2023-05-10 Thread Mahendra Chhipa
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/13537/fi

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v6]

2023-05-10 Thread Mahendra Chhipa
On Fri, 5 May 2023 21:50:06 GMT, Lance Andersen wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move the pseudo code generation part from setup() to seperate methods. > > te

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v4]

2023-05-03 Thread Mahendra Chhipa
On Tue, 2 May 2023 16:27:25 GMT, Lance Andersen wrote: >> This is added in setup method to create the serialized data with current JDK >> version (JDK under test). In addition to serialized data generated with old >> JDK version. > > Sorry, I still disagree with this. Your comment in the test

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v6]

2023-05-03 Thread Mahendra Chhipa
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Move the pseudo code generation part from setup() to seperate methods. - Changes: - all: ht

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v5]

2023-05-02 Thread Mahendra Chhipa
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: 1. Added JDK version in Data files. 2. Updated copyright year. - Changes: - all: ht

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v4]

2023-05-02 Thread Mahendra Chhipa
On Fri, 28 Apr 2023 18:43:32 GMT, Joe Wang wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comments. > > test/jdk/javax/xml/jaxp/datatype/8033980/Serializ

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v4]

2023-05-02 Thread Mahendra Chhipa
On Sat, 29 Apr 2023 16:15:58 GMT, Lance Andersen wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comments. > > test/jdk/javax/xml/jaxp/datatype/8033980/

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v4]

2023-04-27 Thread Mahendra Chhipa
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/13537/fi

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v3]

2023-04-21 Thread Mahendra Chhipa
On Thu, 20 Apr 2023 10:06:33 GMT, Mahendra Chhipa wrote: >> Test is updated to create the binary files during test execution. > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Implemented the review

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v3]

2023-04-20 Thread Mahendra Chhipa
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comment. - Changes: - all: https://git.openjdk.org/jdk/pull/13537/fi

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v2]

2023-04-19 Thread Mahendra Chhipa
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: closed file handlers. - Changes: - all: https://git.openjdk.org/jdk/pull/13537/files -

RFR: JDK-8077371: Binary files in JAXP test should be removed

2023-04-19 Thread Mahendra Chhipa
Test is updated to create the binary files during test execution. - Commit messages: - JDK-8077371: Binary files in JAXP test should be removed Changes: https://git.openjdk.org/jdk/pull/13537/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13537&range=00 Issue: https://bug

Withdrawn: 8305904: java/lang/Character, java/lang/String and java/text/Normalizer tests read the unicode data files from src directories.

2023-04-14 Thread Mahendra Chhipa
On Wed, 12 Apr 2023 16:35:19 GMT, Mahendra Chhipa wrote: > Following tests read the unicode data files > (http://www.unicode.org/Public/UNIDATA/ ) from src directory. For tests, > these files should be in test directories. No source code is using these > files. Only tests are

Re: RFR: 8305904: java/lang/Character, java/lang/String and java/text/Normalizer tests read the unicode data files from src directories.

2023-04-14 Thread Mahendra Chhipa
On Wed, 12 Apr 2023 16:35:19 GMT, Mahendra Chhipa wrote: > Following tests read the unicode data files > (http://www.unicode.org/Public/UNIDATA/ ) from src directory. For tests, > these files should be in test directories. No source code is using these > files. Only tests are

RFR: 8305904: java/lang/Character, java/lang/String and java/text/Normalizer tests read the unicode data files from src directories.

2023-04-12 Thread Mahendra Chhipa
Following tests read the unicode data files (http://www.unicode.org/Public/UNIDATA/ ) from src directory. For tests, these files should be in test directories. No source code is using these files. Only tests are using these files. Tests are : java/lang/Character/CharPropTest.java java/lang/Chara

Re: RFR: JDK-8295859 Update Manual Test Groups [v2]

2023-03-21 Thread Mahendra Chhipa
On Mon, 20 Mar 2023 23:29:25 GMT, Bill Huang wrote: >> The purpose of this task is to add the difference between -manual jdk_core >> and jdk_core_manual to the jdk_core_manual test goal. Furthermore, in order >> to streamline the manual test execution process, a new test group called >> jdk_co

Re: RFR: JDK-8295859 Update Manual Test Groups

2023-03-16 Thread Mahendra Chhipa
On Thu, 2 Mar 2023 21:34:28 GMT, Bill Huang wrote: > The purpose of this task is to add the difference between -manual jdk_core > and jdk_core_manual to the jdk_core_manual test goal. Furthermore, in order > to streamline the manual test execution process, a new test group called > jdk_core_ma

Re: RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process [v4]

2022-11-25 Thread Mahendra Chhipa
On Sat, 5 Nov 2022 00:04:39 GMT, Bill Huang wrote: >> The current non local registry tests require a manual process that runs >> rmiregitrty on a different machine and changes the -Dregistry.host property >> in the source before running the tests on the local machine. This task is >> created t

Re: RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process [v3]

2022-11-04 Thread Mahendra Chhipa
On Thu, 27 Oct 2022 19:08:06 GMT, Bill Huang wrote: >> The current non local registry tests require a manual process that runs >> rmiregitrty on a different machine and changes the -Dregistry.host property >> in the source before running the tests on the local machine. This task is >> created

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]

2022-10-19 Thread Mahendra Chhipa
On Mon, 17 Oct 2022 16:57:06 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> java/s

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]

2022-10-19 Thread Mahendra Chhipa
On Tue, 18 Oct 2022 22:11:57 GMT, Bill Huang wrote: >> test/jdk/javax/crypto/CryptoPermissions/default_local.policy line 4: >> >>> 2: permission javax.crypto.CryptoAllPermission; >>> 3: permission javax.crypto.CryptoPermission "DES", 64; >>> 4: } >> >> please remove extra line. > > I do

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]

2022-10-18 Thread Mahendra Chhipa
On Mon, 17 Oct 2022 16:57:06 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> java/s

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]

2022-10-18 Thread Mahendra Chhipa
On Mon, 17 Oct 2022 16:57:06 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> java/s

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion

2022-10-14 Thread Mahendra Chhipa
On Mon, 10 Oct 2022 21:39:05 GMT, Bill Huang wrote: > This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java > java/securit

Integrated: JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling

2022-10-12 Thread Mahendra Chhipa
On Tue, 4 Oct 2022 13:01:40 GMT, Mahendra Chhipa wrote: > Added test cases for xpath Axis: > 1. descendant > 2. descendant-or-self > 3. following > 4. following-sibling This pull request has now been integrated. Changeset: 1961e81e Author:Mahendra Chhipa UR

Re: RFR: JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling [v3]

2022-10-11 Thread Mahendra Chhipa
> Added test cases for xpath Axis: > 1. descendant > 2. descendant-or-self > 3. following > 4. following-sibling Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Added predicate tests. - Changes:

Re: RFR: JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling [v2]

2022-10-07 Thread Mahendra Chhipa
> Added test cases for xpath Axis: > 1. descendant > 2. descendant-or-self > 3. following > 4. following-sibling Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - C

Re: RFR: JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling

2022-10-04 Thread Mahendra Chhipa
On Tue, 4 Oct 2022 13:01:40 GMT, Mahendra Chhipa wrote: > Added test cases for xpath Axis: > 1. descendant > 2. descendant-or-self > 3. following > 4. following-sibling Hi @JoeWang-Java , @bwhuang-us , Could you please review this PR. - PR: https://git.openjdk.org/jdk/pull/10557

RFR: JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling

2022-10-04 Thread Mahendra Chhipa
Added test cases for xpath Axis: 1. descendant 2. descendant-or-self 3. following 4. following-sibling - Commit messages: - JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self - JDK-8289509 : Improve test coverage for XPath Axes: descendant, descenda

Integrated: JDK-8289510 : Improve test coverage for XPath Axes: namespace

2022-09-01 Thread Mahendra Chhipa
On Wed, 17 Aug 2022 15:32:49 GMT, Mahendra Chhipa wrote: > Added tests for namespace Axis. Tests incluse namspace expressions, namespace > node counts and namespace node scope. This pull request has now been integrated. Changeset: 3d254d3c Author:Mahendra Chhipa URL:

Re: RFR: JDK-8289510 : Improve test coverage for XPath Axes: namespace [v4]

2022-09-01 Thread Mahendra Chhipa
> Added tests for namespace Axis. Tests incluse namspace expressions, namespace > node counts and namespace node scope. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - C

Re: RFR: JDK-8289510 : Improve test coverage for XPath Axes: namespace [v3]

2022-08-31 Thread Mahendra Chhipa
> Added tests for namespace Axis. Tests incluse namspace expressions, namespace > node counts and namespace node scope. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Added defaukt namsespace expressions. - C

Re: RFR: JDK-8289510 : Improve test coverage for XPath Axes: namespace [v2]

2022-08-25 Thread Mahendra Chhipa
> Added tests for namespace Axis. Tests incluse namspace expressions, namespace > node counts and namespace node scope. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - C

Re: RFR: JDK-8289510 : Improve test coverage for XPath Axes: namespace

2022-08-17 Thread Mahendra Chhipa
On Wed, 17 Aug 2022 15:32:49 GMT, Mahendra Chhipa wrote: > Added tests for namespace Axis. Tests incluse namspace expressions, namespace > node counts and namespace node scope. Hi @JoeWang-Java , Could you please review this PR. - PR: https://git.openjdk.org/jdk/pull/9906

RFR: JDK-8289510 : Improve test coverage for XPath Axes: namespace

2022-08-17 Thread Mahendra Chhipa
Added tests for namespace Axis. Tests incluse namspace expressions, namespace node counts and namespace node scope. - Commit messages: - JDK-8289510 : Improve test coverage for XPath Axes: namespace Changes: https://git.openjdk.org/jdk/pull/9906/files Webrev: https://webrevs.openj