On Fri, 5 May 2023 21:50:06 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move the pseudo code generation part from setup() to seperate methods. > > test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 232: > >> 230: * JDK<version>GregorianCalendarAndDurationSerData.java files. >> 231: * @param baos >> 232: */ > > I think there needs to be a general comment describing how these methods are > used to create the JDK<version>GregorianCalendarAndDurationSerData.java > files. There should also be a description/comment for the methods defined in > GregorianCalendarAndDurationSerData.java > > We need to try and put ourselves in the place of a future maintainer who > needs to understand how to create a version of one of these files. > > You could probably also create a method which generates a > JDK<version>GregorianCalendarAndDurationSerData.java file to save the > developer from multiple cut an pastes. > > At a minimum, there really should be a step by step guide How these methods can be used, added comment regarding this under setup method. Added description for the methods defined in GregorianCalendarAndDurationSerData.java file. Now developer should be able to create the <JDK version >GregorianCalendarAndDurationSerData.java file after reading these comments. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13537#discussion_r1190014838
