Re: RFR: 8342283: CDS cannot handle a large number of classes

2025-04-25 Thread Leonid Mesnik
On Fri, 25 Apr 2025 14:49:37 GMT, Aleksey Shipilev wrote: > CDS cannot handle large number of classes, because `ClassLoader` data > structures get too large for CDS archival. The new test captures such an > occasion. We do `clear()`-s, but that is not enough to trim the backing > storages for

Integrated: 8353214: Add testing with --enable-preview

2025-04-23 Thread Leonid Mesnik
On Thu, 17 Apr 2025 00:24:50 GMT, Leonid Mesnik wrote: > Added problemlists and and requires for execution tests with --enable-preview. > > The --enable-preview features might significantly change VM/JDK behavior and > sometimes it is useful to run tests with preview feat

Re: RFR: 8353214: Add testing with --enable-preview

2025-04-17 Thread Leonid Mesnik
On Thu, 17 Apr 2025 00:24:50 GMT, Leonid Mesnik wrote: > Added problemlists and and requires for execution tests with --enable-preview. > > The --enable-preview features might significantly change VM/JDK behavior and > sometimes it is useful to run tests with preview feat

RFR: 8353214: Add testing with --enable-preview

2025-04-16 Thread Leonid Mesnik
Added problemlists and and requires for execution tests with --enable-preview. The --enable-preview features might significantly change VM/JDK behavior and sometimes it is useful to run tests with preview features enabled. Eventually preview features should be made default and it is expected tha

Re: RFR: 8352565: Add native method implementation of Reference.get() [v4]

2025-04-03 Thread Leonid Mesnik
On Wed, 2 Apr 2025 18:33:16 GMT, Kim Barrett wrote: >> Please review this change which adds a native method providing the >> implementation of Reference::get. Referece::get is an intrinsic candidate, >> so >> this native method implementation is only used when the intrinsic is not. >> >> Curre

Re: RFR: 8352107: Allow jtreg test cases to query test VM properties

2025-03-18 Thread Leonid Mesnik
On Sun, 16 Mar 2025 02:54:36 GMT, Ioi Lam wrote: > This PR tries to cut down the use of `WhiteBox` in the HotSpot test cases. It > modifies `VMProps` to save the set of VM properties into a file called > "vm.properties" under Jtreg's work directory. The new API > `jdk.test.lib.VMPropsGetter` l

Integrated: 8350151: Support requires property to filter tests incompatible with --enable-preview

2025-02-20 Thread Leonid Mesnik
On Sat, 15 Feb 2025 19:43:39 GMT, Leonid Mesnik wrote: > It might be useful to be able to run testing with --enable-preview for > feature development. The tests incompatible with this mode must be filtered > out. > > I chose name 'java.enablePreview' , because it is m

Re: RFR: 8350151: Support requires property to filter tests incompatible with --enable-preview [v2]

2025-02-19 Thread Leonid Mesnik
On Wed, 19 Feb 2025 19:36:59 GMT, Roger Riggs wrote: >> Ough, this test puzzled me. It fails with --enable-preview. However, I think >> I need more time to investigate the issue. So I update PR to exclude test >> that explicitly says that it shouldn't be executed with --enable-preview. > > It r

Re: RFR: 8350151: Support requires property to filter tests incompatible with --enable-preview [v2]

2025-02-19 Thread Leonid Mesnik
On Mon, 17 Feb 2025 08:28:05 GMT, Alan Bateman wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> change other test to exclude > > test/jdk/java/lang/System/SecurityManagerWarnings.j

Re: RFR: 8350151: Support requires property to filter tests incompatible with --enable-preview [v2]

2025-02-19 Thread Leonid Mesnik
Preview' to be similar with jtreg tag. > > Tested by running all test suites, and verifying that test is correctly > selected. > There are more tests incompatible with --enable-preview, will mark them in > the following bug. Leonid Mesnik has updated the pull request inc

RFR: 8350151: Support requires property to filer tests incompatible with --enable-preview

2025-02-15 Thread Leonid Mesnik
It might be useful to be able to run testing with --enable-preview for feature development. The tests incompatible with this mode must be filtered out. I chose name 'java.enablePreview' , because it is more java property than vm or jdk. And 'enablePreview' to be similar with jtreg tag. Tested

Re: RFR: 8349689: Several virtual thread tests missing /native keyword [v5]

2025-02-11 Thread Leonid Mesnik
On Tue, 11 Feb 2025 09:03:24 GMT, SendaoYan wrote: >> H all, >> >> This PR add `/native` keyword in the test header for virtual thread tests. >> The `/native` keyword will make run the related tests by jtreg standalone >> more friendly. >> >> I runed all the tests without -nativepath argument

RFR: 8318098: Update jfr tests to replace keyword jfr with vm.flagless

2025-01-23 Thread Leonid Mesnik
A lot of jfr tests are very specific. Currently all of them are marked with jfr keyword and excluded when VM flags are set. It makes sense to mark them with @requires to be complaint with all other openjdk tests. The next step is to review tests and remove vm.flagless from tests that should b

Integrated: 8338428: Add logging of final VM flags while setting properties

2025-01-21 Thread Leonid Mesnik
On Sun, 12 Jan 2025 06:08:02 GMT, Leonid Mesnik wrote: > Some VM flags might depend on the environment and it makes sense to log final > flags so it is possible to get their value when investigating failures. > > I added them to VMProps, so it is always dump final flags before runn

Re: RFR: 8338428: Add logging if final VM flags while setting properties [v6]

2025-01-17 Thread Leonid Mesnik
On Fri, 17 Jan 2025 18:50:22 GMT, Leonid Mesnik wrote: >> Some VM flags might depend on the environment and it makes sense to log >> final flags so it is possible to get their value when investigating failures. >> >> I added them to VMProps, so it is always dump fi

Re: RFR: 8338428: Add logging if final VM flags while setting properties [v5]

2025-01-17 Thread Leonid Mesnik
On Fri, 17 Jan 2025 17:27:32 GMT, Roger Riggs wrote: > This seems like overkill for a weak use case. > > The resulting log file is in the scratch directory so it will not be retained > for long. In local builds, whoever is running the test could add the > arguments. Thanks for your feedback.

Re: RFR: 8338428: Add logging if final VM flags while setting properties [v6]

2025-01-17 Thread Leonid Mesnik
> > Update: > There were intermittent compilation failures when I tried to use classes from > testlibrary, so I rewrtite the code without them. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: updated flags -

Re: RFR: 8338428: Add logging if final VM flags while setting properties [v5]

2025-01-17 Thread Leonid Mesnik
> > Update: > There were intermittent compilation failures when I tried to use classes from > testlibrary, so I rewrtite the code without them. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: copyrights updated -

Integrated: 8347840: Fix testlibrary compilation warnings

2025-01-17 Thread Leonid Mesnik
On Wed, 15 Jan 2025 23:48:33 GMT, Leonid Mesnik wrote: > There few compiler warning disabled in the testlibary build. > They should be fixed or localized and removed from build to prevent new > possible issues. > > The main goal is to avoid new such issues in the testlibrary.

Re: RFR: 8347840: Fix testlibrary compilation warnings [v3]

2025-01-16 Thread Leonid Mesnik
On Thu, 16 Jan 2025 18:14:39 GMT, Leonid Mesnik wrote: >> There few compiler warning disabled in the testlibary build. >> They should be fixed or localized and removed from build to prevent new >> possible issues. >> >> The main goal is to avoid new such issues

Re: RFR: 8347840: Fix testlibrary compilation warnings [v3]

2025-01-16 Thread Leonid Mesnik
On Thu, 16 Jan 2025 07:09:46 GMT, Alan Bateman wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> revert change > > test/lib/jdk/test/lib/thread/VThreadPinner.java line 97: > >

Re: RFR: 8347840: Fix testlibrary compilation warnings [v3]

2025-01-16 Thread Leonid Mesnik
On Thu, 16 Jan 2025 05:31:44 GMT, David Holmes wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> revert change > > test/lib/jdk/test/lib/format/ArrayDiff.java line 110: > &g

Re: RFR: 8347840: Fix testlibrary compilation warnings [v3]

2025-01-16 Thread Leonid Mesnik
> There few compiler warning disabled in the testlibary build. > They should be fixed or localized and removed from build to prevent new > possible issues. > > The main goal is to avoid new such issues in the testlibrary. > Tested with tier1-5 to ensure that all tests we

Re: RFR: 8347840: Fix testlibrary compilation warnings [v2]

2025-01-16 Thread Leonid Mesnik
> There few compiler warning disabled in the testlibary build. > They should be fixed or localized and removed from build to prevent new > possible issues. > > The main goal is to avoid new such issues in the testlibrary. > Tested with tier1-5 to ensure that all tests we

RFR: 8347840: Fix testlibrary compilation warnings

2025-01-15 Thread Leonid Mesnik
There few compiler warning disabled in the testlibary build. They should be fixed or localized and removed from build to prevent new possible issues. The main goal is to avoid new such issues in the testlibrary. Tested with tier1-5 to ensure that all tests were passed. - Commit mes

Re: RFR: 8346986: Remove ASM from java.base [v8]

2025-01-13 Thread Leonid Mesnik
On Mon, 13 Jan 2025 08:14:08 GMT, Adam Sotona wrote: >> There are no more consumers of ASM library except for hotspot tests. >> This patch moves ASM library from java.base module to the hotspot test >> libraries location and fixes the tests. >> >> Please review. >> >> Thanks, >> Adam > > Adam

Integrated: 8347302: Mark test tools/jimage/JImageToolTest.java as flagless

2025-01-10 Thread Leonid Mesnik
On Thu, 9 Jan 2025 00:05:30 GMT, Leonid Mesnik wrote: > Test > test/jdk/tools/jimage/JImageToolTest.java > ignore vm flags and should be marked as flagless. > > It is needed to don't try to run this test with virtual test thread factory. This pull request has now been in

Re: RFR: 8346986: Remove ASM from java.base [v3]

2025-01-09 Thread Leonid Mesnik
On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona wrote: >> There are no more consumers of ASM library except for hotspot tests. >> This patch moves ASM library from java.base module to the hotspot test >> libraries location and fixes the tests. >> >> Please review. >> >> Thanks, >> Adam > > Adam S

Withdrawn: 8347302: Update ProcessTools.java to support virtual test factory for Xbootclasspath/a:

2025-01-08 Thread Leonid Mesnik
On Thu, 9 Jan 2025 00:12:29 GMT, Leonid Mesnik wrote: > Test > runtime/cds/appcds/jigsaw/modulepath/OptimizeModuleHandlingTest.java > uses > -Xbootclasspath/a: classpath > (2 arguments) > > Such usage of options -Xbootclasspath/a: should be correctly processed by >

RFR: 8347302: Update ProcessTools.java to support virtual test factory for Xbootclasspath/a:

2025-01-08 Thread Leonid Mesnik
Test runtime/cds/appcds/jigsaw/modulepath/OptimizeModuleHandlingTest.java uses -Xbootclasspath/a: classpath (2 arguments) Such usage of options -Xbootclasspath/a: should be correctly processed by virtual thread factory support in ProcessTools. - Commit messages: - 8347304: Update P

RFR: 8347302: Mark test tools/jimage/JImageToolTest.java as flagless

2025-01-08 Thread Leonid Mesnik
Test test/jdk/tools/jimage/JImageToolTest.java ignore vm flags and should be marked as flagless. It is needed to don't try to run this test with virtual test thread factory. - Commit messages: - 8347302 Changes: https://git.openjdk.org/jdk/pull/22992/files Webrev: https://webrevs

Re: RFR: 8346986: Remove ASM from java.base

2025-01-07 Thread Leonid Mesnik
On Tue, 7 Jan 2025 12:49:40 GMT, Adam Sotona wrote: > There are no more consumers of ASM library except for hotspot tests. > This patch moves ASM library from java.base module to the hotspot test > libraries location and fixes the tests. > > Please review. > > Thanks, > Adam so you if add asm

Re: RFR: 8346986: Remove ASM from java.base

2025-01-07 Thread Leonid Mesnik
On Tue, 7 Jan 2025 12:49:40 GMT, Adam Sotona wrote: > There are no more consumers of ASM library except for hotspot tests. > This patch moves ASM library from java.base module to the hotspot test > libraries location and fixes the tests. > > Please review. > > Thanks, > Adam I think it is mak

Re: RFR: 8346773: Fix unmatched brackets in source files [v2]

2024-12-24 Thread Leonid Mesnik
On Tue, 24 Dec 2024 22:22:28 GMT, Kim Barrett wrote: >> Only this small piece would be appropriate for backport to 24. I suggest >> splitting this out into its own bug, >> fixing it in isolation, and backporting that. > > The purpose of this Makefile seems to be to build ctw.jar. So far as I ca

Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods

2024-10-07 Thread Leonid Mesnik
On Mon, 7 Oct 2024 22:03:36 GMT, Serguei Spitsyn wrote: > This fixes a problem in the VTMS (Virtual Thread Mount State) transition > frames hiding mechanism. > Please, see a fix description in the first comment. > > Testing: > - Verified with new test `vthread/CheckHiddenFrames` > - Mach5 tie

RFR: 8340415: Update failure handler to print more info using gdb scripts

2024-09-18 Thread Leonid Mesnik
The failure handler updated to use gdb scripts. The initial version print some information about mutextes, safepoint and threads state. So the deadlocks are easier to analyze without opening core files. The existing gdb processing is not changed. Later the script might be improved with more inf

Re: RFR: 8340176: Replace usage of -noclassgc with -Xnoclassgc in test/jdk/java/lang/management/MemoryMXBean/LowMemoryTest2.java

2024-09-16 Thread Leonid Mesnik
On Mon, 16 Sep 2024 09:21:22 GMT, Jaikiran Pai wrote: > Can I please get a review of this test-only change which replaces the usage > of `-noclassgc` with `-Xnoclassgc` option when launching the test? > > As noted in https://bugs.openjdk.org/browse/JDK-8340176, the `-noclassgc` is > an undocum

Re: RFR: 8334771: [TESTBUG] Run TestDockerMemoryMetrics.java with -Xcomp fails exitValue = 137

2024-07-17 Thread Leonid Mesnik
On Mon, 24 Jun 2024 16:16:29 GMT, SendaoYan wrote: > Hi all, > After [JDK-8294960](https://bugs.openjdk.org/browse/JDK-8294960), the > footprint memory usage increased significantly when run the testcase with > -Xcomp jvm options, then cause the testcase was killed by docker by OOM. > Maybe

Integrated: 8330702: Update failure handler to don't generate Error message if cores actions are empty

2024-06-14 Thread Leonid Mesnik
On Thu, 30 May 2024 02:28:56 GMT, Leonid Mesnik wrote: > The message is generated if cores (or any other tools) section doesn't exist > or is empty. However, there is no any tool for cores processing now defined. > So ERROR message is generating, confusing users. > The fix

Re: RFR: 8303133: Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed.

2024-06-05 Thread Leonid Mesnik
On Fri, 24 Feb 2023 22:15:18 GMT, Leonid Mesnik wrote: > The solution proposed by Stefan K > > The startProcess() might wait forever for the expected line if the process > exits (failed to start). It makes sense to just fail earlier in such cases. > > The fix also mo

RFR: 8330702: Update failure handler to don't generate Error message if cores actions are empty.

2024-05-29 Thread Leonid Mesnik
The message is generated if cores (or any other tools) section doesn't exist or is empty. However, there is no any tool for cores processing now defined. So ERROR message is generating, confusing users. The fix is to don't print error for empty toolset which is the valid case. The message is sti

Re: RFR: 8332898: failure_handler: log directory of commands

2024-05-24 Thread Leonid Mesnik
On Fri, 24 May 2024 14:34:39 GMT, Ludvig Janiuk wrote: > Also log the directory in which the command used by failure_handler was > executed. While often the same, it isn't always, and so it this should > simplify troubleshooting for someone looking at this at a glance without > being a failure

Re: RFR: 8332885: Clarify failure_handler self-tests

2024-05-24 Thread Leonid Mesnik
On Fri, 24 May 2024 12:16:25 GMT, Ludvig Janiuk wrote: > Adding commetns to clarify that the failure_handler selftests are intended to > be run manually. Ideally this would include a more thorough description of > the exepcted outputs, but this is what I have time to add right now. Marked as r

Re: RFR: 8324799: Use correct extension for C++ test headers

2024-02-28 Thread Leonid Mesnik
On Wed, 28 Feb 2024 01:18:50 GMT, Kim Barrett wrote: > Please review this change that renames some test .h files to .hpp. These > files contain C++ code and should be named accordingly. Some of them contain > uses of NULL, which we change to nullptr. > > The renamed files are: > > test/hotspo

RFR: 8316451: 6 java/lang/instrument/PremainClass tests ignore VM flags

2024-02-08 Thread Leonid Mesnik
Tests updated to use jtreg vm flags. Tested by running tests with different flags and tier1. - Commit messages: - 8316451 Changes: https://git.openjdk.org/jdk/pull/17781/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17781&range=00 Issue: https://bugs.openjdk.org/browse/J

RFR: 8319578: Few java/lang/instrument ignore test.java.opts and accept test.vm.opts only

2024-02-08 Thread Leonid Mesnik
There are several .sh tests which use ${TESTVMOPTS} only. Updated them to use ${TESTJAVAOPTS} also. Tested by running them with different options and tier1. - Commit messages: - 8319578: Few java/lang/instrument ignore test.java.opts and accept test.vm.opts only Changes: https:

Re: RFR: 8323717: Introduce test keyword for tests that need external dependencies

2024-01-25 Thread Leonid Mesnik
On Wed, 24 Jan 2024 21:28:29 GMT, Leonid Mesnik wrote: >> Some jtreg tests require resolvable external dependencies. This resolution >> is delegated to JIB, which is not used in vanilla OpenJDK testing. It would >> be convenient to add a keyword that marks tests that requ

Re: RFR: 8323717: Introduce test keyword for tests that need external dependencies

2024-01-24 Thread Leonid Mesnik
On Mon, 15 Jan 2024 10:48:23 GMT, Aleksey Shipilev wrote: > Some jtreg tests require resolvable external dependencies. This resolution is > delegated to JIB, which is not used in vanilla OpenJDK testing. It would be > convenient to add a keyword that marks tests that require these external > d

Re: RFR: 8323515: Create test alias "all" for all test roots [v3]

2024-01-23 Thread Leonid Mesnik
On Tue, 16 Jan 2024 09:01:35 GMT, Aleksey Shipilev wrote: >> Since recent work to improve `tier4` performance, we actually test >> `tier{1,2,3,4}` often, which includes all the tests in current tree. It >> would be more convenient to just have the `all` test group/alias, so that we >> can do `

Re: RFR: 8320699: Add parameter to skip progress logging of OutputAnalyzer [v3]

2024-01-12 Thread Leonid Mesnik
On Fri, 5 Jan 2024 09:07:57 GMT, Stefan Karlsson wrote: >> Tests using ProcessTools.executeProcess gets the following output written to >> stdout: >> [2023-11-24T09:58:16.797540608Z] Gathering output for process 2517117 >> [2023-11-24T09:58:23.070781345Z] Waiting for completion for process 25171

Re: RFR: 8320699: Add parameter to skip progress logging of OutputAnalyzer [v3]

2024-01-11 Thread Leonid Mesnik
On Fri, 5 Jan 2024 09:07:57 GMT, Stefan Karlsson wrote: >> Tests using ProcessTools.executeProcess gets the following output written to >> stdout: >> [2023-11-24T09:58:16.797540608Z] Gathering output for process 2517117 >> [2023-11-24T09:58:23.070781345Z] Waiting for completion for process 25171

Re: RFR: 8322920: Some ProcessTools.execute* functions are declared to throw Throwable

2024-01-04 Thread Leonid Mesnik
On Wed, 3 Jan 2024 09:51:24 GMT, Stefan Karlsson wrote: > Most functions in ProcessTools are declared to throw Exceptions, or one of > its subclasses. However, there are a small number of functions that are > unnecessarily declared to throw Throwable instead of Exception. I propose > that we c

Re: RFR: 8311218: fatal error: stuck in JvmtiVTMSTransitionDisabler::VTMS_transition_disable [v7]

2023-12-17 Thread Leonid Mesnik
On Fri, 15 Dec 2023 10:49:56 GMT, Serguei Spitsyn wrote: >> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1 >> time frame. >> It is fixing a deadlock issue between `VirtualThread` class critical >> sections with the `interruptLock` (in methods: `unpark()`, `interrupt(

Re: RFR: 8311218: fatal error: stuck in JvmtiVTMSTransitionDisabler::VTMS_transition_disable [v3]

2023-12-12 Thread Leonid Mesnik
On Fri, 8 Dec 2023 11:54:40 GMT, Serguei Spitsyn wrote: >> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1 >> time frame. >> It is fixing a deadlock issue between `VirtualThread` class critical >> sections with the `interruptLock` (in methods: `unpark()`, `interrupt()

Re: RFR: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder [v3]

2023-12-12 Thread Leonid Mesnik
On Mon, 11 Dec 2023 14:06:43 GMT, Stefan Karlsson wrote: >> [JDK-8315097](https://bugs.openjdk.org/browse/JDK-8315097): 'Rename >> createJavaProcessBuilder' changed the name of the ProcessTools helper >> functions used to create `ProcessBuilder`s used to spawn new java test >> processes. >> >

Re: RFR: 8319647: Update or mark as vm.flagless tests that ignore external VM flags

2023-12-04 Thread Leonid Mesnik
On Mon, 4 Dec 2023 10:39:05 GMT, Darragh Clarke wrote: > Updated tests to use vm.flagless as they already ignore Vm flags Marked as reviewed by lmesnik (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16946#pullrequestreview-1763304819

Integrated: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX

2023-12-01 Thread Leonid Mesnik
On Fri, 1 Dec 2023 00:58:57 GMT, Leonid Mesnik wrote: > Description of problem and propsed fix from @plummercj > ' > In test/failure_handler/src/share/conf/mac.properties we have: > > process.top.app=top > process.top.args=-l 1 > > So top is run with the &quo

Re: RFR: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed [v3]

2023-12-01 Thread Leonid Mesnik
On Fri, 1 Dec 2023 12:44:17 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change to the test library's >> `OutputAnalyzer` class, which proposes to remove some unnecessary logging >> from the `getExitValue()` call? >> >> As noted in https://bugs.openjdk.org/browse/JDK-8321163,

Re: RFR: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX

2023-12-01 Thread Leonid Mesnik
On Fri, 1 Dec 2023 00:58:57 GMT, Leonid Mesnik wrote: > Description of problem and propsed fix from @plummercj > ' > In test/failure_handler/src/share/conf/mac.properties we have: > > process.top.app=top > process.top.args=-l 1 > > So top is run with the &quo

RFR: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX

2023-11-30 Thread Leonid Mesnik
Description of problem and propsed fix from @plummercj ' In test/failure_handler/src/share/conf/mac.properties we have: process.top.app=top process.top.args=-l 1 So top is run with the "-l 1" args, causing it to do one iteration and then exit. Unfortunately the first iteration always shows all

Re: RFR: 8319567: Update java/lang/invoke tests to support vm flags [v3]

2023-11-16 Thread Leonid Mesnik
On Thu, 16 Nov 2023 18:20:04 GMT, Mandy Chung wrote: >> This PR includes test fixes for the following issues: >> >> 8319567: Update java/lang/invoke tests to support vm flags >> 8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java >> to accept vm flags >> 8319672: Several

Re: RFR: 8319567: Update java/lang/invoke tests to support vm flags [v2]

2023-11-16 Thread Leonid Mesnik
On Wed, 15 Nov 2023 02:39:56 GMT, Mandy Chung wrote: >> This PR includes test fixes for the following issues: >> >> 8319567: Update java/lang/invoke tests to support vm flags >> 8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java >> to accept vm flags >> 8319672: Several

Re: RFR: 8319200: Don't use test thread factory in ProcessTools.createLimitedTestJavaProcessBuilder() [v5]

2023-11-15 Thread Leonid Mesnik
On Fri, 10 Nov 2023 01:49:17 GMT, Leonid Mesnik wrote: >> Test thread factory is a mode similar to VM flags and should not be used in >> ProcessTools.createLimitedTestJavaProcessBuilder(). Only >> createTestJavaProcessBuilder() should use it like jtreg VM options. >> &

Re: RFR: 8319572: Test jdk/incubator/vector/LoadJsvmlTest.java ignores VM flags

2023-11-14 Thread Leonid Mesnik
On Thu, 9 Nov 2023 22:08:06 GMT, Sandhya Viswanathan wrote: > Test jdk/incubator/vector/LoadJsvmlTest.java ignores VM flags and thus marked > as flagless through @requires vm.flagless per > [JDK-8319566](https://bugs.openjdk.org/browse/JDK-8319566). Marked as reviewed by lmesnik (Reviewer).

Re: RFR: 8319200: Don't use test thread factory in ProcessTools.createLimitedTestJavaProcessBuilder() [v5]

2023-11-09 Thread Leonid Mesnik
On Fri, 10 Nov 2023 01:49:17 GMT, Leonid Mesnik wrote: >> Test thread factory is a mode similar to VM flags and should not be used in >> ProcessTools.createLimitedTestJavaProcessBuilder(). Only >> createTestJavaProcessBuilder() should use it like jtreg VM options. >> &

Re: RFR: 8319200: Don't use test thread factory in ProcessTools.createLimitedTestJavaProcessBuilder() [v5]

2023-11-09 Thread Leonid Mesnik
n the > middle of the list. I don't think it makes sense to modify arguments in > several places so I replaced it with the flag isLimited and moved all > modifications in createJavaProcessBuilder(). > > Testing tier1-5. Leonid Mesnik has updated the pull request incrementall

Re: RFR: 8319200: Don't use test thread factory in ProcessTools.createLimitedTestJavaProcessBuilder() [v3]

2023-11-08 Thread Leonid Mesnik
On Wed, 8 Nov 2023 19:02:36 GMT, Mark Sheppard wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> converted list to array. > > test/lib/jdk/test/lib/process/ProcessTools.java line

Re: RFR: 8319200: Don't use test thread factory in ProcessTools.createLimitedTestJavaProcessBuilder() [v4]

2023-11-08 Thread Leonid Mesnik
n the > middle of the list. I don't think it makes sense to modify arguments in > several places so I replaced it with the flag isLimited and moved all > modifications in createJavaProcessBuilder(). > > Testing tier1-5. Leonid Mesnik has updated the pull request incrementall

Re: RFR: 8319200: Don't use test thread factory in ProcessTools.createLimitedTestJavaProcessBuilder() [v3]

2023-11-07 Thread Leonid Mesnik
On Wed, 8 Nov 2023 02:33:29 GMT, Leonid Mesnik wrote: >> Test thread factory is a mode similar to VM flags and should not be used in >> ProcessTools.createLimitedTestJavaProcessBuilder(). Only >> createTestJavaProcessBuilder() should use it like jtreg VM options. >> &

Re: RFR: 8319200: Don't use test thread factory in ProcessTools.createLimitedTestJavaProcessBuilder() [v3]

2023-11-07 Thread Leonid Mesnik
n the > middle of the list. I don't think it makes sense to modify arguments in > several places so I replaced it with the flag isLimited and moved all > modifications in createJavaProcessBuilder(). > > Testing tier1-5. Leonid Mesnik has updated the pull request incrementall

Re: RFR: 8319200: Don't use test thread factory in ProcessTools.createLimitedTestJavaProcessBuilder() [v2]

2023-11-07 Thread Leonid Mesnik
n the > middle of the list. I don't think it makes sense to modify arguments in > several places so I replaced it with the flag isLimited and moved all > modifications in createJavaProcessBuilder(). > > Testing tier1-5. Leonid Mesnik has updated the pull request with a n

Withdrawn: 8318839: Update test thread factory to catch all exceptions

2023-11-03 Thread Leonid Mesnik
On Wed, 25 Oct 2023 21:08:01 GMT, Leonid Mesnik wrote: > The jtreg starts the main thread in a separate ThreadGroup and checks > unhandled exceptions for this group. However, it doesn't catch all unhandled > exceptions. There is a jtreg issue for this > https://bugs.o

Re: RFR: 8318839: Update test thread factory to catch all exceptions [v2]

2023-11-03 Thread Leonid Mesnik
On Fri, 3 Nov 2023 03:44:31 GMT, Leonid Mesnik wrote: >> The jtreg starts the main thread in a separate ThreadGroup and checks >> unhandled exceptions for this group. However, it doesn't catch all unhandled >> exceptions. There is a jtreg issue for this >> ht

Re: RFR: 8318839: Update test thread factory to catch all exceptions [v2]

2023-11-02 Thread Leonid Mesnik
On Fri, 3 Nov 2023 03:44:31 GMT, Leonid Mesnik wrote: >> The jtreg starts the main thread in a separate ThreadGroup and checks >> unhandled exceptions for this group. However, it doesn't catch all unhandled >> exceptions. There is a jtreg issue for this >> ht

Re: RFR: 8318839: Update test thread factory to catch all exceptions [v2]

2023-11-02 Thread Leonid Mesnik
st > test/jdk/java/util/concurrent/tck/ThreadTest.java is updated to not check the > default empty handler. > > Probably, we need some common approach about dealing with the > UncaughtExceptionHandler in jtreg. Leonid Mesnik has updated the pull request incrementally with

RFR: 8319200: Don't use test thread factory in ProcessTools.createLimitedTestJavaProcessBuilder()

2023-10-31 Thread Leonid Mesnik
Test thread factory is a mode similar to VM flags and should not be used in ProcessTools.createLimitedTestJavaProcessBuilder(). Only createTestJavaProcessBuilder() should use it like jtreg VM options. Adding the test thread factory requires the injection of arguments in the middle of the list.

Re: RFR: 8319153: Fix: Class is a raw type in ProcessTools

2023-10-31 Thread Leonid Mesnik
On Tue, 31 Oct 2023 07:43:43 GMT, Leo Korinth wrote: > Changing from `Class c` to `Class c` removes two warnings. Marked as reviewed by lmesnik (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16431#pullrequestreview-1707376126

Re: RFR: 8318839: Update test thread factory to catch all exceptions

2023-10-30 Thread Leonid Mesnik
On Sun, 29 Oct 2023 14:10:32 GMT, Jaikiran Pai wrote: >> The jtreg starts the main thread in a separate ThreadGroup and checks >> unhandled exceptions for this group. However, it doesn't catch all unhandled >> exceptions. There is a jtreg issue for this >> https://bugs.openjdk.org/browse/CODET

Re: RFR: 8318839: Update test thread factory to catch all exceptions

2023-10-27 Thread Leonid Mesnik
On Fri, 27 Oct 2023 05:55:43 GMT, David Holmes wrote: >> It is still used in tests and we should ignore it like jtreg doing. > > Shouldn't this code first retrieve the current default exception handler, and > then check whether t is a virtual thread, and if so handle the exception as > appropri

Re: RFR: 8318839: Update test thread factory to catch all exceptions

2023-10-26 Thread Leonid Mesnik
On Thu, 26 Oct 2023 08:34:39 GMT, Alan Bateman wrote: > Having a UHE invoke System.exit is surprising. Are you saying that this is > only for cases where a test launches a child VM with the thread factory set? It is for cases when the test is started in a virtual thread. I don't see a better w

Re: RFR: 8318839: Update test thread factory to catch all exceptions

2023-10-26 Thread Leonid Mesnik
On Thu, 26 Oct 2023 08:34:39 GMT, Alan Bateman wrote: > Stepping back a bit. ThreadGroup is legacy and we eventually want it to go > away. We've been deprecating and degrading it very slowly over many releases. > So I think jtreg will eventually need to change. Right now, it creates > AgentVMT

Re: RFR: 8318839: Update test thread factory to catch all exceptions

2023-10-26 Thread Leonid Mesnik
On Wed, 25 Oct 2023 21:08:01 GMT, Leonid Mesnik wrote: > The jtreg starts the main thread in a separate ThreadGroup and checks > unhandled exceptions for this group. However, it doesn't catch all unhandled > exceptions. There is a jtreg issue for this > https://bugs.o

Re: RFR: 8318839: Update test thread factory to catch all exceptions

2023-10-26 Thread Leonid Mesnik
On Thu, 26 Oct 2023 06:09:34 GMT, Jaikiran Pai wrote: >> The jtreg starts the main thread in a separate ThreadGroup and checks >> unhandled exceptions for this group. However, it doesn't catch all unhandled >> exceptions. There is a jtreg issue for this >> https://bugs.openjdk.org/browse/CODET

RFR: 8318839: Update test thread factory to catch all exceptions

2023-10-25 Thread Leonid Mesnik
The jtreg starts the main thread in a separate ThreadGroup and checks unhandled exceptions for this group. However, it doesn't catch all unhandled exceptions. There is a jtreg issue for this https://bugs.openjdk.org/browse/CODETOOLS-7903526. Catching such issues for virtual threads is important

Re: RFR: 8315097: Rename createJavaProcessBuilder [v6]

2023-10-24 Thread Leonid Mesnik
On Tue, 24 Oct 2023 07:49:30 GMT, Leo Korinth wrote: >> This pull request renames `createJavaProcessBuilder` to >> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to >> `createTestJavaProcessBuilder`. Both are implemented through a private >> `createJavaProcessBuilder`. It al

RFR: 8316452: java/lang/instrument/modules/AppendToClassPathModuleTest.java ignores VM flags

2023-10-06 Thread Leonid Mesnik
The test uses specific classpath, and jar and is intended to test modules. So I marked is as flagless, - Commit messages: - 8316452 Changes: https://git.openjdk.org/jdk/pull/16080/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16080&range=00 Issue: https://bugs.openjdk.o

RFR: 8316464: 3 sun/tools tests ignore VM flags

2023-10-06 Thread Leonid Mesnik
I marked tests sun/tools/jcmd/TestProcessHelper.java sun/tools/jinfo/JInfoTest.java as headless. They used different specific VM options and are not worth executing with other VM flags. And fixed sun/tools/jstat/JStatInterval.java Tested with tier1, local execution of tests, and running sun/to

RFR: 8316445: Mark com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java as vm.flagless

2023-09-19 Thread Leonid Mesnik
Test com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java check how beans work with VM flags and ignore external flags. It doesn't make sense to run it with external options so just mark it as flagless. Tested with running tier1 and test with/without additional options. - Comm

Re: RFR: 8315097: Rename createJavaProcessBuilder

2023-08-28 Thread Leonid Mesnik
On Mon, 28 Aug 2023 15:54:08 GMT, Leo Korinth wrote: > Rename createJavaProcessBuilder so that it is not used by mistake instead of > createTestJvm. > > I have used the following sed script: `find -name "*.java" | xargs -n 1 sed > -i -e > "s/createJavaProcessBuilder(/createJavaProcessBuilderI

Integrated: 8314330: java/foreign tests should respect vm flags when start new processes

2023-08-16 Thread Leonid Mesnik
On Wed, 16 Aug 2023 00:14:47 GMT, Leonid Mesnik wrote: > The test helper which spawn new jvms is updated to start them using VM flags > for testing. This pull request has now been integrated. Changeset: 7b28d360 Author:Leonid Mesnik URL: https://git.openjdk.org/jdk/

Re: RFR: 8314330: java/foreign tests should respect vm flags when start new processes [v2]

2023-08-16 Thread Leonid Mesnik
> The test helper which spawn new jvms is updated to start them using VM flags > for testing. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: fixed imports. - Changes: - all: https://git.openjdk.org/jdk/pull

RFR: 8314330: java/foreign tests should respect vm flags when start new processes

2023-08-15 Thread Leonid Mesnik
The test helper which spawn new jvms is updated to start them using VM flags for testing. - Commit messages: - 8314330: java/foreign tests should respect vm flags when start new processes Changes: https://git.openjdk.org/jdk/pull/15302/files Webrev: https://webrevs.openjdk.org/?re

Re: [jdk21] RFR: 8310822: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on generic-x64

2023-06-23 Thread Leonid Mesnik
On Fri, 23 Jun 2023 19:30:56 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/lang/ScopedValue/StressStackOverflow.java > on generic-x64. Marked as reviewed by lmesnik (Reviewer). - PR Review: https://git.openjdk.org/jdk21/pull/60#pullrequestreview-1495844009

Re: [jdk21] RFR: 8310822: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on generic-x64

2023-06-23 Thread Leonid Mesnik
On Fri, 23 Jun 2023 19:30:56 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/lang/ScopedValue/StressStackOverflow.java > on generic-x64. Changes requested by lmesnik (Reviewer). test/jdk/ProblemList-Xcomp.txt line 31: > 29: > 30: java/lang/invoke/MethodHandles/CatchExcep

Re: RFR: 8309334: ProcessTools.main() does not properly set thread names when using the virtual thread wrapper

2023-06-02 Thread Leonid Mesnik
On Fri, 2 Jun 2023 21:30:46 GMT, Chris Plummer wrote: > Normally when a virtual thread wrapper is used to run a test, the main thread > is renamed to "old-m-a-i-n" and the new virtual thread that will act as the > main thread is named "main". Neither is being done by `ProcessTools.main()`. > T

Re: RFR: 8308475: Make the thread dump files generated by jcmd Thread.dump_to_file jtreg failure handler action easily accessible

2023-05-24 Thread Leonid Mesnik
On Sun, 21 May 2023 09:19:47 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to improve the > accessibility of the thread dump files that are generated by the `jcmd > Thread.dump_to_file` command configured in the failure handler > configurations? This addres

Integrated: 8308223: failure handler missed jcmd.vm.info command

2023-05-16 Thread Leonid Mesnik
On Tue, 16 May 2023 18:07:16 GMT, Leonid Mesnik wrote: > Trivial fix that added missed useful command. > Tested by running make of failure handler and verifying results. This pull request has now been integrated. Changeset: 563152f3 Author:Leonid Mesnik URL: https://git.openj

RFR: 8308223: failure handler missed jcmd.vm.info command

2023-05-16 Thread Leonid Mesnik
Trivial fix that added missed useful command. Tested by running make of failure handler and verifying results. - Commit messages: - 8308223 Changes: https://git.openjdk.org/jdk/pull/14018/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14018&range=00 Issue: https://bugs.op

Re: RFR: 8307966: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java on linux-x64

2023-05-11 Thread Leonid Mesnik
On Fri, 12 May 2023 00:05:21 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java > on linux-x64. Marked as reviewed by lmesnik (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/13946#pullrequestreview-1423608862

Re: RFR: 8307966: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java on linux-x64

2023-05-11 Thread Leonid Mesnik
On Fri, 12 May 2023 00:05:21 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java > on linux-x64. Might be this failure is platform agnostic and should be generic all. We just don't run this combination on macosx so often. ( --

  1   2   >