Re: RFR: 8298638: Cleanup of unix java_md.c for better re-exec handling

2022-12-16 Thread Dmitry Samersoff
On Wed, 14 Dec 2022 09:51:20 GMT, Alan Bateman wrote: >> src/java.base/unix/native/libjli/java_md.c line 177: >> >>> 175: char clientPattern[] = "lib/client"; >>> 176: char serverPattern[] = "lib/server"; >>> 177: char minimalPattern[] = "lib/minimal"; >> >> I don't see any point in

RFR: 8298638: Cleanup of unix java_md.c for better re-exec handling

2022-12-13 Thread Dmitry Samersoff
Move "unix" java_md.c cleanup, which is the prerequisites for the fix for JDK-8293806 (PR https://github.com/openjdk/jdk/pull/11538), to a separate PR. @AlanBateman, @dholmes-ora please, take a look to the changes. - Commit messages: - 8298638: Cleanup of unix java_md.c for better

Re: RFR: 8293806: JDK_JAVA_OPTIONS picked up twice if launcher re-executes itself

2022-12-13 Thread Dmitry Samersoff
On Thu, 8 Dec 2022 14:21:36 GMT, Alan Bateman wrote: >> If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options >> from the JDK_JAVA_OPTIONS environment variable are picked up twice. >> >> If an option cannot be accepted twice (e.g., -agentlib), the application >> fails to s

Withdrawn: 8293806: JDK_JAVA_OPTIONS picked up twice if launcher re-executes it self

2022-12-06 Thread Dmitry Samersoff
On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff wrote: > If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options > from the JDK_JAVA_OPTIONS environment variable are picked up twice. > > If an option cannot be accepted twice (e.g., -agentlib), the application

Re: RFR: 8293806: JDK_JAVA_OPTIONS picked up twice if launcher re-executes it self

2022-12-06 Thread Dmitry Samersoff
On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff wrote: > If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options > from the JDK_JAVA_OPTIONS environment variable are picked up twice. > > If an option cannot be accepted twice (e.g., -agentlib), the application

Re: RFR: 8293806: JDK_JAVA_OPTIONS picked up twice if launcher re-executes it self

2022-10-18 Thread Dmitry Samersoff
On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff wrote: > If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options > from the JDK_JAVA_OPTIONS environment variable are picked up twice. > > If an option cannot be accepted twice (e.g., -agentlib), the application

Re: RFR: 8293806: JDK_JAVA_OPTIONS picked up twice if launcher re-executes it self

2022-10-17 Thread Dmitry Samersoff
On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff wrote: > If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options > from the JDK_JAVA_OPTIONS environment variable are picked up twice. > > If an option cannot be accepted twice (e.g., -agentlib), the application

Re: RFR: 8292016: Cleanup legacy error reporting in the JDK outside of HotSpot [v35]

2022-10-03 Thread Dmitry Samersoff
On Mon, 3 Oct 2022 13:37:38 GMT, Julian Waters wrote: >> A large section of error reporting code in the JDK does not properly handle >> WIN32 API errors and instead mixes them with errors originating from C. >> Since they can be rather easily replaced and coming up with an elegant >> solution

Re: RFR: 8292016: Cleanup legacy error reporting in the JDK outside of HotSpot [v35]

2022-10-03 Thread Dmitry Samersoff
On Mon, 3 Oct 2022 13:37:38 GMT, Julian Waters wrote: >> A large section of error reporting code in the JDK does not properly handle >> WIN32 API errors and instead mixes them with errors originating from C. >> Since they can be rather easily replaced and coming up with an elegant >> solution

Re: RFR: 8292016: Cleanup legacy error reporting in the JDK outside of HotSpot [v35]

2022-10-03 Thread Dmitry Samersoff
On Mon, 3 Oct 2022 13:37:38 GMT, Julian Waters wrote: >> A large section of error reporting code in the JDK does not properly handle >> WIN32 API errors and instead mixes them with errors originating from C. >> Since they can be rather easily replaced and coming up with an elegant >> solution

Re: RFR: 8293806: JDK_JAVA_OPTIONS picked up twice if LD_LIBRARY_PATH is set

2022-09-30 Thread Dmitry Samersoff
On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff wrote: > If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options > from the JDK_JAVA_OPTIONS environment variable are picked up twice. > > If an option cannot be accepted twice (e.g., -agentlib), the application

Re: RFR: 8293806: JDK_JAVA_OPTIONS picked up twice if LD_LIBRARY_PATH is set

2022-09-28 Thread Dmitry Samersoff
On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff wrote: > If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options > from the JDK_JAVA_OPTIONS environment variable are picked up twice. > > If an option cannot be accepted twice (e.g., -agentlib), the application

Re: RFR: 8293806: JDK_JAVA_OPTIONS picked up twice if LD_LIBRARY_PATH is set

2022-09-27 Thread Dmitry Samersoff
On Tue, 27 Sep 2022 06:00:10 GMT, David Holmes wrote: > Sorry @dsamersoff but I don't understand how this arises - can you explain in > more detail please? I'm not seeing the connection between setting > `LD_LIBRARY_PATH` and reading an env var twice. Thanks Linker read LD_LIBRARY_PATH only on

RFR: 8293806: JDK_JAVA_OPTIONS picked up twice if LD_LIBRARY_PATH is set

2022-09-26 Thread Dmitry Samersoff
If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options from the JDK_JAVA_OPTIONS environment variable are picked up twice. If an option cannot be accepted twice (e.g., -agentlib), the application fails to start. The same happens on operating systems that doesn't support $RPA

Withdrawn: 8293806: JDK_JAVA_OPTIONS picked up twice if LD_LIBRARY_PATH is set

2022-09-26 Thread Dmitry Samersoff
On Mon, 26 Sep 2022 09:46:36 GMT, Dmitry Samersoff wrote: > If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options > from the JDK_JAVA_OPTIONS environment variable are picked up twice. > > If an option cannot be accepted twice (e.g., -agentlib), the application

RFR: 8293806: JDK_JAVA_OPTIONS picked up twice if LD_LIBRARY_PATH is set

2022-09-26 Thread Dmitry Samersoff
If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options from the JDK_JAVA_OPTIONS environment variable are picked up twice. If an option cannot be accepted twice (e.g., -agentlib), the application fails to start. The same happens on operating systems that doesn't support $RPA