Re: Integrated: 8340956: ProblemList 4 java/nio/channels/DatagramChannel tests on macosx-all

2024-09-25 Thread Daniel D . Daugherty
On Wed, 25 Sep 2024 17:11:23 GMT, Chen Liang wrote: >> A trivial fix to ProblemList 4 java/nio/channels/DatagramChannel tests on >> macosx-all. > > These failures happen extremely often on macosx indeed. @liach, @AlanBateman, @jddarcy and @dfuch - Thanks for the lightning fast reviews! -

Integrated: 8340956: ProblemList 4 java/nio/channels/DatagramChannel tests on macosx-all

2024-09-25 Thread Daniel D . Daugherty
On Wed, 25 Sep 2024 17:07:57 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList 4 java/nio/channels/DatagramChannel tests on > macosx-all. This pull request has now been integrated. Changeset: 1b2d40ad Author:Daniel D. Daugherty URL: https://git.openjdk.org/jdk/

Integrated: 8340956: ProblemList 4 java/nio/channels/DatagramChannel tests on macosx-all

2024-09-25 Thread Daniel D . Daugherty
A trivial fix to ProblemList 4 java/nio/channels/DatagramChannel tests on macosx-all. - Commit messages: - 8340956: ProblemList 4 java/nio/channels/DatagramChannel tests on macosx-all Changes: https://git.openjdk.org/jdk/pull/21188/files Webrev: https://webrevs.openjdk.org/?repo=

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v15]

2024-08-14 Thread Daniel D . Daugherty
On Tue, 13 Aug 2024 17:24:19 GMT, Daniel D. Daugherty wrote: >> Axel Boldt-Christmas has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Remove the last OMWorld references >> - Rename omworldtable_wor

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v19]

2024-08-14 Thread Daniel D . Daugherty
On Wed, 14 Aug 2024 09:24:34 GMT, Axel Boldt-Christmas wrote: >> When inflating a monitor the `ObjectMonitor*` is written directly over the >> `markWord` and any overwritten data is displaced into a displaced >> `markWord`. This is problematic for concurrent GCs which needs extra care or >> l

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v16]

2024-08-14 Thread Daniel D . Daugherty
On Wed, 14 Aug 2024 09:35:10 GMT, Axel Boldt-Christmas wrote: >> src/hotspot/share/runtime/vframe.cpp line 252: >> >>> 250: if (mark.has_monitor()) { >>> 251: ObjectMonitor* mon = >>> ObjectSynchronizer::read_monitor(current, monitor->owner(), mark); >>> 252:

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v16]

2024-08-13 Thread Daniel D . Daugherty
On Tue, 13 Aug 2024 16:30:12 GMT, Axel Boldt-Christmas wrote: >> When inflating a monitor the `ObjectMonitor*` is written directly over the >> `markWord` and any overwritten data is displaced into a displaced >> `markWord`. This is problematic for concurrent GCs which needs extra care or >> l

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v15]

2024-08-13 Thread Daniel D . Daugherty
On Tue, 13 Aug 2024 16:49:42 GMT, Daniel D. Daugherty wrote: >> Axel Boldt-Christmas has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Remove the last OMWorld references >> - Rename omworldtable_wor

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v16]

2024-08-13 Thread Daniel D . Daugherty
On Tue, 13 Aug 2024 16:30:12 GMT, Axel Boldt-Christmas wrote: >> When inflating a monitor the `ObjectMonitor*` is written directly over the >> `markWord` and any overwritten data is displaced into a displaced >> `markWord`. This is problematic for concurrent GCs which needs extra care or >> l

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v15]

2024-08-13 Thread Daniel D . Daugherty
On Tue, 13 Aug 2024 14:56:32 GMT, Coleen Phillimore wrote: >> Axel Boldt-Christmas has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Remove the last OMWorld references >> - Rename omworldtable_work to object_monitor_table_work > > src/h

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v6]

2024-08-13 Thread Daniel D . Daugherty
On Mon, 15 Jul 2024 00:45:10 GMT, Axel Boldt-Christmas wrote: >> src/hotspot/share/runtime/lightweightSynchronizer.cpp line 401: >> >>> 399: >>> 400: if (inserted) { >>> 401: // Hopefully the performance counters are allocated on distinct >> >> It doesn't look like the counters are on d

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v15]

2024-08-13 Thread Daniel D . Daugherty
On Tue, 13 Aug 2024 14:52:03 GMT, Axel Boldt-Christmas wrote: >> When inflating a monitor the `ObjectMonitor*` is written directly over the >> `markWord` and any overwritten data is displaced into a displaced >> `markWord`. This is problematic for concurrent GCs which needs extra care or >> l

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v11]

2024-08-13 Thread Daniel D . Daugherty
On Mon, 12 Aug 2024 15:58:14 GMT, Axel Boldt-Christmas wrote: >> When inflating a monitor the `ObjectMonitor*` is written directly over the >> `markWord` and any overwritten data is displaced into a displaced >> `markWord`. This is problematic for concurrent GCs which needs extra care or >> l

Integrated: 8326062: ProblemList jcstress tests that are failing due to JDK-8325984

2024-02-16 Thread Daniel D . Daugherty
On Fri, 16 Feb 2024 15:54:27 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList jcstress tests that are failing due to > JDK-8325984. This pull request has now been integrated. Changeset: 00b5c707 Author:Daniel D. Daugherty URL: https://git.openjdk.org/jdk/

Re: RFR: 8326062: ProblemList jcstress tests that are failing due to JDK-8325984

2024-02-16 Thread Daniel D . Daugherty
On Fri, 16 Feb 2024 15:56:41 GMT, Alexander Zvegintsev wrote: >> A trivial fix to ProblemList jcstress tests that are failing due to >> JDK-8325984. > > Marked as reviewed by azvegint (Reviewer). @azvegint - Thanks for the fast review! - PR Comment: https://git.openjdk.org/jdk/pu

RFR: 8326062: ProblemList jcstress tests that are failing due to JDK-8325984

2024-02-16 Thread Daniel D . Daugherty
A trivial fix to ProblemList jcstress tests that are failing due to JDK-8325984. - Commit messages: - 8326062: ProblemList jcstress tests that are failing due to JDK-8325984 Changes: https://git.openjdk.org/jdk/pull/17890/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17890

Re: Integrated: 8324786: validate-source fails after JDK-8042981

2024-01-26 Thread Daniel D . Daugherty
On Fri, 26 Jan 2024 21:52:37 GMT, Joe Darcy wrote: >> A trivial fix for validate-source. > > Marked as reviewed by darcy (Reviewer). @jddarcy - Thanks for the lightning fast review! - PR Comment: https://git.openjdk.org/jdk/pull/17599#issuecomment-1912744650

Integrated: 8324786: validate-source fails after JDK-8042981

2024-01-26 Thread Daniel D . Daugherty
On Fri, 26 Jan 2024 21:51:04 GMT, Daniel D. Daugherty wrote: > A trivial fix for validate-source. This pull request has now been integrated. Changeset: 70f4a4e1 Author: Daniel D. Daugherty URL: https://git.openjdk.org/jdk/commit/70f4a4e18e257110f45565ba0d708f1fa48aed76 Stats:

Integrated: 8324786: validate-source fails after JDK-8042981

2024-01-26 Thread Daniel D . Daugherty
A trivial fix for validate-source. - Commit messages: - 8324786: validate-source fails after JDK-8042981 Changes: https://git.openjdk.org/jdk/pull/17599/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17599&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324786 Stat

Integrated: 8324161: validate-source fails after JDK-8275338

2024-01-18 Thread Daniel D . Daugherty
On Thu, 18 Jan 2024 17:39:47 GMT, Daniel D. Daugherty wrote: > A trivial fix to the copyright line in > test/jdk/jdk/jfr/event/io/TestSerializationMisdeclarationEvent.java. This pull request has now been integrated. Changeset: 5c874c19 Author:Daniel D. Daugherty URL:

Re: Integrated: 8324161: validate-source fails after JDK-8275338

2024-01-18 Thread Daniel D . Daugherty
On Thu, 18 Jan 2024 17:41:04 GMT, Joe Darcy wrote: >> A trivial fix to the copyright line in >> test/jdk/jdk/jfr/event/io/TestSerializationMisdeclarationEvent.java. > > Marked as reviewed by darcy (Reviewer). @jddarcy - Thanks for the lightning fast review! - PR Comment: https://g

Integrated: 8324161: validate-source fails after JDK-8275338

2024-01-18 Thread Daniel D . Daugherty
A trivial fix to the copyright line in test/jdk/jdk/jfr/event/io/TestSerializationMisdeclarationEvent.java. - Commit messages: - 8324161: validate-source fails after JDK-8275338 Changes: https://git.openjdk.org/jdk/pull/17490/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=

Re: [jdk22] RFR: 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file

2024-01-18 Thread Daniel D . Daugherty
On Thu, 18 Jan 2024 15:36:07 GMT, Albert Mingkun Yang wrote: >> A trivial fix to disable core file generation in >> java/foreign/critical/TestCriticalUpcall.java. > > Marked as reviewed by ayang (Reviewer). @albertnetymk - Thanks for the fast review! - PR Comment: https://git.open

[jdk22] Integrated: 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file

2024-01-18 Thread Daniel D . Daugherty
On Thu, 18 Jan 2024 15:20:13 GMT, Daniel D. Daugherty wrote: > A trivial fix to disable core file generation in > java/foreign/critical/TestCriticalUpcall.java. This pull request has now been integrated. Changeset: b1788944 Author:Daniel D. Daugherty URL: https://git.openj

[jdk22] RFR: 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file

2024-01-18 Thread Daniel D . Daugherty
A trivial fix to disable core file generation in java/foreign/critical/TestCriticalUpcall.java. - Commit messages: - Backport a22ae909bc53344afd9bb6b1f08ff06858c10820 Changes: https://git.openjdk.org/jdk22/pull/90/files Webrev: https://webrevs.openjdk.org/?repo=jdk22&pr=90&range=0

Integrated: 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file

2024-01-18 Thread Daniel D . Daugherty
On Thu, 18 Jan 2024 00:58:49 GMT, Daniel D. Daugherty wrote: > A trivial fix to disable core file generation in > java/foreign/critical/TestCriticalUpcall.java. This pull request has now been integrated. Changeset: a22ae909 Author:Daniel D. Daugherty URL: https://git.openj

Re: RFR: 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file [v2]

2024-01-18 Thread Daniel D . Daugherty
On Thu, 18 Jan 2024 07:47:54 GMT, David Holmes wrote: >> Daniel D. Daugherty has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update copyright year. > > Good and trivial. > > Copyright year needs

Re: RFR: 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file [v2]

2024-01-18 Thread Daniel D . Daugherty
> A trivial fix to disable core file generation in > java/foreign/critical/TestCriticalUpcall.java. Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision: Update copyright year. - Changes: - all:

RFR: 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file

2024-01-17 Thread Daniel D . Daugherty
A trivial fix to disable core file generation in java/foreign/critical/TestCriticalUpcall.java. - Commit messages: - 8321938: java/foreign/critical/TestCriticalUpcall.java does not need a core file Changes: https://git.openjdk.org/jdk/pull/17476/files Webrev: https://webrevs.open

Re: Integrated: 8322963: ProblemList java/io/BufferedInputStream/TransferTo.java

2024-01-03 Thread Daniel D . Daugherty
On Wed, 3 Jan 2024 17:14:42 GMT, Brian Burkhalter wrote: >> A trivial fix to ProblemList java/io/BufferedInputStream/TransferTo.java. > > Marked as reviewed by bpb (Reviewer). @bplb - Thanks for the lightning fast review! - PR Comment: https://git.openjdk.org/jdk/pull/17249#issueco

Integrated: 8322963: ProblemList java/io/BufferedInputStream/TransferTo.java

2024-01-03 Thread Daniel D . Daugherty
On Wed, 3 Jan 2024 17:13:02 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/io/BufferedInputStream/TransferTo.java. This pull request has now been integrated. Changeset: cc9ab5f1 Author: Daniel D. Daugherty URL: https://git.openjdk.org/jdk/com

Integrated: 8322963: ProblemList java/io/BufferedInputStream/TransferTo.java

2024-01-03 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/io/BufferedInputStream/TransferTo.java. - Commit messages: - 8322963: ProblemList java/io/BufferedInputStream/TransferTo.java Changes: https://git.openjdk.org/jdk/pull/17249/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17249&range=00 Is

Re: RFR: 8322868: java/io/BufferedInputStream/TransferToTrusted.java has bad copyright header

2024-01-02 Thread Daniel D . Daugherty
On Tue, 2 Jan 2024 20:27:29 GMT, Brian Burkhalter wrote: > Add missing comma after 2024. Thumbs up. This is a trivial fix. - Marked as reviewed by dcubed (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17228#pullrequestreview-1800974980

Integrated: 8321127: ProblemList java/util/stream/GatherersTest.java

2023-11-30 Thread Daniel D . Daugherty
On Thu, 30 Nov 2023 16:08:54 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/util/stream/GatherersTest.java. This pull request has now been integrated. Changeset: c6a82783 Author: Daniel D. Daugherty URL: https://git.openjdk.org/jdk/com

Re: Integrated: 8321127: ProblemList java/util/stream/GatherersTest.java

2023-11-30 Thread Daniel D . Daugherty
On Thu, 30 Nov 2023 16:12:04 GMT, Aleksey Shipilev wrote: >> A trivial fix to ProblemList java/util/stream/GatherersTest.java. > > All right! Hope it would be fixed soon. Trivial. @shipilev and @AlanBateman - Thanks for the fast reviews. - PR Comment: https://git.openjdk.org/jdk/pu

Integrated: 8321127: ProblemList java/util/stream/GatherersTest.java

2023-11-30 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/util/stream/GatherersTest.java. - Commit messages: - 8321127: ProblemList java/util/stream/GatherersTest.java Changes: https://git.openjdk.org/jdk/pull/16909/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16909&range=00 Issue: https://bug

Re: RFR: 8318776: Require supports_cx8 to always be true [v5]

2023-11-22 Thread Daniel D . Daugherty
On Wed, 22 Nov 2023 21:41:50 GMT, Aleksey Shipilev wrote: >> @shipilev - Do you have a particular legacy x86 in mind? > > My point is that it is such an easy thing to do: leave the "cx8" flag sensing > code in, and keep setting up `_supports_cx8` based on it for `!_LP64` paths. > This both prov

Re: RFR: 8318776: Require supports_cx8 to always be true [v5]

2023-11-22 Thread Daniel D . Daugherty
On Wed, 22 Nov 2023 08:48:09 GMT, Aleksey Shipilev wrote: >> David Holmes has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >> co

Re: RFR: 8318776: Require supports_cx8 to always be true [v5]

2023-11-22 Thread Daniel D . Daugherty
On Wed, 22 Nov 2023 02:09:38 GMT, David Holmes wrote: >> As discussed in JBS all platforms (some tweaks to Zero are in progress) >> actually do support `cx8` i.e. 64-bit compare-and-exchange, so we can strip >> out the locked-based alternatives to using it and just add a guarantee that >> it i

Integrated: 8318038: ProblemList runtime/CompressedOops/CompressedClassPointers.java on two platforms

2023-10-12 Thread Daniel D . Daugherty
On Thu, 12 Oct 2023 19:26:10 GMT, Daniel D. Daugherty wrote: > Trivial ProblemListing for some tests: > > [JDK-8318038](https://bugs.openjdk.org/browse/JDK-8318038) ProblemList > runtime/CompressedOops/CompressedClassPointers.java on two platforms > [JDK-8318040](https://b

Re: RFR: 8318038: ProblemList runtime/CompressedOops/CompressedClassPointers.java on two platforms

2023-10-12 Thread Daniel D . Daugherty
On Thu, 12 Oct 2023 19:54:17 GMT, Roger Riggs wrote: >> Trivial ProblemListing for some tests: >> >> [JDK-8318038](https://bugs.openjdk.org/browse/JDK-8318038) ProblemList >> runtime/CompressedOops/CompressedClassPointers.java on two platforms >> [JDK-8318040](https://bugs.openjdk.org/browse/JD

RFR: 8318038: ProblemList runtime/CompressedOops/CompressedClassPointers.java on two platforms

2023-10-12 Thread Daniel D . Daugherty
Trivial ProblemListing for some tests: [JDK-8318038](https://bugs.openjdk.org/browse/JDK-8318038) ProblemList runtime/CompressedOops/CompressedClassPointers.java on two platforms [JDK-8318040](https://bugs.openjdk.org/browse/JDK-8318040) ProblemList vmTestbase/nsk/monitoring/ThreadMXBean/findMon

Re: RFR: 8315869: UseHeavyMonitors not used [v2]

2023-09-20 Thread Daniel D . Daugherty
On Wed, 20 Sep 2023 18:00:40 GMT, Coleen Phillimore wrote: >> Please review this trivial change to remove the UseHeavyMonitors develop >> option, in favor of the now non-experimental LockingMode=LM_MONITOR (0) >> option. Tested with tier1 locally. > > Coleen Phillimore has updated the pull req

Re: RFR: 8315869: UseHeavyMonitors not used [v2]

2023-09-20 Thread Daniel D . Daugherty
On Wed, 20 Sep 2023 18:00:40 GMT, Coleen Phillimore wrote: >> Please review this trivial change to remove the UseHeavyMonitors develop >> option, in favor of the now non-experimental LockingMode=LM_MONITOR (0) >> option. Tested with tier1 locally. > > Coleen Phillimore has updated the pull req

Re: RFR: 8315869: UseHeavyMonitors not used

2023-09-20 Thread Daniel D . Daugherty
On Wed, 20 Sep 2023 17:36:06 GMT, Coleen Phillimore wrote: > Please review this trivial change to remove the UseHeavyMonitors develop > option, in favor of the now non-experimental LockingMode=LM_MONITOR (0) > option. Tested with tier1 locally. Changes requested by dcubed (Reviewer). src/hot

Re: RFR: 8315891: java/foreign/TestLinker.java failed with "error occurred while instantiating class TestLinker: null" [v2]

2023-09-08 Thread Daniel D . Daugherty
On Fri, 8 Sep 2023 10:52:06 GMT, Maurizio Cimadamore wrote: >> This PR adds a privileged block surrounding the request to load the fallback >> linker library in LibFallback. >> The lack of this block is causing test failures when platforms using the >> fallback linker are tested using a securi

Re: [jdk21] Integrated: 8313208: ProblemList java/util/concurrent/tck/JSR166TestCase.java on select platforms

2023-07-26 Thread Daniel D . Daugherty
On Wed, 26 Jul 2023 19:24:33 GMT, Joe Darcy wrote: >> A trivial fix to ProblemList java/util/concurrent/tck/JSR166TestCase.java on >> select platforms. > > Marked as reviewed by darcy (Reviewer). @jddarcy - Thanks for the lightning fast review! - PR Comment: https://git.openjdk.or

[jdk21] Integrated: 8313208: ProblemList java/util/concurrent/tck/JSR166TestCase.java on select platforms

2023-07-26 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/util/concurrent/tck/JSR166TestCase.java on select platforms. - Commit messages: - 8313208: ProblemList java/util/concurrent/tck/JSR166TestCase.java on select platforms Changes: https://git.openjdk.org/jdk21/pull/145/files Webrev: https://webrevs.

Re: [jdk21] RFR: 8313193: ProblemList java/util/concurrent/SynchronousQueue/Fairness.java on X64

2023-07-26 Thread Daniel D . Daugherty
On Wed, 26 Jul 2023 15:47:48 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/util/concurrent/SynchronousQueue/Fairness.java on X64. They are (so far), but the fix that Doug Lea integrated did not seem to be specific to ZGC or -Xcomp so I went wider... I'm

[jdk21] Integrated: 8313208: ProblemList java/util/concurrent/tck/JSR166TestCase.java on select platforms

2023-07-26 Thread Daniel D . Daugherty
On Wed, 26 Jul 2023 19:22:08 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/util/concurrent/tck/JSR166TestCase.java on > select platforms. This pull request has now been integrated. Changeset: a10dbcec Author:Daniel D. Daugherty URL: https://git.openj

[jdk21] Integrated: 8313193: ProblemList java/util/concurrent/SynchronousQueue/Fairness.java on X64

2023-07-26 Thread Daniel D . Daugherty
On Wed, 26 Jul 2023 15:47:48 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/util/concurrent/SynchronousQueue/Fairness.java on X64. This pull request has now been integrated. Changeset: f666e606 Author:Daniel D. Daugherty URL: https://git.openjdk.org

Re: [jdk21] RFR: 8313193: ProblemList java/util/concurrent/SynchronousQueue/Fairness.java on X64

2023-07-26 Thread Daniel D . Daugherty
On Wed, 26 Jul 2023 16:44:56 GMT, Roger Riggs wrote: >> A trivial fix to ProblemList >> java/util/concurrent/SynchronousQueue/Fairness.java on X64. > > Marked as reviewed by rriggs (Reviewer). @RogerRiggs - Thanks for the review! - PR Comment: https://git.openjdk.org/jdk21/pull/14

[jdk21] RFR: 8313193: ProblemList java/util/concurrent/SynchronousQueue/Fairness.java on X64

2023-07-26 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/util/concurrent/SynchronousQueue/Fairness.java on X64. - Commit messages: - 8313193: ProblemList java/util/concurrent/SynchronousQueue/Fairness.java on X64 Changes: https://git.openjdk.org/jdk21/pull/144/files Webrev: https://webrevs.openjdk.org/

Re: RFR: 8311043: Remove trailing blank lines in source files

2023-06-30 Thread Daniel D . Daugherty
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote: > Remove trailing "blank" lines in source files. > > I like to use global-whitespace-cleanup-mode, but I can not use it if the > files are "dirty" to begin with. This fix will make more files "clean". I > also considered adding a check for t

Re: Integrated: JDK-8310922: java/lang/Class/forName/ForNameNames.java fails after being added by JDK-8310242

2023-06-26 Thread Daniel D . Daugherty
On Mon, 26 Jun 2023 21:21:41 GMT, Mandy Chung wrote: > A trivial fix to correct the expected result to be `Inner[].class`. I > missed the rerun of the test to verify the last-minute edit to the test by > JDK-8310242. Thumbs up. This is a trivial fix. - PR Comment: https://git.o

[jdk21] Integrated: 8310822: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on generic-x64

2023-06-23 Thread Daniel D . Daugherty
On Fri, 23 Jun 2023 19:30:56 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/lang/ScopedValue/StressStackOverflow.java > on generic-x64. This pull request has now been integrated. Changeset: af3a56e5 Author:Daniel D. Daugherty URL: https://git.openj

Re: [jdk21] RFR: 8310822: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on generic-x64

2023-06-23 Thread Daniel D . Daugherty
On Fri, 23 Jun 2023 19:44:50 GMT, Iris Clark wrote: >> A trivial fix to ProblemList java/lang/ScopedValue/StressStackOverflow.java >> on generic-x64. > > Marked as reviewed by iris (Reviewer). @irisclark and @lmesnik - Thanks for the fast reviews! - PR Comment: https://git.openjdk

Re: [jdk21] RFR: 8310822: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on generic-x64

2023-06-23 Thread Daniel D . Daugherty
On Fri, 23 Jun 2023 19:45:19 GMT, Leonid Mesnik wrote: >> A trivial fix to ProblemList java/lang/ScopedValue/StressStackOverflow.java >> on generic-x64. > > test/jdk/ProblemList-Xcomp.txt line 31: > >> 29: >> 30: java/lang/invoke/MethodHandles/CatchExceptionTest.java 8146623 >> generic-all >>

[jdk21] RFR: 8310822: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on generic-x64

2023-06-23 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/lang/ScopedValue/StressStackOverflow.java on generic-x64. - Commit messages: - 8310822: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on generic-x64 Changes: https://git.openjdk.org/jdk21/pull/60/files Webrev: https://webrevs.

Re: Integrated: 8310586: ProblemList java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads on linux-all

2023-06-21 Thread Daniel D . Daugherty
On Wed, 21 Jun 2023 21:05:11 GMT, Mikael Vidstedt wrote: >> A trivial fix to ProblemList >> java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads >> on linux-all > > Marked as reviewed by mikael (Reviewer). @vidmik - Thanks for your review also. - PR Comment

Re: Integrated: 8310586: ProblemList java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads on linux-all

2023-06-21 Thread Daniel D . Daugherty
On Wed, 21 Jun 2023 21:02:58 GMT, David Holmes wrote: >> A trivial fix to ProblemList >> java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads >> on linux-all > > Marked as reviewed by dholmes (Reviewer). @dholmes-ora - Thanks for the lightning fast review! -

Integrated: 8310586: ProblemList java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads on linux-all

2023-06-21 Thread Daniel D . Daugherty
On Wed, 21 Jun 2023 20:59:43 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads > on linux-all This pull request has now been integrated. Changeset: ac44ef19 Author: Daniel D. Daugh

Integrated: 8310586: ProblemList java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads on linux-all

2023-06-21 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads on linux-all - Commit messages: - 8310586: ProblemList java/lang/ScopedValue/StressStackOverflow.java#default with virtual threads on linux-all Changes: https://git.openjdk.or

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries

2023-06-16 Thread Daniel D . Daugherty
On Fri, 16 Jun 2023 20:36:07 GMT, Jiangli Zhou wrote: > 8307858: [REDO] JDK-8307194 Add make target for optionally building a > complete set of all JDK and hotspot libjvm static libraries GHA is failing on windows; is this related to this PR or something else? @erikj - You did a round of Mach5

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v2]

2023-06-16 Thread Daniel D . Daugherty
On Fri, 16 Jun 2023 11:41:14 GMT, Axel Boldt-Christmas wrote: >> The current implementation for testing generational ZGC with jtreg is >> implemented with a filter on the mode flag `ZGenerational`. Because of this >> only environments which set this flag explicitly will run most of the tests.

Re: RFR: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations" [v6]

2023-06-16 Thread Daniel D . Daugherty
On Wed, 14 Jun 2023 16:54:55 GMT, Andrew Haley wrote: >> The implementation changes look good. >> >> The update to test looks okay too although I would like to see if we can do >> better in SVC and STS when there is a SO. In passing, I think all usages of >> tlr should be replaced with Thread

Integrated: 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing

2023-06-16 Thread Daniel D . Daugherty
On Fri, 16 Jun 2023 17:10:08 GMT, Daniel D. Daugherty wrote: > A trivia fix for > serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java > failing. This pull request has now been integrated. Changeset: 16134f44 Author: Daniel D. Daugherty URL:

Re: Integrated: 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing

2023-06-16 Thread Daniel D . Daugherty
On Fri, 16 Jun 2023 17:26:38 GMT, Mikael Vidstedt wrote: >> A trivia fix for >> serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java >> failing. > > Marked as reviewed by mikael (Reviewer). @vidmik - Thanks for the review! It appears that the bots are running very, very sl

Re: Integrated: 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing

2023-06-16 Thread Daniel D . Daugherty
On Fri, 16 Jun 2023 17:10:08 GMT, Daniel D. Daugherty wrote: > A trivia fix for > serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java > failing. This fix is being tested with an urgent Mach5 Tier1. macosx-aarch64-debug has passed the test when it failed befor

Integrated: 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing

2023-06-16 Thread Daniel D . Daugherty
A trivia fix for serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing. - Commit messages: - 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing Changes: https://git.openjdk.org/jdk/pull/14524/files Webrev: https:/

Integrated: 8309236: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC and Generational ZGC again

2023-05-31 Thread Daniel D . Daugherty
On Wed, 31 May 2023 20:34:07 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java > with ZGC and Generational ZGC again This pull request has now been integrated. Changeset: e42a4b65 Author:Daniel D. Daugherty URL:

Re: Integrated: 8309236: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC and Generational ZGC again

2023-05-31 Thread Daniel D . Daugherty
On Wed, 31 May 2023 20:38:23 GMT, Brian Burkhalter wrote: >> A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java >> with ZGC and Generational ZGC again > > Marked as reviewed by bpb (Reviewer). @bplb and @azvegint - Thanks for the fast reviews! - PR Comment

Integrated: 8309236: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC and Generational ZGC again

2023-05-31 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC and Generational ZGC again - Commit messages: - 8309236: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC and Generational ZGC again Changes: https://git.openjdk.org/jdk/pull/14

Integrated: 8309230: ProblemList jdk/incubator/vector/Float64VectorTests.java on aarch64

2023-05-31 Thread Daniel D . Daugherty
On Wed, 31 May 2023 16:40:54 GMT, Daniel D. Daugherty wrote: > A couple of trivial ProblemListings: > [JDK-8309230](https://bugs.openjdk.org/browse/JDK-8309230) ProblemList > jdk/incubator/vector/Float64VectorTests.java on aarch64 > [JDK-8309231](https://bugs.openjdk.org/browse

Integrated: 8309230: ProblemList jdk/incubator/vector/Float64VectorTests.java on aarch64

2023-05-31 Thread Daniel D . Daugherty
A couple of trivial ProblemListings: [JDK-8309230](https://bugs.openjdk.org/browse/JDK-8309230) ProblemList jdk/incubator/vector/Float64VectorTests.java on aarch64 [JDK-8309231](https://bugs.openjdk.org/browse/JDK-8309231) ProblemList vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/

Re: Integrated: 8309230: ProblemList jdk/incubator/vector/Float64VectorTests.java on aarch64

2023-05-31 Thread Daniel D . Daugherty
On Wed, 31 May 2023 16:48:06 GMT, Joe Darcy wrote: >> A couple of trivial ProblemListings: >> [JDK-8309230](https://bugs.openjdk.org/browse/JDK-8309230) ProblemList >> jdk/incubator/vector/Float64VectorTests.java on aarch64 >> [JDK-8309231](https://bugs.openjdk.org/browse/JDK-8309231) ProblemLis

Integrated: 8307966: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java on linux-x64

2023-05-11 Thread Daniel D . Daugherty
On Fri, 12 May 2023 00:05:21 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java > on linux-x64. This pull request has now been integrated. Changeset: 9a7b4431 Author:Daniel D. Daugherty URL: https://git.openjdk.o

Re: RFR: 8307966: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java on linux-x64

2023-05-11 Thread Daniel D . Daugherty
On Fri, 12 May 2023 00:05:21 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java > on linux-x64. I've switched to using 'linux-all' instead of enumeration of the platforms. - PR Comment: https://git

Re: RFR: 8307966: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java on linux-x64 [v2]

2023-05-11 Thread Daniel D . Daugherty
> A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java > on linux-x64. Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision: plummercj CR - use linux-all instead - Changes: - all:

Re: RFR: 8307966: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java on linux-x64

2023-05-11 Thread Daniel D . Daugherty
On Fri, 12 May 2023 00:15:25 GMT, Leonid Mesnik wrote: >> A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java >> on linux-x64. > > Might be this failure is platform agnostic and should be generic all. We just > don't run this combination on macosx so often. ( @lmesnik -

Re: RFR: 8307966: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java on linux-x64

2023-05-11 Thread Daniel D . Daugherty
On Fri, 12 May 2023 00:09:12 GMT, Chris Plummer wrote: >> A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java >> on linux-x64. > > Maybe linux-all would be better. @plummercj - Thanks for the review. 'linux-all' would make it apply to linux versions that we don't have. I

RFR: 8307966: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java on linux-x64

2023-05-11 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java on linux-x64. - Commit messages: - 8307966: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java on linux-x64 Changes: https://git.openjdk.org/jdk/pull/13946/files Webrev: https://webrevs.openjdk.or

Integrated: 8307489: ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64

2023-05-04 Thread Daniel D . Daugherty
On Thu, 4 May 2023 20:49:26 GMT, Daniel D. Daugherty wrote: > Trivial fixes to ProblemList a few tests: > - [JDK-8307489](https://bugs.openjdk.org/browse/JDK-8307489) ProblemList > jdk/incubator/vector/LoadJsvmlTest.java on windows-x64 > - [JDK-8307490](https://bugs.openjdk.or

Re: RFR: 8307489: ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64

2023-05-04 Thread Daniel D . Daugherty
On Thu, 4 May 2023 21:21:38 GMT, Joe Darcy wrote: >> Trivial fixes to ProblemList a few tests: >> - [JDK-8307489](https://bugs.openjdk.org/browse/JDK-8307489) ProblemList >> jdk/incubator/vector/LoadJsvmlTest.java on windows-x64 >> - [JDK-8307490](https://bugs.openjdk.org/browse/JDK-8307490) Pro

RFR: 8307489: ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64

2023-05-04 Thread Daniel D . Daugherty
Trivial fixes to ProblemList a few tests: - [JDK-8307489](https://bugs.openjdk.org/browse/JDK-8307489) ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64 - [JDK-8307490](https://bugs.openjdk.org/browse/JDK-8307490) ProblemList sun/security/pkcs11/Cipher/TestKATForGCM.java on linux

Re: RFR: 8306946: jdk/test/lib/process/ProcessToolsStartProcessTest.java fails with "wrong number of lines in OutputAnalyzer output" [v3]

2023-04-27 Thread Daniel D . Daugherty
On Thu, 27 Apr 2023 16:35:59 GMT, Leonid Mesnik wrote: >> The ProcessTools.startProcess (...) has been updated to completely read >> streams after process has been completed. >> The test was updated to run 5 times with different number of lines and line >> sizes. > > Leonid Mesnik has updated t

Re: RFR: 8233725: ProcessTools.startProcess() has output issues when using an OutputAnalyzer at the same time

2023-04-25 Thread Daniel D . Daugherty
On Tue, 25 Apr 2023 04:05:05 GMT, Leonid Mesnik wrote: >> test/lib/jdk/test/lib/process/ProcessTools.java line 792: >> >>> 790: @Override >>> 791: public InputStream getInputStream() { >>> 792: return out; >> >> This is a little bit confusing that the `getInputStream

Integrated: 8306780: ProblemList java/lang/Thread/virtual/HoldsLock.java#id0 in Xcomp

2023-04-24 Thread Daniel D . Daugherty
On Mon, 24 Apr 2023 19:28:41 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/lang/Thread/virtual/HoldsLock.java#id0 in > Xcomp. This pull request has now been integrated. Changeset: 328e512d Author:Daniel D. Daugherty URL: https://git.openjdk.org/jdk/

Re: Integrated: 8306780: ProblemList java/lang/Thread/virtual/HoldsLock.java#id0 in Xcomp

2023-04-24 Thread Daniel D . Daugherty
On Mon, 24 Apr 2023 19:34:01 GMT, Joe Darcy wrote: >> A trivial fix to ProblemList java/lang/Thread/virtual/HoldsLock.java#id0 in >> Xcomp. > > Marked as reviewed by darcy (Reviewer). @jddarcy - Thanks for the fast review! - PR Comment: https://git.openjdk.org/jdk/pull/13627#issue

Integrated: 8306780: ProblemList java/lang/Thread/virtual/HoldsLock.java#id0 in Xcomp

2023-04-24 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/lang/Thread/virtual/HoldsLock.java#id0 in Xcomp. - Commit messages: - 8306780: ProblemList java/lang/Thread/virtual/HoldsLock.java#id0 in Xcomp Changes: https://git.openjdk.org/jdk/pull/13627/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=

Integrated: 8305678: ProblemList serviceability/sa/ClhsdbInspect.java on windows-x64 in Xcomp

2023-04-05 Thread Daniel D . Daugherty
On Wed, 5 Apr 2023 21:12:14 GMT, Daniel D. Daugherty wrote: > Trivial fixes to ProblemList a couple of tests: > [JDK-8305678](https://bugs.openjdk.org/browse/JDK-8305678) ProblemList > serviceability/sa/ClhsdbInspect.java on windows-x64 in Xcomp > [JDK-8305679](https://bugs.openjd

Re: Integrated: 8305678: ProblemList serviceability/sa/ClhsdbInspect.java on windows-x64 in Xcomp

2023-04-05 Thread Daniel D . Daugherty
On Wed, 5 Apr 2023 21:18:28 GMT, Mikael Vidstedt wrote: >> Trivial fixes to ProblemList a couple of tests: >> [JDK-8305678](https://bugs.openjdk.org/browse/JDK-8305678) ProblemList >> serviceability/sa/ClhsdbInspect.java on windows-x64 in Xcomp >> [JDK-8305679](https://bugs.openjdk.org/browse/JD

Integrated: 8305678: ProblemList serviceability/sa/ClhsdbInspect.java on windows-x64 in Xcomp

2023-04-05 Thread Daniel D . Daugherty
Trivial fixes to ProblemList a couple of tests: [JDK-8305678](https://bugs.openjdk.org/browse/JDK-8305678) ProblemList serviceability/sa/ClhsdbInspect.java on windows-x64 in Xcomp [JDK-8305679](https://bugs.openjdk.org/browse/JDK-8305679) ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java

Re: Integrated: 8305602: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java

2023-04-04 Thread Daniel D . Daugherty
On Tue, 4 Apr 2023 18:58:12 GMT, Mandy Chung wrote: > This gives time to investigate JDK-8305600 and understand why the test didn't > fail on my testing before the push. Thumbs up. This is a trivial fix. - Marked as reviewed by dcubed (Reviewer). PR Review: https://git.openjdk.or

Re: RFR: JDK-8304163: Move jdk.internal.module.ModuleInfoWriter to the test library [v2]

2023-03-20 Thread Daniel D . Daugherty
On Sat, 18 Mar 2023 19:14:09 GMT, Mandy Chung wrote: >> `ModuleInfoWriter` is not used by the runtime. Move it to the test library >> as `jdk.test.lib.util.ModuleInfoWriter`. The tests are updated to use the >> test library instead. `ModuleInfoWriter` depends on `jdk.internal.module` >>

Re: RFR: 8303133: Update ProcessTols.startProcess(...) to exit early if process exit before linePredicate is printed.

2023-02-24 Thread Daniel D . Daugherty
On Fri, 24 Feb 2023 22:15:18 GMT, Leonid Mesnik wrote: > The solution proposed by Stefan K > > The startProcess() might wait forever for the expected line if the process > exits (failed to start). It makes sense to just fail earlier in such cases. > > The fix also move > 'output = new OutputAn

Re: RFR: 8301306: java/net/httpclient/* fail with -Xcomp: java.io.IOException: HTTP/1.1 header parser received no bytes

2023-01-30 Thread Daniel D . Daugherty
On Mon, 30 Jan 2023 07:16:17 GMT, SUN Guoyun wrote: > Hi all, > I think `BackgroundCompilation` should not be set to false when `-Xcomp` be > used, which causes the java thread to block for longer, then causing the > following tests failed frequently on the AArch64 and LoongArch64 architecture.

[jdk20] Integrated: 8300141: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC

2023-01-13 Thread Daniel D . Daugherty
On Fri, 13 Jan 2023 21:25:54 GMT, Daniel D. Daugherty wrote: > Trivial fixes to ProblemList some tests: > [JDK-8300141](https://bugs.openjdk.org/browse/JDK-8300141) ProblemList > java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC > [JDK-8300144](https://bugs.openjdk.org/browse

Re: [jdk20] Integrated: 8300141: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC

2023-01-13 Thread Daniel D . Daugherty
On Fri, 13 Jan 2023 22:43:09 GMT, Mikael Vidstedt wrote: >> Trivial fixes to ProblemList some tests: >> [JDK-8300141](https://bugs.openjdk.org/browse/JDK-8300141) ProblemList >> java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC >> [JDK-8300144](https://bugs.openjdk.org/browse/JDK-8300144)

[jdk20] Integrated: 8300141: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC

2023-01-13 Thread Daniel D . Daugherty
Trivial fixes to ProblemList some tests: [JDK-8300141](https://bugs.openjdk.org/browse/JDK-8300141) ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC [JDK-8300144](https://bugs.openjdk.org/browse/JDK-8300144) ProblemList vmTestbase/nsk/sysdict/vm/stress/chain/chain007/chain007.j

  1   2   >