On Wed, 14 Jun 2023 16:54:55 GMT, Andrew Haley <a...@openjdk.org> wrote:
>> The implementation changes look good. >> >> The update to test looks okay too although I would like to see if we can do >> better in SVC and STS when there is a SO. In passing, I think all usages of >> tlr should be replaced with ThreadLocalRandom.current(). > >> The implementation changes look good. >> >> The update to test looks okay too although I would like to see if we can do >> better in SVC and STS when there is a SO. > > That would be nice, but it's something of a can of worms. > >> In passing, I think all usages of tlr should be replaced with >> ThreadLocalRandom.current(). > > OK. @theRealAph - So the GHA results for this PR show that serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03 failed. Why wasn't this addressed prior to integration? We saw 5 instances of this failure mode in every Mach5 Tier1 and 20 instances in every Mach5 Tier3 after this PR was integrated. This was not an intermittent failure. I've applied the fix that @AlanBateman proposed in [JDK-8310211](https://bugs.openjdk.org/browse/JDK-8310211) and that appears to have solved the issue for Mach5 Tier1. I'll have to wait for the fix to reach Mach5 Tier3 before I can declare that one is also good. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14399#issuecomment-1595049357
