On Fri, 30 May 2025 11:57:39 GMT, Volkan Yazici wrote:
> Reverts certain [JDK-8353197](https://bugs.openjdk.org/browse/JDK-8353197)
> (which implements JavaDoc improvement and precautionary naming for certain
> unsafe methods in `jdk.internal.access.JavaLangAccess`) changes that are
> found to
On Wed, 4 Jun 2025 17:39:55 GMT, Chen Liang wrote:
>> Kim Barrett has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - add pseudo-native entry for Reference.get0
>> - tidy CallGenerator lookup in Compile ctor
>
> src/hotspot/share/opto/com
On Fri, 6 Jun 2025 05:57:16 GMT, Kim Barrett wrote:
>> Please review this change which adds a native method providing the
>> implementation of Reference::get. Referece::get is an intrinsic candidate,
>> so
>> this native method implementation is only used when the intrinsic is not.
>>
>> Curre
> Please review this change which adds a native method providing the
> implementation of Reference::get. Referece::get is an intrinsic candidate, so
> this native method implementation is only used when the intrinsic is not.
>
> Currently there is intrinsic support by the interpreter, C1, C2, and
On Wed, 4 Jun 2025 09:53:13 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the issue
> noted in https://bugs.openjdk.org/browse/JDK-8349914?
>
> The ZIP specification allows for more than one entry to have the same file
> name (and may have differ
On Wed, 4 Jun 2025 09:53:13 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the issue
> noted in https://bugs.openjdk.org/browse/JDK-8349914?
>
> The ZIP specification allows for more than one entry to have the same file
> name (and may have differ
On Tue, 3 Jun 2025 20:14:31 GMT, Per Minborg wrote:
> This PR proposes to simplify lazy computation related to resource bundles.
> Previously, some objects were computed lazily using a double-checked locking
> algorithm. StableValues offers a more robust and succinct solution.
>
>
> This P
On Tue, 3 Jun 2025 20:14:31 GMT, Per Minborg wrote:
> This PR proposes to simplify lazy computation related to resource bundles.
> Previously, some objects were computed lazily using a double-checked locking
> algorithm. StableValues offers a more robust and succinct solution.
>
>
> This P
On Sat, 17 May 2025 11:25:58 GMT, fabioromano1 wrote:
>> The [Rampdown Phase One](https://openjdk.org/projects/jdk/25/) for JDK 25 is
>> about 3 weeks from now.
>>
>> I think it's a bit too late for API additions to be approved in due time.
>> And even if we could rush this work for 25, it mak
On Tue, 3 Jun 2025 20:14:31 GMT, Per Minborg wrote:
> This PR proposes to simplify lazy computation related to resource bundles.
> Previously, some objects were computed lazily using a double-checked locking
> algorithm. StableValues offers a more robust and succinct solution.
>
>
> This P
> Please review this PR which improves occurrences of lazy computation in
> `Locale` and `BaseLocale`.
>
> Existing lazy initialization strategies such as CHM, static nested class, and
> local inner class are replaced with Stable Values.
>
> Lambda usage is intentionally avoided in this change
On Sun, 22 Oct 2023 17:26:52 GMT, Laurent Bourgès wrote:
>> * improved mixed insertion sort (makes whole sorting faster)
>> * introduced Radix which sort shows several times boost of performance and
>> has linear complexity instead of n*ln(n)
>> * improved merging sort for almost sorted data
>>
> This PR builds on a concept John Rose told me about some time ago. Instead of
> combining memory operations of various sizes, a single large and skewed
> memory operation can be made to clean up the tail of remaining bytes.
>
> This has the effect of simplifying and shortening the code. The nu
On Tue, 3 Jun 2025 20:14:31 GMT, Per Minborg wrote:
> This PR proposes to simplify lazy computation related to resource bundles.
> Previously, some objects were computed lazily using a double-checked locking
> algorithm. StableValues offers a more robust and succinct solution.
>
>
> This P
On Thu, 5 Jun 2025 11:50:01 GMT, Johannes Döbler wrote:
>> Please review this PR which improves occurrences of lazy computation in
>> `Locale` and `BaseLocale`.
>>
>> Existing lazy initialization strategies such as CHM, static nested class,
>> and local inner class are replaced with Stable Val
On Thu, 5 Jun 2025 18:32:34 GMT, Justin Lu wrote:
>> src/java.base/share/classes/java/util/Locale.java line 2578:
>>
>>> 2576: return Set.of(LocaleISOData.ISO3166_3);
>>> 2577: }
>>> 2578: });
>>
>> What about moving these four stable suppliers an
On Thu, 5 Jun 2025 08:42:38 GMT, Kim Barrett wrote:
>> Please review this change which adds a native method providing the
>> implementation of Reference::get. Referece::get is an intrinsic candidate,
>> so
>> this native method implementation is only used when the intrinsic is not.
>>
>> Curre
On Thu, 5 Jun 2025 01:42:00 GMT, Naoto Sato wrote:
>> Changes to generate CLDR resource bundles in UTF-8 encoding. The resource
>> files in `java.base` are supposed to be US English only, but they also need
>> to use UTF-8 as some of the names are non-ASCII (e.g., Türkiye)
>
> Looks like this P
> Changes to generate CLDR resource bundles in UTF-8 encoding. The resource
> files in `java.base` are supposed to be US English only, but they also need
> to use UTF-8 as some of the names are non-ASCII (e.g., Türkiye)
Naoto Sato has updated the pull request incrementally with one additional
c
On Wed, 14 May 2025 18:16:13 GMT, Artur Barashev wrote:
>> When the deafult SunX509KeyManagerImpl is being used we are in violation of
>> TLSv1.3 RFC spec because we ignore peer supported certificate signatures
>> sent to us in "signature_algorithms"/"signature_algorithms_cert" extensions:
>> h
On Fri, 2 May 2025 14:48:01 GMT, Nizar Benalla wrote:
> Get JDK 26 underway.
This pull request has now been integrated.
Changeset: af87035b
Author:Nizar Benalla
Committer: Jesper Wilhelmsson
URL:
https://git.openjdk.org/jdk/commit/af87035b713f8bfe05a007a4d4670cefc6a6aaf2
Stats:
On Thu, 5 Jun 2025 09:36:37 GMT, Alice Pellegrini wrote:
>> The implemented solution modifies the `OutputBuffer` implementation instead
>> of the `OutputAnalyzer` implementation.
>> This is because the **OutputBuffer implementation which handles processes**
>> (LazyOutputBuffer) starts a thread
On Thu, 5 Jun 2025 13:11:39 GMT, David Holmes wrote:
> To where is the output going "as it happens"?
If the `outputanalyzer.verbose` flag is set, the output is going to be printed
to the console, in addition to being stored in the buffer
> If you use OutputAnalyzer correctly then on failure al
On Thu, 5 Jun 2025 09:36:37 GMT, Alice Pellegrini wrote:
>> The implemented solution modifies the `OutputBuffer` implementation instead
>> of the `OutputAnalyzer` implementation.
>> This is because the **OutputBuffer implementation which handles processes**
>> (LazyOutputBuffer) starts a thread
This PR proposes to simplify lazy computation related to resource bundles.
Previously, some objects were computed lazily using a double-checked locking
algorithm. StableValues offers a more robust and succinct solution.
This PR passes tier1, tier2, and tier3 on multiple platforms.
-
On Wed, 4 Jun 2025 21:54:15 GMT, Naoto Sato wrote:
> Changes to generate CLDR resource bundles in UTF-8 encoding. The resource
> files in `java.base` are supposed to be US English only, but they also need
> to use UTF-8 as some of the names are non-ASCII (e.g., Türkiye)
Marked as reviewed by e
On Thu, 5 Jun 2025 06:04:49 GMT, Volkan Yazici wrote:
>> Reverts certain [JDK-8353197](https://bugs.openjdk.org/browse/JDK-8353197)
>> (which implements JavaDoc improvement and precautionary naming for certain
>> unsafe methods in `jdk.internal.access.JavaLangAccess`) changes that are
>> found
On Thu, 5 Jun 2025 07:47:17 GMT, Viktor Klang wrote:
> It's too fragile to depend on generated NPE messages
This pull request has now been integrated.
Changeset: 782bbca4
Author:Viktor Klang
URL:
https://git.openjdk.org/jdk/commit/782bbca439cd0d6db9366b4bd8d4861b8f780203
Stats:
On Wed, 4 Jun 2025 21:20:46 GMT, Justin Lu wrote:
> Please review this PR which improves occurrences of lazy computation in
> `Locale` and `BaseLocale`.
>
> Existing lazy initialization strategies such as CHM, static nested class, and
> local inner class are replaced with Stable Values.
>
> L
On Wed, 4 Jun 2025 21:20:46 GMT, Justin Lu wrote:
> Please review this PR which improves occurrences of lazy computation in
> `Locale` and `BaseLocale`.
>
> Existing lazy initialization strategies such as CHM, static nested class, and
> local inner class are replaced with Stable Values.
>
> L
On Thu, 5 Jun 2025 07:47:17 GMT, Viktor Klang wrote:
> It's too fragile to depend on generated NPE messages
Dropping checking the message detail okay for now to remove the noise.
-
Marked as reviewed by alanb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25655#pullreques
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote:
> Could I have review of an enhancement that adds rate-limited sampling to Java
> events, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
>
On Thu, 5 Jun 2025 10:10:41 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
On Thu, 5 Jun 2025 09:48:46 GMT, erifan wrote:
> Oh I think we still cannot use `BoolTest::negate`, because we cannot
> instantiate a `BoolTest` object with **unsigned** comparison.
> `BoolTest::negate` is a non-static function.
I see. Ok. Hmm. I still think that the logic should be in `BoolTe
On Thu, 5 Jun 2025 10:10:41 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
On Thu, 5 Jun 2025 10:35:10 GMT, Alan Bateman wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move the timestamp to before the try block, change bytes to bytesWritten
>> and remove unnecessary code
>
> src/java.bas
On Thu, 5 Jun 2025 10:10:41 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
On Thu, 5 Jun 2025 00:18:34 GMT, Chen Liang wrote:
>> Please review this PR which improves occurrences of lazy computation in
>> `Locale` and `BaseLocale`.
>>
>> Existing lazy initialization strategies such as CHM, static nested class,
>> and local inner class are replaced with Stable Values.
On Thu, 5 Jun 2025 09:51:51 GMT, Alan Bateman wrote:
>> Erik Gahlin has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Remove the mistakenly added file.
>> - Fix whitespace
>
> src/jdk.jfr/share/conf/jfr/default.jfc line 845:
>
>> 843:
On Thu, 5 Jun 2025 10:10:41 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
On Thu, 5 Jun 2025 09:24:10 GMT, Emanuel Peter wrote:
> FYI: `BoolTest::negate` already does what you want: `mask negate( ) const {
> return mask(_test^4); }` I think you should use that instead :)
Indeed, I hadn't noticed that, thank you.
-
PR Comment: https://git.openjdk.org/jdk
> Could I have review of an enhancement that adds rate-limited sampling to Java
> events, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> Erik
Erik Gahlin has updated the pull request incremen
> Passes the `Charset` read from the `stdin.encoding` system property while
> creating `InputStreamReader` or `Scanner` instances for `System.in`.
>
> `stdin.encoding` is a recently added property for Java 25 in
> [JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703). Employing it
> throug
On Thu, 5 Jun 2025 07:47:17 GMT, Viktor Klang wrote:
> It's too fragile to depend on generated NPE messages
Sorry Viktor but I strongly disagree. It is far too easy to have a test "pass"
because it catches the wrong instance of a thrown exception and hide an
underlying problem.
-
On Wed, 28 May 2025 12:18:15 GMT, Emanuel Peter wrote:
>> erifan has updated the pull request with a new target base due to a merge or
>> a rebase. The incremental webrev excludes the unrelated changes brought in
>> by the merge/rebase. The pull request contains 10 additional commits since
>>
On Thu, 5 Jun 2025 09:41:10 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
On Thu, 29 May 2025 01:44:49 GMT, Xiaohong Gong wrote:
>> test/micro/org/openjdk/bench/jdk/incubator/vector/MaskCompareNotBenchmark.java
>> line 49:
>>
>>> 47: private static final VectorSpecies L_SPECIES =
>>> LongVector.SPECIES_MAX;
>>> 48: private static final VectorSpecies F_SPECIE
On Thu, 5 Jun 2025 09:32:15 GMT, erifan wrote:
> > FYI: `BoolTest::negate` already does what you want: `mask negate( ) const {
> > return mask(_test^4); }` I think you should use that instead :)
>
> Indeed, I hadn't noticed that, thank you.
Oh I think we still cannot use `BoolTest::negate`, be
On Thu, 5 Jun 2025 09:41:10 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
> The implemented solution modifies the `OutputBuffer` implementation instead
> of the `OutputAnalyzer` implementation.
> This is because the **OutputBuffer implementation which handles processes**
> (LazyOutputBuffer) starts a thread in its constructor, so we would need to
> add a strange addit
On Wed, 28 May 2025 12:28:20 GMT, Emanuel Peter wrote:
>> test/hotspot/jtreg/compiler/vectorapi/VectorMaskCompareNotTest.java line 237:
>>
>>> 235: // Byte tests
>>> 236: @Test
>>> 237: @IR(counts = { IRNode.XOR_V_MASK, "= 0", IRNode.XOR_VB, "= 0" },
>>
>> Could you still assert the
On Thu, 5 Jun 2025 09:31:39 GMT, Erik Gahlin wrote:
>> I think we (from both the java.base and jdk.jfr perspectives) need to keep
>> an eye on the complexity of the use sites. The new throttling stuff requires
>> a new local variable. By itself this isn't a big deal, but there are 12
>> events
On Thu, 5 Jun 2025 09:37:45 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
On Thu, 5 Jun 2025 00:21:45 GMT, Stuart Marks wrote:
>> We need some indication of which events are throttleable and looking at the
>> mirror event may not work in some scenarios.
>>
>> We need to sample the endTime, because the startTime may be several minutes
>> in the past. We could use com
> Could I have review of an enhancement that adds rate-limited sampling to Java
> events, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> Erik
Erik Gahlin has updated the pull request incremen
On Thu, 5 Jun 2025 09:26:13 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
On Thu, 5 Jun 2025 09:12:30 GMT, erifan wrote:
>> This patch optimizes the following patterns:
>> For integer types:
>>
>> (XorV (VectorMaskCmp src1 src2 cond) (Replicate -1))
>> => (VectorMaskCmp src1 src2 ncond)
>> (XorVMask (VectorMaskCmp src1 src2 cond) (MaskAll m1))
>> => (VectorMas
> Could I have review of an enhancement that adds rate-limited sampling to Java
> events, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> Erik
Erik Gahlin has updated the pull request incremen
On Mon, 2 Jun 2025 11:54:10 GMT, Alice Pellegrini wrote:
> The implemented solution modifies the `OutputBuffer` implementation instead
> of the `OutputAnalyzer` implementation.
> This is because the **OutputBuffer implementation which handles processes**
> (LazyOutputBuffer) starts a thread in
The implemented solution modifies the `OutputBuffer` implementation instead of
the `OutputAnalyzer` implementation.
This is because the **OutputBuffer implementation which handles processes**
(LazyOutputBuffer) starts a thread in its constructor, so we would need to add
a strange additional cons
> Please review this change which adds a native method providing the
> implementation of Reference::get. Referece::get is an intrinsic candidate, so
> this native method implementation is only used when the intrinsic is not.
>
> Currently there is intrinsic support by the interpreter, C1, C2, and
On Thu, 29 May 2025 07:55:06 GMT, erifan wrote:
>> Also: You now cast `(VectorMaskCmpNode*) in1` twice. Can we not do
>> `as_VectorMaskCmp()`? Or could we at least cast it only once, and then use
>> it as `in1_mask_cmp` instead?
>
>> What is the hard-coded ^ 4 here?
>
> This is to negate the c
On Thu, 5 Jun 2025 08:12:29 GMT, David Holmes wrote:
> It is far too easy to have a test "pass" because it catches the wrong
> instance of a thrown exception and hide an underlying problem.
OmitStackTraceInFastThrow is enabled by default so possible for C2 to compile
this to throw a pre-alloca
> This patch optimizes the following patterns:
> For integer types:
>
> (XorV (VectorMaskCmp src1 src2 cond) (Replicate -1))
> => (VectorMaskCmp src1 src2 ncond)
> (XorVMask (VectorMaskCmp src1 src2 cond) (MaskAll m1))
> => (VectorMaskCmp src1 src2 ncond)
>
> cond can be eq, ne, le, ge, l
On Thu, 29 May 2025 08:00:05 GMT, erifan wrote:
>> src/hotspot/share/opto/vectornode.cpp line 2233:
>>
>>> 2231: if (in2->Opcode() == Op_VectorMaskCast) {
>>> 2232: in2 = in2->in(1);
>>> 2233: }
>>
>> Wow, this seems to be an addition that is not covered in the patterns you
>> mention
On Wed, 28 May 2025 12:03:48 GMT, Emanuel Peter wrote:
>> erifan has updated the pull request with a new target base due to a merge or
>> a rebase. The incremental webrev excludes the unrelated changes brought in
>> by the merge/rebase. The pull request contains 10 additional commits since
>>
On Thu, 5 Jun 2025 08:12:29 GMT, David Holmes wrote:
>> It's too fragile to depend on generated NPE messages
>
> Sorry Viktor but I strongly disagree. It is far too easy to have a test
> "pass" because it catches the wrong instance of a thrown exception and hide
> an underlying problem.
@dholm
On Tue, 3 Jun 2025 07:55:06 GMT, Volkan Yazici wrote:
>> Passes the `Charset` read from the `stdin.encoding` system property while
>> creating `InputStreamReader` or `Scanner` instances for `System.in`.
>>
>> `stdin.encoding` is a recently added property for Java 25 in
>> [JDK-8350703](https:/
On Thu, 5 Jun 2025 08:40:44 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
> Could I have review of an enhancement that adds rate-limited sampling to Java
> events, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> Erik
Erik Gahlin has updated the pull request with a n
On Wed, 4 Jun 2025 21:20:46 GMT, Justin Lu wrote:
> Please review this PR which improves occurrences of lazy computation in
> `Locale` and `BaseLocale`.
>
> Existing lazy initialization strategies such as CHM, static nested class, and
> local inner class are replaced with Stable Values.
>
> L
> Could I have review of an enhancement that adds rate-limited sampling to Java
> events, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> Erik
Erik Gahlin has updated the pull request with a n
> Could I have review of an enhancement that adds rate-limited sampling to Java
> events, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> Erik
Erik Gahlin has updated the pull request with a n
It's too fragile to depend on generated NPE messages
-
Commit messages:
- Removing exception message check to avoid failures if helpful NPEs are
turned off
Changes: https://git.openjdk.org/jdk/pull/25655/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25655&range=00
Issu
74 matches
Mail list logo
