On Thu, 5 Jun 2025 10:10:41 GMT, Erik Gahlin <egah...@openjdk.org> wrote:

>> Could I have review of an enhancement that adds rate-limited sampling to 
>> Java events, including five events in the JDK (SocketRead, SocketWrite, 
>> FileRead, FileWrite, and JavaExceptionThrow).
>> 
>> Testing: test/jdk/jdk/jfr
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Move the timestamp to before the try block, change bytes to bytesWritten 
> and remove unnecessary code

src/java.base/share/classes/java/lang/Throwable.java line 124:

> 122:      * exceptions should be traced by JFR.
> 123:      */
> 124:     static boolean jfrTracing;

Are you sure this is okay?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25559#discussion_r2128525269

Reply via email to