On Sun, 25 May 2025 04:39:24 GMT, Chen Liang wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> create method share variant val & coder
>
> src/java.base/share/classes/java/lang/String.java line 703:
>
>> 701:
> Through JVM Option +PrintInlining, we found that String has a constructor
> codeSize of 852, which is too large. This caused failed to inline.
>
> The following is the output information of PrintInlining:
>
> @ 9 java.lang.String:: (12 bytes) inline (hot)
> !m
> Through JVM Option +PrintInlining, we found that String has a constructor
> codeSize of 852, which is too large. This caused failed to inline.
>
> The following is the output information of PrintInlining:
>
> @ 9 java.lang.String:: (12 bytes) inline (hot)
> !m
On Sun, 25 May 2025 04:47:35 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/java/lang/String.java line 569:
>>
>>> 567: }
>>> 568: this.value = str.value;
>>> 569: this.coder = str.coder;
>>
>> Suggestion:
>>
>> this(str);
>>
>> We have integrated flexi
On Sun, 25 May 2025 04:40:44 GMT, Chen Liang wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> create method share variant val & coder
>
> src/java.base/share/classes/java/lang/String.java line 569:
>
>> 567:
On Tue, 20 May 2025 02:11:34 GMT, Shaojin Wen wrote:
>> Through JVM Option +PrintInlining, we found that String has a constructor
>> codeSize of 852, which is too large. This caused failed to inline.
>>
>> The following is the output information of PrintInlining:
>>
>> @ 9 ja
On Sat, 24 May 2025 23:04:50 GMT, Chen Liang wrote:
>> Classes such as java.lang.CharacterDataXXX have multiple static final
>> arrays, which will not be modified. We should add @Stable to provide
>> information to the optimizer.
>
> make/jdk/src/classes/build/tools/generatecharacter/GenerateCh
On Sat, 24 May 2025 23:40:56 GMT, Shaojin Wen wrote:
>> make/jdk/src/classes/build/tools/generatecharacter/GenerateCharacter.java
>> line 1195:
>>
>>> 1193: result.append(" @Stable static final ");
>>> 1194: result.append(atype);
>>> 1195: result.append(" ").append(
On Sat, 24 May 2025 10:00:56 GMT, Shaojin Wen wrote:
> Classes such as java.lang.CharacterDataXXX have multiple static final arrays,
> which will not be modified. We should add @Stable to provide information to
> the optimizer.
make/jdk/src/classes/build/tools/generatecharacter/GenerateCharact
Classes such as java.lang.CharacterDataXXX have multiple static final arrays,
which will not be modified. We should add @Stable to provide information to the
optimizer.
-
Commit messages:
- sealed & final
- add @Stable
- stable
Changes: https://git.openjdk.org/jdk/pull/25430/fil
Hello Shaojin,
I think your proposal is reasonable. These arrays are never mutated. Meanwhile
I see some declarations like int A[] in CharacterData00, would be nice if you
can convert those declarations to like int[] A too.
Regards,
Chen
From: core-libs-dev on b
Classes such as java.lang.CharacterDataXXX have multiple static final arrays,
which will not be modified. We should add @Stable to provide information to the
optimizer.
such as
```java
class CharacterData00 {
@Stable static final char[] X =
@Stable static final char[] Y =
@Stable static final int
On Thu, 15 May 2025 22:03:22 GMT, Shaojin Wen wrote:
> In HexDigits, getCharsLatin1 and getCharsUTF16 are no longer used, so remove
> these methods
This pull request has now been integrated.
Changeset: b0373537
Author:Shaojin Wen
URL:
https://git.openjdk.org/jdk/commit/b037353734fd
On Sat, 24 May 2025 11:35:33 GMT, Doug Lea wrote:
> Method startDelayScheduler should trap the ISE thrown by
> SharedThreadContainer.start and possibly re-try termination before eventually
> throwing RejectedExecutionException.
src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java
On Sat, 24 May 2025 07:19:24 GMT, Shaojin Wen wrote:
>> Integer::digits type can use byte[] instead of char[], which can reduce the
>> conversion from char to byte in the process of Integer.toString. Using
>> byte[] can also save memory.
>
> Shaojin Wen has updated the pull request incrementall
On Fri, 23 May 2025 11:40:24 GMT, Sorna Sarathi N wrote:
> Adds missing classpath exception in a couple of files.
This pull request has now been integrated.
Changeset: 1f24a541
Author:Sorna Sarathi N
Committer: Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/commit/1f24a5414d735f9
Chen,
thank you for your approval for a DRAFT PR.
Following your proposal, I have published a DRAFT PR at
https://github.com/openjdk/jdk/pull/25432 so everybody can see what the
actual intended code change looks like, and better focus on that actual
code change and its risks and benefits. T
On Fri, 23 May 2025 11:40:24 GMT, Sorna Sarathi N wrote:
> Adds missing classpath exception in a couple of files.
@Sorna-Sarathi
Your change (at version 1778c756b997c47938fff1bf15bb8c6b5b855af5) is now ready
to be sponsored by a Committer.
-
PR Comment: https://git.openjdk.org/jd
On Sat, 24 May 2025 07:19:24 GMT, Shaojin Wen wrote:
>> Integer::digits type can use byte[] instead of char[], which can reduce the
>> conversion from char to byte in the process of Integer.toString. Using
>> byte[] can also save memory.
>
> Shaojin Wen has updated the pull request incrementall
Method startDelayScheduler should trap the ISE thrown by
SharedThreadContainer.start and possibly re-try termination before eventually
throwing RejectedExecutionException.
-
Commit messages:
- undo wrong origin
- Handle IllegalStateException from SharedThreadContainer.start
- Rev
On Sat, 24 May 2025 07:19:24 GMT, Shaojin Wen wrote:
>> Integer::digits type can use byte[] instead of char[], which can reduce the
>> conversion from char to byte in the process of Integer.toString. Using
>> byte[] can also save memory.
>
> Shaojin Wen has updated the pull request incrementall
Collections.max(List.of(a, b))?
On Tue, May 13, 2025 at 7:12 PM Tagir Valeev wrote:
> The alternatives we have now:
> BinaryOperator.maxBy(Comparator.naturalOrder()).apply(a, b);
> This speaks clearly about the intent (we'd like to get the maximum and we
> write 'maxBy') but very wordy.
>
> Stre
> Hi, please consider the following patch.
>
> This patch replaces the existing close-file-descriptors-logic we follow
> before exec'ing a target binary: instead of explicitly closing the file
> descriptors, we mark them as CLOEXEC. That simplifies the logic: it gets rid
> of the awkward tiptoe
> See bug description. We now unblock all signals in both FORK and POSIX_SPAWN
> launch modes. This fixes the problem and makes the behavior consistent across
> these two modes.
>
> I left the VFORK mode alone since I believe the signal state is still shared
> with the parent. One more reason t
On Fri, 23 May 2025 18:57:45 GMT, Roger Riggs wrote:
>> Tagir F. Valeev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make min and max generic
>
> src/java.base/share/classes/java/util/Comparator.java line 206:
>
>> 204: * @since
> Implementation of Comparator.min and Comparator.max methods. Preliminary
> discussion is in this thread:
> https://mail.openjdk.org/pipermail/core-libs-dev/2025-May/145638.html
> The specification is mostly composed of Math.min/max and Collections.min/max
> specifications.
>
> The methods are
On Fri, 23 May 2025 20:37:05 GMT, Andrey Turbanov wrote:
>> Tagir F. Valeev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make min and max generic
>
> src/java.base/share/classes/java/util/Comparator.java line 200:
>
>> 198: * @p
> Integer::digits type can use byte[] instead of char[], which can reduce the
> conversion from char to byte in the process of Integer.toString. Using byte[]
> can also save memory.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
sta
Integer::digits type can use byte[] instead of char[], which can reduce the
conversion from char to byte in the process of Integer.toString. Using byte[]
can also save memory.
-
Commit messages:
- char[] -> byte[]
Changes: https://git.openjdk.org/jdk/pull/25426/files
Webrev: htt
29 matches
Mail list logo
